Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2272420iof; Wed, 8 Jun 2022 01:04:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYYzV2jA0VWOt7umOAyc/ClY9/wRY5zv851U4hLORHn5m/n0ipEZg1RUdynIIQHwk6Mwyg X-Received: by 2002:a05:6a00:1801:b0:51c:1001:6241 with SMTP id y1-20020a056a00180100b0051c10016241mr16341345pfa.81.1654675466675; Wed, 08 Jun 2022 01:04:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654675466; cv=none; d=google.com; s=arc-20160816; b=EfncglQQDBjj+pFWnFA7yKGKL42jdxxzI2WLyA/kchAKHWZ4xSvMIfYpvUal1CrgJ6 38igK7nRZj3/K7JK0mLKg1bTFviyUcZRQQ5n46qtww/zoayui+nkgfx/trjJoaEB1j90 lhnND4JH/zqu3brfijQLT0lN3QC6eHQwN0H7F+6dY020nVjrg6P4bF5yep2s6QViLhcR SsRRAHZ+axwm6K37+hwvVylK+K1C+OOEP2PtyYHw3xtvZwVdiYzapPAxBIDSoyERtUjr 4qI4C6wC2Va7teN4rdUJZs7NcCPG/N11WQzC5X7CnyfesWaxaxP74KlhLmPVqbY1hIgu RYpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Pzse/QB9aRC+EUWbIgHVaI6DLhpr1tk8pZ76WVb8I8w=; b=H3ux92c+tnEhPXMuGnkdu+93QZS1r6WqAIV0AfJmqpHJed3l3AUHpDG8WWRW4dlXT+ 0HlLuNzirVHpMxpR+qIip7LitrNoBeCK8gkznYDNh1b2vrd3/bPZZwGcVBc1Mu0OT7TA PMt4HT+pq/hVxMo4Q0plltPs2o1EK8k4ev4ZcNTANpDwmCW2zN66fNkRl4P25cxwCCR+ SFlRhEm6mXp8c6d3RzdPATrEktPrpjkIuj3suT9k9Fdb7K3t677dd2jBIRjZcwFtEW1B 0e8pWzkWNqgGsG865vCFxF09rl/p+YbyOCQUlS2kbSE353Jr0GAd3+5OLiKFJrNaeCl3 LwjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MRanoril; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id y7-20020a17090a600700b001e2dc25a158si30628359pji.61.2022.06.08.01.04.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 01:04:26 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MRanoril; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7EA61237C87; Wed, 8 Jun 2022 00:33:58 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358057AbiFGUDb (ORCPT + 99 others); Tue, 7 Jun 2022 16:03:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353267AbiFGTDo (ORCPT ); Tue, 7 Jun 2022 15:03:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6336617997B; Tue, 7 Jun 2022 11:05:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6D9DB617AE; Tue, 7 Jun 2022 18:05:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E00BC385A5; Tue, 7 Jun 2022 18:05:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654625108; bh=z16glOCFgiD3g2TkfWOUF6DAFKVA0fXskdcPq/Fr26U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MRanorilaiFemHLDd3Vs2jvykbgwWYzMNjfWFVkP/ayAUqGLnXlFMWS460lhZFxSv Gp9wpgOhDnKT31f4GLhfHC+LiTNKIA6RLkYrcYqhTWul2TETpJIJ8pDjGt0suFMneh RadcIlKe9BG52RzQiTWskPz8Y/yEq02hbNol1xy0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Emmanuel Grumbach , Gregory Greenman , Johannes Berg Subject: [PATCH 5.15 528/667] iwlwifi: mvm: fix assert 1F04 upon reconfig Date: Tue, 7 Jun 2022 19:03:13 +0200 Message-Id: <20220607164950.539226478@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220607164934.766888869@linuxfoundation.org> References: <20220607164934.766888869@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Emmanuel Grumbach commit 9d096e3d3061dbf4ee10e2b59fc2c06e05bdb997 upstream. When we reconfig we must not send the MAC_POWER command that relates to a MAC that was not yet added to the firmware. Ignore those in the iterator. Cc: stable@vger.kernel.org Signed-off-by: Emmanuel Grumbach Signed-off-by: Gregory Greenman Link: https://lore.kernel.org/r/20220517120044.ed2ffc8ce732.If786e19512d0da4334a6382ea6148703422c7d7b@changeid Signed-off-by: Johannes Berg Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/intel/iwlwifi/mvm/power.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/net/wireless/intel/iwlwifi/mvm/power.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/power.c @@ -563,6 +563,9 @@ static void iwl_mvm_power_get_vifs_itera struct iwl_power_vifs *power_iterator = _data; bool active = mvmvif->phy_ctxt && mvmvif->phy_ctxt->id < NUM_PHY_CTX; + if (!mvmvif->uploaded) + return; + switch (ieee80211_vif_type_p2p(vif)) { case NL80211_IFTYPE_P2P_DEVICE: break;