Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2282249iof; Wed, 8 Jun 2022 01:20:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxoQYMT13SknMaz6yt4Q/Pwg3DH/MfbJvjDv851zwPdQ+kpnmsQ/qw14sfZzMC96M/VvOCn X-Received: by 2002:a63:f242:0:b0:3fd:8a04:df6 with SMTP id d2-20020a63f242000000b003fd8a040df6mr16205010pgk.300.1654676447549; Wed, 08 Jun 2022 01:20:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654676447; cv=none; d=google.com; s=arc-20160816; b=uXdIua/c9Hqz2kRe+jhTEAdyuXJosizLJyQme9EF84hLPdSE99xdw8qDR25rzlW9It uF9WmI681J+WeyyAqWBoImzG8srxEdoN9a+ReZ0fHIuKnFzycHNNmwEvtesYO0U9Uqut 1ki7HXQSaBKk5qBoKudIorRJgRUYs7vx2c9sVpwgm8pJNdqVQWGfk3dzPSJKxLzFmMU9 0bmXBZQb6BClbTXDNHe5iwWnn1EwUCDpMuIDRyZC7vfkbLWWeDFUaaLQEH4b+8YPhGg7 uTscf/q0F6qvtSwFH2uzzxEvcpPEWqVWIEmpfPvzaNWnOBdmC0wvoQ/oH6/AWI2W2KBn 0zJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4kfpLRGHwgmF8HW96T8Wl7nW4i/owQKfevwqZcUL4xc=; b=o0uMeeN98R8eS1DidVtKlYdpfD3kKiJ7r/VPbd3Th67z8t8G7bWK1wb9ADJ2L7Xxy8 3Kp36dVDA0hZ62N2pizYf5HYJNOinJqJ80fNyLiZXWi0IjipOB0qFxnaxIkF2uhMO4CS Gdl9O+60rZKm5bUdG0xr+f12Gs9BG+xKuMcEqU08KUB70xSQWcc/wnmg3m/sBMQr1/jT N+0kDBOToPFYQwC1eGZYr/aTxks2C9vLwdSBY0stOsXQPGmRinppR/FDgjSQnoLkvZb7 Rt8JfiCot9gCNLC2IeeXQf9K4uHEtsbUhXiJMxhAahdnKmCaB+n9qZEM6A0Ah4VjfSI/ kHQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kIiIkwPb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id e18-20020a170903241200b001617784ea88si17081853plo.356.2022.06.08.01.20.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 01:20:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kIiIkwPb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9CDF2182A46; Wed, 8 Jun 2022 00:50:42 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1386500AbiFGWtA (ORCPT + 99 others); Tue, 7 Jun 2022 18:49:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1381244AbiFGVkU (ORCPT ); Tue, 7 Jun 2022 17:40:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CA5223236C; Tue, 7 Jun 2022 12:06:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D8A7A617DA; Tue, 7 Jun 2022 19:06:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0835C385A2; Tue, 7 Jun 2022 19:06:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654628761; bh=7BUSsPCv2pbS4QHIqmCypyI9AizY3jjKrtxtZUOl0cw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kIiIkwPbddpKn5o3BoExFqsb3M96mgHl/VOcmxRrqAp87vFnSgG/H4UWGtWHgCFHi V27RqMrUv7N/4vlPyAiYKsbADd+VGGQ+ab+457KWDsGRVHlPEmcYcHo2Ba+8QGT99M 2T5O/WX54scipXqxD7MZBe/g79isGcxzoM9mHGZQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.18 445/879] media: exynos4-is: Change clk_disable to clk_disable_unprepare Date: Tue, 7 Jun 2022 18:59:23 +0200 Message-Id: <20220607165015.788712679@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220607165002.659942637@linuxfoundation.org> References: <20220607165002.659942637@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit 9fadab72a6916c7507d7fedcd644859eef995078 ] The corresponding API for clk_prepare_enable is clk_disable_unprepare, other than clk_disable. Fix this by changing clk_disable to clk_disable_unprepare. Fixes: b4155d7d5b2c ("[media] exynos4-is: Ensure fimc-is clocks are not enabled until properly configured") Signed-off-by: Miaoqian Lin Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/samsung/exynos4-is/fimc-is.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-is.c b/drivers/media/platform/samsung/exynos4-is/fimc-is.c index 81b290dace3a..e3072d69c49f 100644 --- a/drivers/media/platform/samsung/exynos4-is/fimc-is.c +++ b/drivers/media/platform/samsung/exynos4-is/fimc-is.c @@ -140,7 +140,7 @@ static int fimc_is_enable_clocks(struct fimc_is *is) dev_err(&is->pdev->dev, "clock %s enable failed\n", fimc_is_clocks[i]); for (--i; i >= 0; i--) - clk_disable(is->clocks[i]); + clk_disable_unprepare(is->clocks[i]); return ret; } pr_debug("enabled clock: %s\n", fimc_is_clocks[i]); -- 2.35.1