Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 08 Jun 2022 07:39:02 +0200
Message-ID: <877d5rd895.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     huangwenhui <huangwenhuia@uniontech.com>
Cc:     tiwai@suse.com, perex@perex.cz, alsa-devel@alsa-project.org,
        kailang@realtek.com, tanureal@opensource.cirrus.com,
        jeremy.szu@canonical.com, linux-kernel@vger.kernel.org,
        wse@tuxedocomputers.com, hui.wang@canonical.com, sami@loone.fi,
        cam@neo-zeon.de
Subject: Re: [PATCH] ALSA: hda/realtek - Add HW8326 support
In-Reply-To: <20220608011227.15994-1-huangwenhuia@uniontech.com>
References: <20220608011227.15994-1-huangwenhuia@uniontech.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 08 Jun 2022 03:12:27 +0200,
huangwenhui wrote:
> 
> Added the support of new Huawei codec HW8326.
> 
> Signed-off-by: huangwenhui <huangwenhuia@uniontech.com>

Please give more description, as mentioned in the previous post, but
*in the patch itself*.  If it's compatible with the existing ALC256,
describe it there.

Also, when you post a newer version of the patch, add v2 prefix to the
subject, e.g.
  [PATCH v2] ALSA: hda/realtek - Add HW8326 support
(Of course at the next respin, it'll be v3 :)


thanks,

Takashi