Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <zajec5@gmail.com>
To:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
Subject: [PATCH] perf report: Skip symbols for idle symbols
Date:   Wed,  8 Jun 2022 07:51:46 +0200
Message-Id: <20220608055146.1446-1-zajec5@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

From: Rafał Miłecki <rafal@milecki.pl>

Displaying idle symbols is rather useless and makes reviewing "real"
symbols harder. perf top already skips them so perf report should
probably do the same.

BEFORE

# Overhead  Command          Shared Object          Symbol                             
# ........  ...............  .....................  ...................................
#
    75.04%  swapper          [kernel.kallsyms]      [k] arch_cpu_idle
     1.05%  ksoftirqd/0      [kernel.kallsyms]      [k] __pi___inval_dcache_area
     0.78%  ksoftirqd/0      [kernel.kallsyms]      [k] __netif_receive_skb_core
     0.75%  ksoftirqd/0      [kernel.kallsyms]      [k] fib_table_lookup
     0.58%  ksoftirqd/0      [kernel.kallsyms]      [k] __dev_queue_xmit
     0.56%  ksoftirqd/0      [kernel.kallsyms]      [k] bcm4908_enet_start_xmit
     0.55%  ksoftirqd/0      [kernel.kallsyms]      [k] __skb_flow_dissect
     0.53%  ksoftirqd/0      [kernel.kallsyms]      [k] __pi___clean_dcache_area_poc

AFTER

# Overhead  Command          Shared Object          Symbol                             
# ........  ...............  .....................  ...................................
#
     4.21%  ksoftirqd/0      [kernel.kallsyms]      [k] __pi___inval_dcache_area
     3.13%  ksoftirqd/0      [kernel.kallsyms]      [k] __netif_receive_skb_core
     3.01%  ksoftirqd/0      [kernel.kallsyms]      [k] fib_table_lookup
     2.32%  ksoftirqd/0      [kernel.kallsyms]      [k] __dev_queue_xmit
     2.23%  ksoftirqd/0      [kernel.kallsyms]      [k] bcm4908_enet_start_xmit
     2.21%  ksoftirqd/0      [kernel.kallsyms]      [k] __skb_flow_dissect
     2.13%  ksoftirqd/0      [kernel.kallsyms]      [k] __pi___clean_dcache_area_poc
     2.00%  ksoftirqd/0      [kernel.kallsyms]      [k] eth_type_trans
     1.86%  ksoftirqd/0      [kernel.kallsyms]      [k] bcm4908_enet_poll_rx
     1.73%  ksoftirqd/0      [kernel.kallsyms]      [k] __local_bh_enable_ip
     1.63%  ksoftirqd/0      [kernel.kallsyms]      [k] fib_rules_lookup
     1.61%  ksoftirqd/0      [kernel.kallsyms]      [k] bcm4908_enet_poll_tx
     (...)

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 tools/perf/builtin-report.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index afe4a5539ecc..7e31af009d44 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -316,9 +316,12 @@ static int process_sample_event(struct perf_tool *tool,
 				     &rep->total_cycles);
 	}
 
-	ret = hist_entry_iter__add(&iter, &al, rep->max_stack, rep);
-	if (ret < 0)
-		pr_debug("problem adding hist entry, skipping event\n");
+	if (al.sym == NULL || !al.sym->idle) {
+		ret = hist_entry_iter__add(&iter, &al, rep->max_stack, rep);
+		if (ret < 0)
+			pr_debug("problem adding hist entry, skipping event\n");
+	}
+
 out_put:
 	addr_location__put(&al);
 	return ret;
-- 
2.34.1