Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2293169iof; Wed, 8 Jun 2022 01:39:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqrZNnhnmoGdTXccK40zlKoEKJ3R5kPHAKuqtWvqEARpSed/ZIBSNXwRVNyhY5cqSKYGX/ X-Received: by 2002:a05:6a00:8ce:b0:510:9298:ea26 with SMTP id s14-20020a056a0008ce00b005109298ea26mr33323278pfu.55.1654677561092; Wed, 08 Jun 2022 01:39:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654677561; cv=none; d=google.com; s=arc-20160816; b=PBPiots9nicrFWnSp6lh9ZM1ZZmW1M7OOLHjWpD12qCvpFdITYoXILe6xA6QzJkQH6 tmUxB0+dcv//YQmVLiikMaIUzhR391F/+gaxkhy4GtzMaT3YCsdQ2cSNihrid+gJ+vGo Vpz6Ri+pzuOIqs5BIKdW0BiM6CsXyNiTeWBCeo7BBqi/SMw2yUQ73BSFcAsiVaNqPIOH RAc2KPGSqQ2NqEmFNmesiW+ddiUOVvREpWITUw+FSrOZh2pzJ+tJd700Nsa1xMOodSt9 JlSMKpOOKVdsf3MnFhL5S1hML9M7qrxwLwsJhQxZFg0LX82DLhsjgIc6fWzlaWowo8wJ +t/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=Q3uqwWR5TDfVq8mIE3XSiAy0XCktsNQOd1dNc8KMqlU=; b=EsE0ehaY99Wa2HBiOxGbmpmuvUVzsIxccmHFDUq89RpiPNJr40GTfpS7oR7puLnr/i dNLtvHiG/NQJNVA4nTlDsfBaMPlD4XfuO066iKnaQ3AsKoMsuDDsT0g4W3/qtN5/v+MB wEq6LLpz9I9skaYHxhDv1DN0d2KNmfHS7LNn+Na3ChIy1xeCuRohZXTLdmkRIlM3AenO OGyWSc4IjYngcWg2eZs4bW1Ne7vHQ8fBDkCAeplOcwAfydRuOYt3aqQ75YJv4QjYy7vx EjBiPQkpQsmOjfJi1UOwGniwyi03D++8E3I0+o8PkSnxY+v4nFtkGpa7mK+ue5HVB7E7 LZnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=qOACvBLy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id d19-20020a656b93000000b003f5ccb17340si30186087pgw.571.2022.06.08.01.39.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 01:39:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=qOACvBLy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F3F7B2010CF; Wed, 8 Jun 2022 01:03:05 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237618AbiFHHTJ (ORCPT + 99 others); Wed, 8 Jun 2022 03:19:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237190AbiFHHGR (ORCPT ); Wed, 8 Jun 2022 03:06:17 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B99463B3DB for ; Tue, 7 Jun 2022 23:50:08 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id kq6so26456649ejb.11 for ; Tue, 07 Jun 2022 23:50:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Q3uqwWR5TDfVq8mIE3XSiAy0XCktsNQOd1dNc8KMqlU=; b=qOACvBLytlSPu/voOY0sdKTL1YDDNSi0+JU81j2PcNE3DkvGLmP21vYDv2yz/58PUN gwG/QDqTwvIweE6bVAfiYbOTUgBBbB+ja+7nkZNN6hvU8qPkPRKqcM4yOe3h9QdCCMXt ufaXncTIRX3ZGLRuttTfRdEyraOLT5UI7HQp8cu6ohOJQkJ/PQkj8HgkfSHLiL7O2lq9 1GNPngVI2GsSpiZR4ZSfsex65ECMVbsnuooxxyuRNd0sgagcW8OdWVrySgsLQCnag29S FNO92oUW1QvSS05d1rzZzPOSlOc6ykOw2MUXiaDuFZT/BJLCC8T0mNecvP87fNw4UFUN 2FZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Q3uqwWR5TDfVq8mIE3XSiAy0XCktsNQOd1dNc8KMqlU=; b=7wTq/ze8y2se++E6XKlUyFfhD4SFi7U+JnW3YrakAfTMQFyI9RjqpkYHv2MHHvreF2 jn3/1WnBcALVVrZkkMQeRXvhh31/RMRwR92/vXWp+sBs2bUoq0hUmDiSAOfXbVT532t1 E0X+NgaHqWiUTKIapNlMo/HsA5HYXy9dUQr6tR09VRan7/AKWNNlRGvWvzl1shlokfBq gBTa/G7GR6nT12MVKWvLtVmaHV57H2nT75yUBHeQx2rQuToSZgQeS7EXAZl1AdSULx58 7FhkE7clgwn253kZXjvWj0xOWTpaSFEJCGdJSrtlPqMLz1z3z/4TJfsIXUBXLOfoAVKM 05GA== X-Gm-Message-State: AOAM531XdgSxL/RqYdL30XUzLtWeDHQ45g4gI69mgQhhmhZyIaM2KbAQ 8hFaksa6rUyDKckiagP+E6PECHfdBLs= X-Received: by 2002:a17:907:60cc:b0:6f4:ffba:489 with SMTP id hv12-20020a17090760cc00b006f4ffba0489mr30434407ejc.666.1654671007136; Tue, 07 Jun 2022 23:50:07 -0700 (PDT) Received: from [192.168.0.253] (ip5f5abb79.dynamic.kabel-deutschland.de. [95.90.187.121]) by smtp.gmail.com with ESMTPSA id vj3-20020a170907130300b00705f6dab05bsm1691081ejb.183.2022.06.07.23.50.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jun 2022 23:50:06 -0700 (PDT) Message-ID: Date: Wed, 8 Jun 2022 08:50:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: [BUG] staging: r8188eu: driver stopped working with commit ("staging: r8188eu: add check for kzalloc") Content-Language: en-US To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube References: <20220606064055.12565-1-straube.linux@gmail.com> From: Michael Straube In-Reply-To: <20220606064055.12565-1-straube.linux@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, The driver does not work anymore on my system. In dmesg there is: "r8188eu 1-4:1.0: _rtw_init_xmit_priv failed" I bisected it to commit f94b47c6bde ("staging: r8188eu: add check for kzalloc"). ~/kernels/staging> git bisect bad f94b47c6bde624d6c07f43054087607c52054a95 is the first bad commit At the moment I have no time to look further into it. regards, Michael dmesg after plugging in the device: [15075.514705] usb 1-4: new high-speed USB device number 4 using xhci_hcd [15075.750717] usb 1-4: New USB device found, idVendor=0bda, idProduct=8179, bcdDevice= 0.00 [15075.750729] usb 1-4: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [15075.750734] usb 1-4: Product: 802.11n NIC [15075.750738] usb 1-4: Manufacturer: Realtek [15075.750742] usb 1-4: SerialNumber: 200DB02CEF8F [15075.767685] Chip Version Info: CHIP_8188E_Normal_Chip_TSMC_D_CUT_1T1R_RomVer(0) [15076.121994] EEPROM ID = 0x8129 [15076.123218] r8188eu 1-4:1.0: _rtw_init_xmit_priv failed [15076.321389] usb 1-4: reset high-speed USB device number 4 using xhci_hcd