Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <ab9bf4c2-48ed-1a14-9788-8a1672e29849@suse.cz>
Date:   Wed, 8 Jun 2022 08:55:52 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH 03/36] tty/vt: consolemap: define UNI_* macros for
 constants
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-serial <linux-serial@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
References: <20220607104946.18710-1-jslaby@suse.cz>
 <20220607104946.18710-3-jslaby@suse.cz>
 <59e0ae93-c7b-2087-75f8-4da0de918250@linux.intel.com>
From:   Jiri Slaby <jslaby@suse.cz>
In-Reply-To: <59e0ae93-c7b-2087-75f8-4da0de918250@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 07. 06. 22, 15:21, Ilpo Järvinen wrote:
> On Tue, 7 Jun 2022, Jiri Slaby wrote:
> 
>> The code uses constants for sizes of dictionary substructures on many
>> places. Define 3 macros and use them in the code, so that loop bounds,
>> local variables and the dictionary always match. (And the loop bounds
>> are obvious now too.)
>>
>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> 
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> 
>> -			for (k = 0; k < 64; k++) {
>> +			for (k = 0; k < UNI_ROW_GLYPHS; k++) {
>>   				glyph = p2[k];
>>   				if (glyph >= 0 && glyph < MAX_GLYPH
>>   					       && q[glyph] < 32)
> 
> Probably unrelated to this change but what's that < 32? It seems to appear
> twice related to the inverse mapping (and you didn't end up naming it).

That's ascii C0 test _IMO_.

thanks,
-- 
js
suse labs