Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2295145iof; Wed, 8 Jun 2022 01:42:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbdmQQhLaUceuNQysTrTuR02Kyf5M68yyK6zl90tNLLOcS4H2unZjXsfuwvCes0zPlIxQX X-Received: by 2002:a17:902:a503:b0:167:93c0:c602 with SMTP id s3-20020a170902a50300b0016793c0c602mr7308281plq.39.1654677774060; Wed, 08 Jun 2022 01:42:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654677774; cv=none; d=google.com; s=arc-20160816; b=xU0s7Ek3wWOyOqpGREsEQ7X949w38/N+ViDtyPOTrpVZ0H10sRr8bPEZnSXIoGpLHg mgzPFhtpYG2Senr/1Pb1USzwUebOkTNKiY18SsUriAqqUzFTIA4kxBqvFVdeQ9XGvKyo niB2vf6/ala/cZcd2+uX5Yy+dWCyKxCK68g5ir7hCba3JWMFvg8LHzhtzrrAiFV1R7Gv dGm0FxTwWYRO8eGvMgiTb4tY/QVx85IqQKH5z3yW0SVrQji4dqwaDYHMyCbyrk/CQSCn qwmLWaZO4Q4ix9mWdxWtgQICsRY9hfGRnbRB7ZBz//gqNiuEBRTPDS4X/WuHU/vEv24k iIsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=hZPSPJ55DdokJ2q2gq6MMUD3rN5KiPmQDBjab6tDYNs=; b=opT9h4S7B9T2d+MXNS4BWcL1XcNWMlwIA1C/NXOk+/tm5r4I83I9pcTRrueiyUI/i3 FfEIvoAokYv8+ChyIknk6ZbCsM9pL2Ym9o/2S5YmD2yCyCf1gmWF/gmMoMRW3ODIAq5X UFhQ0W5x1hYFoXYJNQ3YoBcX2QMzA466f8Ss3zgZS+Kz51S39NvnlypTId1h/icMfLe4 d65NLGY7W4mWvF3NS59n/j+1vCGah5ueOhjjIjGszN/TNCfh7dNMNiPiqtnmHhAOxEcd qqMB4lOQWWSz2ZrF1GAZNPcpkYYdyoAzLIVsmO9F/zwKhI4KVTt74ZRLx4m8/dvHIJrB l+sA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id k186-20020a6384c3000000b003fce072f541si22564363pgd.333.2022.06.08.01.42.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 01:42:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8BDA7177058; Wed, 8 Jun 2022 01:07:45 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232387AbiFHHwV (ORCPT + 99 others); Wed, 8 Jun 2022 03:52:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229908AbiFHHvT (ORCPT ); Wed, 8 Jun 2022 03:51:19 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AB9E10D5F1 for ; Wed, 8 Jun 2022 00:18:43 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nypxZ-0005n6-W8; Wed, 08 Jun 2022 09:18:34 +0200 Message-ID: <8ed717046a4c3c37d8415a924538f38353825027.camel@pengutronix.de> Subject: Re: [PATCH v9 4/8] PCI: imx6: Disable iMX6QDL PCIe REF clock when disable PCIe clocks From: Lucas Stach To: Richard Zhu , bhelgaas@google.com, robh+dt@kernel.org, broonie@kernel.org, lorenzo.pieralisi@arm.com, jingoohan1@gmail.com, festevam@gmail.com, francesco.dolcini@toradex.com Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Date: Wed, 08 Jun 2022 09:18:32 +0200 In-Reply-To: <1651801629-30223-5-git-send-email-hongxing.zhu@nxp.com> References: <1651801629-30223-1-git-send-email-hongxing.zhu@nxp.com> <1651801629-30223-5-git-send-email-hongxing.zhu@nxp.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, dem 06.05.2022 um 09:47 +0800 schrieb Richard Zhu: > When disable PCIe clocks, disable i.MX6QDL PCIe REF clock too. > > Signed-off-by: Richard Zhu Reviewed-by: Lucas Stach > --- > drivers/pci/controller/dwc/pci-imx6.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 9b0eac64badc..7005a7910003 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -536,6 +536,14 @@ static void imx6_pcie_clk_disable(struct imx6_pcie *imx6_pcie) > clk_disable_unprepare(imx6_pcie->pcie_bus); > > switch (imx6_pcie->drvdata->variant) { > + case IMX6Q: > + case IMX6QP: > + regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR1, > + IMX6Q_GPR1_PCIE_REF_CLK_EN, 0); > + regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR1, > + IMX6Q_GPR1_PCIE_TEST_PD, > + IMX6Q_GPR1_PCIE_TEST_PD); > + break; > case IMX6SX: > clk_disable_unprepare(imx6_pcie->pcie_inbound_axi); > break;