Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <4ebf3fb3-47c8-b4b4-e9b2-630e3f540316@roeck-us.net>
Date:   Tue, 7 Jun 2022 18:41:29 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH 1/1] MIPS: Loongson-3: fix compile mips cpu_hwmon as
 module build error.
Content-Language: en-US
To:     Yupeng Li <liyupeng@zbhlos.com>, chenhuacai@kernel.org,
        jiaxun.yang@flygoat.com, tsbogend@alpha.franken.de,
        jdelvare@suse.com
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hwmon@vger.kernel.org, caizp2008@163.com
References: <20220608011229.2056016-1-liyupeng@zbhlos.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <20220608011229.2056016-1-liyupeng@zbhlos.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 6/7/22 18:12, Yupeng Li wrote:
>    set cpu_hwmon as a module build with loongson_sysconf, loongson_chiptemp
>    undefined error,fix cpu_hwmon compile options to be bool.Some kernel
>    compilation error information is as follows:
> 
>    Checking missing-syscalls for N32
>    CALL    scripts/checksyscalls.sh
>    Checking missing-syscalls for O32
>    CALL    scripts/checksyscalls.sh
>    CALL    scripts/checksyscalls.sh
>    CHK     include/generated/compile.h
>    CC [M]  drivers/platform/mips/cpu_hwmon.o
>    Building modules, stage 2.
>    MODPOST 200 modules
> ERROR: "loongson_sysconf" [drivers/platform/mips/cpu_hwmon.ko] undefined!
> ERROR: "loongson_chiptemp" [drivers/platform/mips/cpu_hwmon.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:92：__modpost] 错误 1
> make: *** [Makefile:1261：modules] 错误 2
> 
> Signed-off-by: Yupeng Li <liyupeng@zbhlos.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/platform/mips/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/mips/Kconfig b/drivers/platform/mips/Kconfig
> index d421e1482395..6b51ad01f791 100644
> --- a/drivers/platform/mips/Kconfig
> +++ b/drivers/platform/mips/Kconfig
> @@ -17,7 +17,7 @@ menuconfig MIPS_PLATFORM_DEVICES
>   if MIPS_PLATFORM_DEVICES
>   
>   config CPU_HWMON
> -	tristate "Loongson-3 CPU HWMon Driver"
> +	bool "Loongson-3 CPU HWMon Driver"
>   	depends on MACH_LOONGSON64
>   	select HWMON
>   	default y