Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "Zhang, Qiang1" <qiang1.zhang@intel.com>
To:     "paulmck@kernel.org" <paulmck@kernel.org>
CC:     "frederic@kernel.org" <frederic@kernel.org>,
        "rcu@vger.kernel.org" <rcu@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] rcu/nocb: Avoid polling when myrdp->nocb_head_rdp list
 is empty
Thread-Topic: [PATCH v2] rcu/nocb: Avoid polling when myrdp->nocb_head_rdp
 list is empty
Thread-Index: AQHYekOLcM/pjDOLHUOfGqJWFKxX8a1EH1EAgACISxCAAAiugIAAAQyw
Date:   Wed, 8 Jun 2022 01:01:31 +0000
Message-ID: <PH0PR11MB588014C2451C2E65E583924DDAA49@PH0PR11MB5880.namprd11.prod.outlook.com>
References: <20220607075057.909070-1-qiang1.zhang@intel.com>
 <20220607161620.GH1790663@paulmck-ThinkPad-P17-Gen-1>
 <PH0PR11MB5880551F642B1490CEFA65A8DAA49@PH0PR11MB5880.namprd11.prod.outlook.com>
 <20220608005513.GK1790663@paulmck-ThinkPad-P17-Gen-1>
In-Reply-To: <20220608005513.GK1790663@paulmck-ThinkPad-P17-Gen-1>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.6.500.17
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kxAuH8vCd0r6Zv/Yy0SBa0+wAWGbE7my6+C1eX1868X+bw9SJSRmU6F4b3bM?=
 =?us-ascii?Q?+l9vJMUs4xOTTPh/w0l+6fL2GV7j928/qC1e0UaigNkjKfrpwEwoH6d1k10+?=
 =?us-ascii?Q?7AZ0S42VuHDxAfoReBEx6dBFzb/wnrfE8onAUFwImyfhz5V+LeqB7nlurq6s?=
 =?us-ascii?Q?ewasAt+fJNfgcpvr15msbMDczeeCLetx4s2vhx+tm4Zz8lm1thiZcSDrIX4q?=
 =?us-ascii?Q?XpC9KSTtnWO/AewImrlqgvwICqDhleKzYgq2AnBh99K2oMNiT3Ljmo9NXUEQ?=
 =?us-ascii?Q?KlOox1vbkLye+U9B3B+LbNcA4WcKzaiVYJeMYLQa1ugTwB0QK9ZLKa6dI5RF?=
 =?us-ascii?Q?LUngQy+JPClnWqPWX9azxbYhAF5aav+10jBvhrSKP7ErU5g3/3MIiwFThSjL?=
 =?us-ascii?Q?YzkIRBWvZBuVXa75I8PfH3r4pBrpbRysmSPOT7ceFlO3BF0OvPovzq0f3Q3X?=
 =?us-ascii?Q?63UugNzBGIfbeLBjXD0frx6Jgg7pzZA5+q2JUUS51Da6IYNfLC94RVKtZIjo?=
 =?us-ascii?Q?+8UYnor8ofm1/VKmhQ4J7BYGD/+VYfYg98GN6FnGQXikX0+10+Q6x7ypzgRz?=
 =?us-ascii?Q?CJzv80RKtiaa/iRyFZOylg3GNHnD/LK9v97cr933RrmFKq6lPqaFzBxMZ1aQ?=
 =?us-ascii?Q?afovbMkE4I8DvV6pFEy9R9NlSjKTEa2MmvE7qEmoolRFqzTISxA/YDcDPqTj?=
 =?us-ascii?Q?4Zuuod7LNInFhP27D8DyvIZ3MX5tSfR/IlIFQScCagt6967O6W41T3Q6dTHS?=
 =?us-ascii?Q?YyJtT4AihmeTLjR+Ue8KvvooEiNvmPWo6j3BopmuOeI9ki2qLXSv319nfLLb?=
 =?us-ascii?Q?KDdpo5nD8CM2ZLeNmCByPaJJRNiQqpurmc7Gc2Uf65izMxx8aLYjotVLniOt?=
 =?us-ascii?Q?rh6WdlyYvqIFhnn4xWY5sMjiHEw4yh7WFPshE7B2q9biCw86lB2JNUFIz4pW?=
 =?us-ascii?Q?GfZSaURRU60F5Xbu8ponUwmTSgHRFclY0A3nCIQjylZBXMCmDVVwmBYYrSp2?=
 =?us-ascii?Q?F9SOBNc3YsK2l4XlXq59yT1c9TjC3hs4y5FX1tkuJXzBs5ZehfNHz8IpyjPY?=
 =?us-ascii?Q?k61kKCVY+WeMfxD/1uEraMk3Gag9a2fWIC63P3bp1kYdmarMFB+8WFsh83Tv?=
 =?us-ascii?Q?g39RNV9iNyre3Eo7PW7w3B8dSMV1uu5kTO98xgPp4mlTm9ns3phfRGlA755O?=
 =?us-ascii?Q?3giCn7ddOp/6KiBjzMupUKtilyjXSG9evy6vs93ZPXIXBypezREjOTkOLKIK?=
 =?us-ascii?Q?/r4VTJpSVksPftOz3Yy7hnYrIV/7PpXbQ4N1cd3ZHQo5ylUvsA/PMRAe1nr3?=
 =?us-ascii?Q?GQPfkomBW+lbMrbuWH36mI332p/TjJ/cOnYM4Seybuc9WfotuKIquXfqmKIl?=
 =?us-ascii?Q?ZJ9owQo6KCmdJ0Q6tm/eVKc1VOUL/EMkOA5QrJj/5ex/s8kLtJjwQDaRqSDd?=
 =?us-ascii?Q?eFiRG5icoAup8guldHzCaDv54TSXZMuAdd+AkQqTK7MzyYecB7bL2qE1NPBw?=
 =?us-ascii?Q?jL6VdcMf5/o/WaeP9wOtplLkVkKgAdHzmrnpz/+our76ni3qMwyykfOK/vUU?=
 =?us-ascii?Q?ENc/jhRiE4NcVdKn2i3uCz8vMuS+7PnHiZNJKrftSJCTgvwKHI0czUPIlgD/?=
 =?us-ascii?Q?Qg3HGaaKDEo1WTwN5xy5xzZEbVN3PBc0sQhQZDW/0m9ItUgSURkauSVvYjSN?=
 =?us-ascii?Q?cgcMyafSxe/DjelHmyAEHPIyuRkkJOjoANC2QISUWwQCoZlg3ZUYmycnkHx9?=
 =?us-ascii?Q?wmnvxxyt8g=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5880.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f68b033-72ce-4c39-7828-08da48ea6cd6
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2022 01:01:31.1263
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FVQcqzLVynJCF1AU6Rudb/uWS3ZXTEzSNtGKbR5oMP9uELqwu/cWXUMl5yE/j5+JgzhnlHKCd3B3Khf1o8qjfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0077
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 08, 2022 at 12:41:28AM +0000, Zhang, Qiang1 wrote:
> On Tue, Jun 07, 2022 at 03:50:57PM +0800, Zqiang wrote:
> > Currently, If the 'rcu_nocb_poll' bootargs is enable, all rcuog=20
> > kthreads enter polling mode. however, due to only insert CPU's rdp=20
> > which belong to rcu_nocb_mask to 'nocb_head_rdp' list or all CPU's=20
> > rdp served by rcuog kthread have been de-offloaded, these cause the=20
> > 'nocb_head_rdp' list served by rcuog kthread is empty, when the=20
> > 'nocb_head_rdp' is empty, the rcuog kthread in polling mode not=20
> > actually do anything. fix it by exiting polling mode when the=20
> > 'nocb_head_rdp'list is empty, otherwise entering polling mode.
> >=20
> > Signed-off-by: Zqiang <qiang1.zhang@intel.com>
> >
> >This looks a bit more plausible, but what have you done to test this?
>=20
> Yes , I have only tested as follows and I added two trace events.
>=20
> +                      trace_rcu_nocb_wake(rcu_state.name, cpu,=20
> + TPS("EnterNoPoll"));
>                        =20
> rcu_wait(READ_ONCE(my_rdp->nocb_toggling_rdp));
> +                       trace_rcu_nocb_wake(rcu_state.name, cpu,=20
> + TPS("ExitNoPoll"));
>=20
> runqemu kvm slirp nographic qemuparams=3D"-m 2048 -smp 4"=20
> bootparams=3D"rcu_nocbs=3D2,3 rcutree.dump_tree=3D1 rcu_nocb_poll=20
> rcutorture.nocbs_nthreads=3D4 rcutorture.test_boost=3D0" -d

>To exercise your change, could you please also add an appropriate value fo=
r the rcutorture.nocbs_nthreads kernel boot parameter?  Without that boot p=
arameter, your kernel will not actually offload or deoffload any CPUs.

I have set ' rcutorture.nocbs_nthreads=3D4 ' in bootargs.

>
>An alternative approach is to run rcutorture scenario TREE01.

I will also use TREE01 for testing

Thanks
Zqiang

>
>							Thanx, Paul

> Thanks
> Zqiang
>=20
> >
> >							Thanx, Paul
> >
> > ---
> >  v1->v2:
> >  Move rcu_nocb_poll flags check from rdp_offload_toggle() to=20
> > rcu_nocb_rdp_offload/deoffload(), avoid unnecessary setting of=20
> > rdp_gp->nocb_gp_sleep flags, because when rcu_nocb_poll is set  the=20
> > rdp_gp->nocb_gp_sleep is not used.
> >=20
> >  kernel/rcu/tree_nocb.h | 16 ++++++++++------
> >  1 file changed, 10 insertions(+), 6 deletions(-)
> >=20
> > diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h index
> > fa8e4f82e60c..2a52c9abc681 100644
> > --- a/kernel/rcu/tree_nocb.h
> > +++ b/kernel/rcu/tree_nocb.h
> > @@ -698,10 +698,14 @@ static void nocb_gp_wait(struct rcu_data *my_rdp)
> >  				   TPS("WakeBypassIsDeferred"));
> >  	}
> >  	if (rcu_nocb_poll) {
> > -		/* Polling, so trace if first poll in the series. */
> > -		if (gotcbs)
> > -			trace_rcu_nocb_wake(rcu_state.name, cpu, TPS("Poll"));
> > -		schedule_timeout_idle(1);
> > +		if (list_empty(&my_rdp->nocb_head_rdp)) {
> > +			rcu_wait(READ_ONCE(my_rdp->nocb_toggling_rdp));
> > +		} else {
> > +			/* Polling, so trace if first poll in the series. */
> > +			if (gotcbs)
> > +				trace_rcu_nocb_wake(rcu_state.name, cpu, TPS("Poll"));
> > +			schedule_timeout_idle(1);
> > +		}
> >  	} else if (!needwait_gp) {
> >  		/* Wait for callbacks to appear. */
> >  		trace_rcu_nocb_wake(rcu_state.name, cpu, TPS("Sleep")); @@=20
> > -1030,7
> > +1034,7 @@ static long rcu_nocb_rdp_deoffload(void *arg)
> > =20
> >  	mutex_lock(&rdp_gp->nocb_gp_kthread_mutex);
> >  	if (rdp_gp->nocb_gp_kthread) {
> > -		if (wake_gp)
> > +		if (wake_gp || rcu_nocb_poll)
> >  			wake_up_process(rdp_gp->nocb_gp_kthread);
> > =20
> >  		/*
> > @@ -1152,7 +1156,7 @@ static long rcu_nocb_rdp_offload(void *arg)
> >  	 *      rcu_nocb_unlock()         rcu_nocb_unlock()
> >  	 */
> >  	wake_gp =3D rdp_offload_toggle(rdp, true, flags);
> > -	if (wake_gp)
> > +	if (wake_gp || rcu_nocb_poll)
> >  		wake_up_process(rdp_gp->nocb_gp_kthread);
> >  	swait_event_exclusive(rdp->nocb_state_wq,
> >  			      rcu_segcblist_test_flags(cblist, SEGCBLIST_KTHREAD_CB) &&
> > --
> > 2.25.1
> >=20