Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 08 Jun 2022 09:56:34 +0200
Message-ID: <87leu7bnbh.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Jeremy Szu <jeremy.szu@canonical.com>
Cc:     huangwenhui <huangwenhuia@uniontech.com>, tiwai@suse.com,
        perex@perex.cz, alsa-devel@alsa-project.org, kailang@realtek.com,
        tanureal@opensource.cirrus.com, linux-kernel@vger.kernel.org,
        wse@tuxedocomputers.com, hui.wang@canonical.com, sami@loone.fi,
        cam@neo-zeon.de
Subject: Re: [PATCH v3] ALSA: hda/realtek - Add HW8326 support
In-Reply-To: <CAKzWQkySkKccnmSx_2fKT9QvPfwBOV36Mc-pt3KQR0NO1QkQ2w@mail.gmail.com>
References: <20220608070527.14824-1-huangwenhuia@uniontech.com>
        <87wndrboja.wl-tiwai@suse.de>
        <CAKzWQkySkKccnmSx_2fKT9QvPfwBOV36Mc-pt3KQR0NO1QkQ2w@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 08 Jun 2022 09:53:32 +0200,
Jeremy Szu wrote:
> 
> and better to follow the order to easy to find the codec once the list
> growing next time, e.g.
> 
> @@ -651,6 +651,7 @@ static const struct hda_vendor_id hda_vendor_ids[] = {
>         { 0x1095, "Silicon Image" },
>         { 0x10de, "Nvidia" },
>         { 0x10ec, "Realtek" },
> +       { 0x19e5, "Huawei" },
>         { 0x1102, "Creative" },
>         { 0x1106, "VIA" },
>         { 0x111d, "IDT" },
> 
> to
> 
>        { 0x14f1, "Conexant" },
>         { 0x17e8, "Chrontel" },
>         { 0x1854, "LG" },
> +       { 0x19e5, "Huawei" },
>         { 0x1aec, "Wolfson Microelectronics" },
>         { 0x1af4, "QEMU" },
> 
> and so on.

Indeed.  Care to send an additional patch?


thanks,

Takashi