Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220602005542.16489-1-chengkaitao@didiglobal.com>
In-Reply-To: <20220602005542.16489-1-chengkaitao@didiglobal.com>
From:   Jason Wang <jasowang@redhat.com>
Date:   Wed, 8 Jun 2022 16:11:31 +0800
Message-ID: <CACGkMEvrRmLZ6aqo8J8wxpuqWSbsa=oEOGS+g80bLQzDKv=bww@mail.gmail.com>
Subject: Re: [PATCH] virtio-mmio: fix missing put_device() when
 vm_cmdline_parent registration failed
To:     chengkaitao <pilgrimtao@gmail.com>
Cc:     mst <mst@redhat.com>,
        virtualization <virtualization@lists.linux-foundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>, smcdef@gmail.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jun 2, 2022 at 9:12 AM chengkaitao <pilgrimtao@gmail.com> wrote:
>
> From: chengkaitao <pilgrimtao@gmail.com>
>
> The reference must be released when device_register(&vm_cmdline_parent)
> failed. Add the corresponding 'put_device()' in the error handling path.
>
> Signed-off-by: chengkaitao <pilgrimtao@gmail.com>

Acked-by: Jason Wang <jasowang@redhat.com>

> ---
>  drivers/virtio/virtio_mmio.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
> index 56128b9c46eb..1dd396d4bebb 100644
> --- a/drivers/virtio/virtio_mmio.c
> +++ b/drivers/virtio/virtio_mmio.c
> @@ -688,6 +688,7 @@ static int vm_cmdline_set(const char *device,
>         if (!vm_cmdline_parent_registered) {
>                 err = device_register(&vm_cmdline_parent);
>                 if (err) {
> +                       put_device(&vm_cmdline_parent);
>                         pr_err("Failed to register parent device!\n");
>                         return err;
>                 }
> --
> 2.14.1
>