Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2364523iof; Wed, 8 Jun 2022 03:28:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzh8x+jHOuBN5mT7sJrLK20JP4ErOSo3lLAfggmwaogi4PqYx5gt21KSpqqfEz62IOE7LW3 X-Received: by 2002:a62:db81:0:b0:51b:ed38:c409 with SMTP id f123-20020a62db81000000b0051bed38c409mr24479916pfg.37.1654684091868; Wed, 08 Jun 2022 03:28:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654684091; cv=none; d=google.com; s=arc-20160816; b=VD0aDa282wuXjamKudA9dGAamL96Cf/HK408So5Q/G8Pladg7hl00DrBJDyOQWEw73 oxZWJsWBKvCJYdOXVECjFQ7mhIv2+8dqCmQEhSLsqagqZZ6kmbcNzf0svJbNiEUfVceY ruYmmMHNYRbGm47CIQgVnyGNEvQi5jXs5kBvIZvjL1uKNmfoQtp/PYcufSC6vjIvYHZk rgiplFfxyOGjVoolV1wmoCQ2wMTtrN7hQ4m55s8ZvPtT2KKzMLeBapBSlz6rxbdYDiX0 VRnadNTM2SJ06BUPjvapHAhbI2Rmoypgu6MKpDBDt/fKY0jmvFS2wsEjLpXYMFduxm0R JYdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Q/rOL0sFJOwEN114tdq3Zjt00lv0ZNAXlAw4gCwdypk=; b=ld/WOR70hXc0bcSTuUSkaV6dh/YacOV5UBgy3iWzkjF9r/xwT1dk81FPw5WAtpMrOv mbG0DVSe/MljNT980jjZpWRU6vaTk3Id3Udg+QjpefroRkTjxzsSQAcMUDVDpiCOsk1b zr93kD45ZhmgTZZ3gu0oXv9LMpmY8rhOYIVpVwrPQbF4PfJje4sR74yGxxa8KRtO3pqV mlzpk7PX0WGChe0upIeyWAjvV2ei5B3UH3fNLTWm1/CH0R4ja6hFn38JbjJ4HIhNcNcL bfVZ9w2gSwjFUcLh3FEMJZeqFtucbvh3tjwtv+pP7UV/P5yD4dDOFIDM6crEOcRueKX8 iuCQ== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id c21-20020a63d515000000b003f5e0c264c1si29472210pgg.611.2022.06.08.03.28.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 03:28:11 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 675391F98DB; Wed, 8 Jun 2022 02:55:48 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235566AbiFHJzk (ORCPT + 99 others); Wed, 8 Jun 2022 05:55:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235431AbiFHJzA (ORCPT ); Wed, 8 Jun 2022 05:55:00 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66E6E152DB4 for ; Wed, 8 Jun 2022 02:27:38 -0700 (PDT) Received: from martin by viti.kaiser.cx with local (Exim 4.89) (envelope-from ) id 1nyryN-00080S-Cs; Wed, 08 Jun 2022 11:27:31 +0200 Date: Wed, 8 Jun 2022 11:27:31 +0200 From: Martin Kaiser To: Michael Straube , phil@philpotter.co.uk Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [BUG] staging: r8188eu: driver stopped working with commit ("staging: r8188eu: add check for kzalloc") Message-ID: <20220608092731.hz26q37fhmrhipmj@viti.kaiser.cx> References: <20220606064055.12565-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: Martin Kaiser X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michael & Phil, Thus wrote Michael Straube (straube.linux@gmail.com): > The driver does not work anymore on my system. In dmesg there is: > "r8188eu 1-4:1.0: _rtw_init_xmit_priv failed" > I bisected it to commit f94b47c6bde ("staging: r8188eu: add check for > kzalloc"). > ~/kernels/staging> git bisect bad > f94b47c6bde624d6c07f43054087607c52054a95 is the first bad commit > At the moment I have no time to look further into it. See also https://lore.kernel.org/linux-staging/YoyU4zXf45UpF1Tq@kroah.com/T/#mb5e56a285b8eb1ebb0e798462fc388cb02b4a7cc Phil said in https://lore.kernel.org/linux-staging/YoyU4zXf45UpF1Tq@kroah.com/T/#m7a21d460b2569f6b59965ecc3298a6337fa3458a that he has submitted a patch to fix this issue for now until we get around to changing the _SUCCESS and _FAIL values. Phil, did you really send this out? I don't see it. If you don't have anything ready, I can try a simple fix. Thanks & best regards, Martin