Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <01d6737a-9e2d-c009-4e24-c2c54b39b80c@gmail.com>
Date:   Wed, 8 Jun 2022 12:34:45 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [BUG] staging: r8188eu: driver stopped working with commit
 ("staging: r8188eu: add check for kzalloc")
Content-Language: en-US
To:     Martin Kaiser <lists@kaiser.cx>,
        Michael Straube <straube.linux@gmail.com>,
        phil@philpotter.co.uk
Cc:     gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20220606064055.12565-1-straube.linux@gmail.com>
 <ded4b3f5-a9bc-4612-33cc-68bd85cb92fe@gmail.com>
 <20220608092731.hz26q37fhmrhipmj@viti.kaiser.cx>
From:   Pavel Skripkin <paskripkin@gmail.com>
In-Reply-To: <20220608092731.hz26q37fhmrhipmj@viti.kaiser.cx>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Martin,

On 6/8/22 12:27, Martin Kaiser wrote:
> Hi Michael & Phil,
> 
> Thus wrote Michael Straube (straube.linux@gmail.com):
> 
>> The driver does not work anymore on my system. In dmesg there is:
> 
>> "r8188eu 1-4:1.0: _rtw_init_xmit_priv failed"
> 
>> I bisected it to commit f94b47c6bde ("staging: r8188eu: add check for
>> kzalloc").
> 
>> ~/kernels/staging> git bisect bad
>> f94b47c6bde624d6c07f43054087607c52054a95 is the first bad commit
> 
>> At the moment I have no time to look further into it.
> 
> See also
> 
> https://lore.kernel.org/linux-staging/YoyU4zXf45UpF1Tq@kroah.com/T/#mb5e56a285b8eb1ebb0e798462fc388cb02b4a7cc
> 
> Phil said in
> 
> https://lore.kernel.org/linux-staging/YoyU4zXf45UpF1Tq@kroah.com/T/#m7a21d460b2569f6b59965ecc3298a6337fa3458a
> 

There is the posted patch [1]. I also have to apply it every time I want 
to test smth.

[1] https://lore.kernel.org/all/20220521204741.921-1-phil@philpotter.co.uk/


With regards,
Pavel Skripkin