Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 8 Jun 2022 11:41:08 +0200
From:   Eugene Syromiatnikov <esyr@redhat.com>
To:     guoren@kernel.org, Christoph Hellwig <hch@lst.de>
Cc:     palmer@dabbelt.com, arnd@arndb.de, gregkh@linuxfoundation.org,
        hch@lst.de, nathan@kernel.org, naresh.kamboju@linaro.org,
        linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
        sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        linux-parisc@vger.kernel.org, linux-mips@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, x86@kernel.org,
        heiko@sntech.de, ldv@strace.io
Subject: Re: [PATCH V12 02/20] uapi: always define
 F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h
Message-ID: <20220608094108.GA18122@asgard.redhat.com>
References: <20220405071314.3225832-1-guoren@kernel.org>
 <20220405071314.3225832-3-guoren@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220405071314.3225832-3-guoren@kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk

On Tue, Apr 05, 2022 at 03:12:56PM +0800, guoren@kernel.org wrote:
> From: Christoph Hellwig <hch@lst.de>
> 
> Note that before this change they were never visible to userspace due
> to the fact that CONFIG_64BIT is only set for kernel builds.

> -#ifndef CONFIG_64BIT
> +#if __BITS_PER_LONG == 32 || defined(__KERNEL__)

Actually, it's quite the opposite: "ifndef" usage made it vailable at all times
to the userspace, and this change has actually broken building strace
with the latest kernel headers[1][2].  There could be some debate
whether having these F_*64 definitions exposed to the user space 64-bit
applications, but it seems that were no harm (as they were exposed already
for quite some time), and they are useful at least for strace for compat
application tracing purposes.

[1] https://github.com/strace/strace/runs/6779763146?check_suite_focus=true#step:4:3222
[2] https://pipelines.actions.githubusercontent.com/serviceHosts/e5309ebd-8a2f-43f4-a212-b52080275b5d/_apis/pipelines/1/runs/1473/signedlogcontent/12?urlExpires=2022-06-08T09%3A37%3A13.9248496Z&urlSigningMethod=HMACV1&urlSignature=fIT7vd0O4NNRwzwKWLXY4UVZBIIF3XiVI9skAsGvV0I%3D