Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <2cc99c51-0ae6-4c56-c964-ced618133ead@redhat.com>
Date:   Wed, 8 Jun 2022 11:45:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH] mm/memory-failure: don't allow to unpoison hw corrupted
 page
Content-Language: en-US
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBICjloIDlj6Mg55u05LmfKQ==?= 
        <naoya.horiguchi@nec.com>, zhenwei pi <pizhenwei@bytedance.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Tony Luck <tony.luck@intel.com>,
        Wu Fengguang <fengguang.wu@intel.com>
References: <20220604103229.3378591-1-pizhenwei@bytedance.com>
 <20220604115616.b7d5912ac5a37db608f67b78@linux-foundation.org>
 <584eedd3-9369-9df1-39e2-62e331abdcc0@bytedance.com>
 <20220606043202.GA1328953@hori.linux.bs1.fc.nec.co.jp>
 <3b58adbf-a8b2-8dba-71a7-123ba3850c10@bytedance.com>
 <20220606091503.GA1337789@hori.linux.bs1.fc.nec.co.jp>
 <5e7abb3f-56e7-0343-a678-749b6f5238a2@redhat.com>
 <20220607145959.785e54c752f373bcc283732b@linux-foundation.org>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20220607145959.785e54c752f373bcc283732b@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 07.06.22 23:59, Andrew Morton wrote:
> On Tue, 7 Jun 2022 14:36:00 +0200 David Hildenbrand <david@redhat.com> wrote:
> 
>> On 06.06.22 11:15, HORIGUCHI NAOYA(堀口 直也) wrote:
>>>>>    [  917.864266]  <TASK>
>>>>>    [  917.864961]  clear_huge_page+0x147/0x270
>>>>>    [  917.866236]  hugetlb_fault+0x440/0xad0
>>>>>    [  917.867366]  handle_mm_fault+0x270/0x290
>>>>>    [  917.868532]  do_user_addr_fault+0x1c3/0x680
>>>>>    [  917.869768]  exc_page_fault+0x6c/0x160
>>>>>    [  917.870912]  ? asm_exc_page_fault+0x8/0x30
>>>>>    [  917.872082]  asm_exc_page_fault+0x1e/0x30
>>>>>    [  917.873220] RIP: 0033:0x7f2aeb8ba367
>>>>>
>>>>> I don't think of a workaround for this now ...
>>>>>
>>>>
>>>> Could you please tell me how to reproduce this issue?
>>>
>>> You are familiar with qemu-monitor-command, so the following procedure
>>> should work for you:
>>>
>>>   - run a process using hugepages on your VM,
>>>   - check the guest physical address of the hugepage (page-types.c is helpful for this),
>>>   - inject a MCE with virsh qemu-monitor-command on the guest physical address, then
>>>   - unpoison the injected physical address.
>>
>> That's triggered via debugfs / HWPOISON_INJECT, right?
>>
>> That's a DEBUG_KERNEL option, so I'm not 100% sure if we really want to
>> cc stable.
> 
> Sure, it's hardly a must-have.  But let's also take the patch
> complexity&risk into account.  This is one dang simple patch.
> 
> Or is it.  Should these things be happening outside mf_mutex?  What the
> heck is the role of mf_mutex anyway?

For example, I'm not even sure if we're allowed to use virt_to_kpte()
out of random context at all.

If we have a PMD direct map, why should it be okay to use virt_to_kpte()?

Maybe I am just wrong, I asked that question on the next patch version
as well.

-- 
Thanks,

David / dhildenb