Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To:     Javier Martinez Canillas <javierm@redhat.com>
Cc:     Lennart Poettering <lennart@poettering.net>,
        linux-kernel@vger.kernel.org, Colin Walters <walters@verbum.org>,
        Peter Jones <pjones@redhat.com>,
        Alberto Ruiz <aruiz@redhat.com>,
        Christian Kellner <ckellner@redhat.com>,
        Chung-Chiang Cheng <cccheng@synology.com>,
        Muhammad Usama Anjum <usama.anjum@collabora.com>,
        Alexander Larsson <alexl@redhat.com>,
        Shuah Khan <shuah@kernel.org>, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v4 0/4] fat: add support for the renameat2
 RENAME_EXCHANGE flag
References: <20220601173204.1372569-1-javierm@redhat.com>
        <05bfb010-6b00-edb1-0e28-889a2ff71503@redhat.com>
Date:   Wed, 08 Jun 2022 18:42:33 +0900
In-Reply-To: <05bfb010-6b00-edb1-0e28-889a2ff71503@redhat.com> (Javier
        Martinez Canillas's message of "Wed, 8 Jun 2022 09:56:46 +0200")
Message-ID: <87ilpbtrsm.fsf@mail.parknet.co.jp>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Javier Martinez Canillas <javierm@redhat.com> writes:

> Hello OGAWA,
>
> On 6/1/22 19:32, Javier Martinez Canillas wrote:
>> Hello,
>> 
>> The series adds support for the renameat2 system call RENAME_EXCHANGE flag
>> (which allows to atomically replace two paths) to the vfat filesystem code.
>> 
>> There are many use cases for this, but we are particularly interested in
>> making possible for vfat filesystems to be part of OSTree [0] deployments.
>> 
>> Currently OSTree relies on symbolic links to make the deployment updates
>> an atomic transactional operation. But RENAME_EXCHANGE could be used [1]
>> to achieve a similar level of robustness when using a vfat filesystem.
>> 
>> Patch #1 is just a preparatory patch to introduce the RENAME_EXCHANGE
>> support, patch #2 moves some code blocks in vfat_rename() to a set of
>> helper functions, that can be reused by tvfat_rename_exchange() that's
>> added by patch #3 and finally patch #4 adds some kselftests to test it.
>> 
>
> I think that addressed all the issues you pointed out in v3, please let me
> know if there's anything else that is needed for this patch series.
>
> Would these be merged by you or should I ping someone else? I'm not
> that familiar with how filesystem patches make into the mainline tree.

Sorry, it is just the my issue. I was traveling latest week, so is not
reviewing yet. I'll do soon.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>