Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2375956iof; Wed, 8 Jun 2022 03:45:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoFlQnjpgRCavEl3GRaKan/mrGduQ28baD1+qfuBWsU95KdnBR0B4RCnb9AAIgaFLUci+m X-Received: by 2002:a63:1d62:0:b0:3fd:ebcd:13a4 with SMTP id d34-20020a631d62000000b003fdebcd13a4mr9501988pgm.151.1654685109967; Wed, 08 Jun 2022 03:45:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654685109; cv=none; d=google.com; s=arc-20160816; b=kieuqxiDfALJaJ4sRaTiEftcTl9UZLsr4gr3M3sH12ob4iCmc7AjkD+chS4DEyeFRw Mpg97dWYcSyAHnXA0Y1dr/tv1Y7WymZZueo6+8tuMJswqH6eiFIIjgb1QjPm9UOM1OZo 0qcOiM4zn0jb3UcUM9retqE0sV0z5doFT8FTS3Q9Q7gS+qF5nK1vbAGipWIku780HgD6 8DOY8LPrarme2N4B7QX2joTCC5c29iPZuJ4g8UzPeNWiSO6EwL79GBoLdduXct50LOdV +mdFTQbcDzFbm9zzU7tc/6FWdpXnCg8xoyUJjrFJmFhc4WtjUOc49f6Tvw5sNQ9qlQXO J4nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=rG489ZQKTd+AefI2h2Ke0OcaTRJwS97oK5DDu5viegA=; b=ZkKIVDcH7s9rO6IJk+o2U6cKLJpME4algOhP4R+kpk+vMUhDoS9eRU7Va8j6uJatnc 5CgCDlivgHPuixc7kPs6ZFe/pNovu9NNy2nBSfB/t/bmR/SXqu8nALLkdZ1TJx+cgw4d F8enBtzpjeQDA3p3LtniasXQ5Q1EEOkWhX7Y37U+UrDB3q1nV7712z6Yx0Z9RMPkQR+9 Z90AT42TkMo1uVYnps31f3bJPu0i7SjsXFHdplurJ6ouGXC07EXXXPWBOk9UHwpW2HYt PhVDJUmP+EIcrmBIVfGsCGxMdOh+4ALw8ri86joZHWnR1FNyt9SJBCZPX+p7PKxSTDlv /O8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fJfBz3cP; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id k18-20020aa79732000000b005191e154399si24168918pfg.258.2022.06.08.03.45.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 03:45:09 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fJfBz3cP; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 272621D8A78; Wed, 8 Jun 2022 03:11:39 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236307AbiFHKKX (ORCPT + 99 others); Wed, 8 Jun 2022 06:10:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237034AbiFHKJc (ORCPT ); Wed, 8 Jun 2022 06:09:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7D3BED3F8; Wed, 8 Jun 2022 02:54:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EA77E61A3F; Wed, 8 Jun 2022 09:54:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCF08C34116; Wed, 8 Jun 2022 09:54:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654682070; bh=AzEVbvMp6p8V46Xl/eSBFT/ox0PW2CfgYNjNb28qaPs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=fJfBz3cPlvZEPBAKmG9AvgHA1Nc+8TVn/ng9xVDjDNImDUlfFYP8mCKt9+gXDYbOl DsRdb22dFmP70IyYp0s/A40vwkSpxcxqeWArE2PWTenCOYQoDXBT7U3mCYg/Bo2HqA YZorATyovxsX3TqTsdrOPLuC9zOicfs2GCi54SOG3x1gKt9ptUW2wSVfMyy6Oe3j9J 5uTSz0Q+qUfxbpSsFCKISKoFRymbtsMNMsUmfQU4Ev9Su4EBDE592AvsyWlrWp2Iwu k0riOLEhrcX4tCOaYsSm917oXxyk+KE9NIHmQeA2RN7GyhKObRHNUN4LACu+GKtfVh zPBM282Dosq7Q== Date: Wed, 8 Jun 2022 11:54:26 +0200 (CEST) From: Jiri Kosina To: Hilton Chain cc: =?ISO-8859-15?Q?Jos=E9_Exp=F3sito?= , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Bryan Cain , Benjamin Tissoires Subject: Re: [PATCH v5] HID: apple: Properly handle function keys on non-Apple keyboard In-Reply-To: <20220602161219.152be32d@ultrarare.space> Message-ID: References: <20220529182036.10226-1-jose.exposito89@gmail.com> <20220530083752.1973a905@ultrarare.space> <20220530061812.GA10391@elementary> <20220531221102.7bd7da7d@ultrarare.space> <20220531223330.3d63e2fe@ultrarare.space> <20220531172053.GA10651@elementary> <7f67ac07b8bd37d5817cd151674cc6b0@ultrarare.space> <20220601072651.242ce08a@ultrarare.space> <20220601121737.1226ffea@ultrarare.space> <20220601174956.GA10418@elementary> <20220602161219.152be32d@ultrarare.space> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2 Jun 2022, Hilton Chain wrote: > This commit extends fa33382c7f74 ("HID: apple: Properly handle function > keys on Keychron keyboards") by adding an array of known non-Apple > keyboards' device names, and the function apple_is_non_apple_keyboard() > to identify and create exception for them. > > Signed-off-by: Hilton Chain > --- > > V4 -> V5: Add Varmilo keyboards' name "AONE" to the exception list > V3 -> V4: Remove unnecessary strlen() Applied to hid.git, thank you. -- Jiri Kosina SUSE Labs