Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2404524iof; Wed, 8 Jun 2022 04:23:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzViwgnEO8f6/YIr+NK8n4s+13gSPjlTVuDGsXUptwWv/qBHbOSedzvf6nr17mBi4KOp+Z1 X-Received: by 2002:a17:90b:1c08:b0:1e2:fcfe:be30 with SMTP id oc8-20020a17090b1c0800b001e2fcfebe30mr36718630pjb.240.1654687391122; Wed, 08 Jun 2022 04:23:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654687391; cv=none; d=google.com; s=arc-20160816; b=l5lhLz5kR9IdOVSa5BtK0ASL3+MjfZDnbOt/4H6iVh0l9Zk9PHig7p5hc1py8MaAD7 JPZct1DGg01qFoq60V+Do1TvPFABCVrrsluYXcJ6gNBKZADZvY7ngSLnIdhmqEOIet2c 4l989cbDSjU4f4ludr88JpeMw7bOm6x5fbbKmwdaEoAArURhoYnTg8DRlx7dvtEu3umC fggygI9JijGoxBFy/CSYESEP/3l64FGlYtwTygSFU+/cVXjeAR0EfHU5GRJbS0Pq9bp+ RXG5W30zykmf5Th8uGxSDmH/QRzBhau3zrlAUzI0DsxKA23BcLKVN/un6oqqa1Q5qsnJ FyyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=tV7J5u/EHuCID4xkZianoJaNBb1hiLfy2yUn41w96Ds=; b=1FmhP8nOeQMLUWxVE660dhsTtK2FX1tSBJkehUlbhuj7MDnAu2DYLIDI78OQzXtE+Q hXf8l7YNB8g0vU0CErcyp+NKtqTh4dJih6BcTx9uwJSzOpMaJflU8I6oXt48D3YRy0KU HCScTDkxdi7hL240u5V5n36RK5D0snRt+J2TcZGxILlJnWbjMBCeZip+rjVfsrmXo+cg Rm5L1b5HAAX+vOCGGRJvsC+jjtrqIpf+J0yQNGAOHCQ5UStHEGOm5Qrx6nXD/iNla0J1 nDaFr18OpsBh0XcUSUuA1pU6sEPW9h+g0tEPLKF7Sxm+bdfaDBmZoNZWFfrzrvJi7Rcr dmCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=J3oZWf32; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id 129-20020a630087000000b003fe26a00c53si3099451pga.519.2022.06.08.04.23.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 04:23:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=J3oZWf32; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1594E66210; Wed, 8 Jun 2022 03:45:29 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237180AbiFHKpV (ORCPT + 99 others); Wed, 8 Jun 2022 06:45:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237155AbiFHKpR (ORCPT ); Wed, 8 Jun 2022 06:45:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 600D86A407 for ; Wed, 8 Jun 2022 03:45:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 538F260DDF for ; Wed, 8 Jun 2022 10:45:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60062C34116; Wed, 8 Jun 2022 10:45:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654685108; bh=eRVrxw2TtDyOfO8gMWB1zIDrWzECqh2i9AYfRsqK6Hk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J3oZWf32QmN9uDJsIiHuUTFynEfYTOa1VnGwHnfllpgzxF7HurwOAgMNfPpQHycxQ 4IPqpl3lWWUQbdF3YWN8aj3OGKzrK0Ua1rTeuxLDcki8UUMuJ1Js1ovfnHcG6wqaHE OI6lmEVVS36JRlIeXqLvsR6iPZpUJYHZgpyJaIwc= Date: Wed, 8 Jun 2022 12:45:06 +0200 From: Greg KH To: Pavel Skripkin Cc: Martin Kaiser , Michael Straube , phil@philpotter.co.uk, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [BUG] staging: r8188eu: driver stopped working with commit ("staging: r8188eu: add check for kzalloc") Message-ID: References: <20220606064055.12565-1-straube.linux@gmail.com> <20220608092731.hz26q37fhmrhipmj@viti.kaiser.cx> <01d6737a-9e2d-c009-4e24-c2c54b39b80c@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01d6737a-9e2d-c009-4e24-c2c54b39b80c@gmail.com> X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 08, 2022 at 12:34:45PM +0300, Pavel Skripkin wrote: > Hi Martin, > > On 6/8/22 12:27, Martin Kaiser wrote: > > Hi Michael & Phil, > > > > Thus wrote Michael Straube (straube.linux@gmail.com): > > > > > The driver does not work anymore on my system. In dmesg there is: > > > > > "r8188eu 1-4:1.0: _rtw_init_xmit_priv failed" > > > > > I bisected it to commit f94b47c6bde ("staging: r8188eu: add check for > > > kzalloc"). > > > > > ~/kernels/staging> git bisect bad > > > f94b47c6bde624d6c07f43054087607c52054a95 is the first bad commit > > > > > At the moment I have no time to look further into it. > > > > See also > > > > https://lore.kernel.org/linux-staging/YoyU4zXf45UpF1Tq@kroah.com/T/#mb5e56a285b8eb1ebb0e798462fc388cb02b4a7cc > > > > Phil said in > > > > https://lore.kernel.org/linux-staging/YoyU4zXf45UpF1Tq@kroah.com/T/#m7a21d460b2569f6b59965ecc3298a6337fa3458a > > > > There is the posted patch [1]. I also have to apply it every time I want to > test smth. > > [1] https://lore.kernel.org/all/20220521204741.921-1-phil@philpotter.co.uk/ That patch is in linux-next and will be sent to Linus later this week. thanks, greg k-h