Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 8 Jun 2022 13:06:14 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Li Qiong <liqiong@nfschina.com>
cc:     Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Pandruvada@lists.nfsmail.com,
        Srinivas <srinivas.pandruvada@intel.com>,
        Ye Xiang <xiang.ye@intel.com>, Even Xu <even.xu@intel.com>,
        linux-kernel@vger.kernel.org, yuzhe@nfschina.com,
        renyu@nfschina.com, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/2] HID: intel-ish-hid: ipc: use time_before to replace
 "jiffies < a"
In-Reply-To: <20220606134750.20736-1-liqiong@nfschina.com>
Message-ID: <nycvar.YFH.7.76.2206081306090.10851@cbobk.fhfr.pm>
References: <20220606134750.20736-1-liqiong@nfschina.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 6 Jun 2022, Li Qiong wrote:

> time_before deals with timer wrapping correctly.
> 
> Signed-off-by: Li Qiong <liqiong@nfschina.com>
> ---
>  drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c
> index 8ccb246b0114..15e14239af82 100644
> --- a/drivers/hid/intel-ish-hid/ipc/ipc.c
> +++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
> @@ -578,7 +578,7 @@ static void _ish_sync_fw_clock(struct ishtp_device *dev)
>  	static unsigned long	prev_sync;
>  	uint64_t	usec;
>  
> -	if (prev_sync && jiffies - prev_sync < 20 * HZ)
> +	if (prev_sync && time_before(jiffies, prev_sync + 20 * HZ))
>  		return;

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs