Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2417343iof; Wed, 8 Jun 2022 04:41:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyo00ngDx96/ENbdVsV+alspqSdY3LEudlsbXOrXmB/jl80m7EewrDv1SBg//98bF2lI8UT X-Received: by 2002:a17:90b:1a86:b0:1e8:2b80:5e07 with SMTP id ng6-20020a17090b1a8600b001e82b805e07mr31002541pjb.31.1654688470150; Wed, 08 Jun 2022 04:41:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654688470; cv=none; d=google.com; s=arc-20160816; b=UY6nGm40kk8YgctkLDzI8aFZ15wCoKPV4JYyUOMyE4uu+iHRrgTTd+W/DJHQU1Yh69 AK9j41Vq1jge8DbmRaptJOWwxE0arUPmSO/9UK1Qmi1sCqjpS3MvZR5JwQnL5Ruf0lnz 4kYx6tXNGSsyB28DzosjFfwY3stKe55B/IbNQ/TUaSKiwaPS073KZztmaUu0JEmAyx8j VxerdQcj+OMbmA3CMBN0kwyaIWMC6MU1z4eFyVo5E54vAz5CkMLPFVwXcgYWbkHkLCIl 44T1K5RX+KfArzPDTTcHG7KtDTl7iir4CxuMwxn1y8c7+NZxFPRkgURfdBAuueeAx+Kh bW0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=GhopTikA8as21IlLBcNmsD6VgqcqHv8v6fBAzi4Rqbw=; b=ki+CjPbMFcbkHGpnV5CrVursgydNeUQ8cVbeIHifmFVZxZvicUIU9tzMhvgl8oBxLI uycplUHZre3Hihe5vfJ4cNX7dmfjFKbvVg/AFTEtZO1a629oEa0mZVAHuKpuR983+oC8 OQgZkDYqO10i2jjpW4wx93kkLcMuroG4A9zIDc8FBSfgHpaUEFH+NYIHEU/qLvZoCTjM PQ8lc10Nwq2zcq82ZXY48GBK/2lyBUNTxAKDfNdONf+Rt9yLkB8xiXH1Fsg9uYjtXjhA zIfuitl2d+LlJg5dq9BS/WMub2D2ZiSWKO/NGWsCdbf0btvEFwvOKnf8s8yXkp3V+2ZE tfmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WCQzpCSA; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id h10-20020a170902f70a00b001628bedb69asi22688231plo.487.2022.06.08.04.41.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 04:41:10 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WCQzpCSA; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 682A421D3F2; Wed, 8 Jun 2022 04:09:17 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237834AbiFHLIu (ORCPT + 99 others); Wed, 8 Jun 2022 07:08:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237842AbiFHLIO (ORCPT ); Wed, 8 Jun 2022 07:08:14 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA1041B7830 for ; Wed, 8 Jun 2022 04:07:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9A21AB826F2 for ; Wed, 8 Jun 2022 11:07:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DB08C341C6; Wed, 8 Jun 2022 11:07:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654686474; bh=aJzp2r5ahOwBl7hiZoC8UrDVJ/W0sy8bmq1ExWIBB9k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WCQzpCSAkQUi2t2gk1w4QUATihCBrVCVk6Gi+z7BAzS3wc3A3yjy3S59e8CH3DFhm P7jCM0kil7VhyaH0YCfS6gCTfQbKlv8snsvLOX5W8nolGNLSyFdMhoGU26pJhvs3e6 BiZZ6hr7JyIU3ZMVfgvbmORAw9BwyauF3MVvaqZoB0jxNIRhR5xOCa4uoiAbLA2ruB M553HFy0aPwwq6YAoZKIIL5Oc5yIu6fXAyFIb224rREe5mukSii8nLpo86Shb1Ugfg 4QgiZi/s1cmsGHTEhTXh1giCGyzS3gLqgoWZFvEdhR8BhrMjF3Q+2uH95nRP7FEyCL /ka9Kfpsrrrmg== From: Tzung-Bi Shih To: bleung@chromium.org, groeck@chromium.org Cc: chrome-platform@lists.linux.dev, tzungbi@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 05/23] platform/chrome: cros_ec_proto: remove redundant NULL check Date: Wed, 8 Jun 2022 11:07:16 +0000 Message-Id: <20220608110734.2928245-6-tzungbi@kernel.org> X-Mailer: git-send-email 2.36.1.255.ge46751e96f-goog In-Reply-To: <20220608110734.2928245-1-tzungbi@kernel.org> References: <20220608110734.2928245-1-tzungbi@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org send_command() already checks if `ec_dev->pkt_xfer` is NULL. Remove the redundant check. Reviewed-by: Guenter Roeck Signed-off-by: Tzung-Bi Shih --- No change from v2. Changes from v1: - Add R-b tag. drivers/platform/chrome/cros_ec_proto.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c index 629dce3e6ab3..1b851dcd20c9 100644 --- a/drivers/platform/chrome/cros_ec_proto.c +++ b/drivers/platform/chrome/cros_ec_proto.c @@ -281,9 +281,6 @@ static int cros_ec_host_command_proto_query(struct cros_ec_device *ec_dev, */ int ret; - if (!ec_dev->pkt_xfer) - return -EPROTONOSUPPORT; - memset(msg, 0, sizeof(*msg)); msg->command = EC_CMD_PASSTHRU_OFFSET(devidx) | EC_CMD_GET_PROTOCOL_INFO; msg->insize = sizeof(struct ec_response_get_protocol_info); -- 2.36.1.255.ge46751e96f-goog