Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2461602iof; Wed, 8 Jun 2022 05:34:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwSx8LrE3InPbrA99Zl8xf2epgvB2geMGkrWorjNtTaEp/Bh+R3eRXBkg+LRgjRtEI0RjD3 X-Received: by 2002:a17:902:ec86:b0:163:e4de:f9ae with SMTP id x6-20020a170902ec8600b00163e4def9aemr33742724plg.64.1654691639949; Wed, 08 Jun 2022 05:33:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654691639; cv=none; d=google.com; s=arc-20160816; b=TmgA688FFxVwWaCfc/ijzCl1rXYmzORlncqopFmNAbF5EUGnOTMNJNB+e+Rr5+CsAg 6I1tMX2so9/yhOtyZe2nNWBA34nsEErtKJXfLR/nFIfzfXkWtJkP+P+QNu2PfmMmp+V1 vaeG+EFU3pH5ybGgiEgwCcV7TMoFUrN/s1DIorzPrPOGaBWqewsQLcSloXz6RZLuQtf0 qm09AtS+vnbICMcfZYIW4VokXRj8I0Wb9Dji4qXSD/1cliZfXWEWlqGiEpcFY8LNmZ2R dRCWgqaUNEr3LH5ajdI1SC1cyxe14/03s+vCrCamTorUI0jJcWrVYC91vo6DTeHCMErH acyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=cXixKaaJgDBnxATXfFN84OGHzoON5mCeI0Ro/+g//u4=; b=GMipIEQryoM7ikLduIfrNlA5EE6q28cSuQ0QWB0BAAYa0nfNnz1umDnpm9wN+1axlk EXwveOypPN69xk5Q5h6IRI0doQCcLHa5XOhttEhI4Rnkf+YcP4Wa+XkzCItovumTZJ+t yL94izrTt35e5Ly6GB4Mn13CAvrqiyMGGt7ITILlBqMcySxSLhLI66ohx+V03n3ImInp piR1HCKTOVPNH0W0Q+hx6cZ8Nhq6P6hmR4RuSV2b2m2jqwdNyj3pN867bGGTEr6nm68v yxvK9nxYZY4ZuQrQBq6BPd+6Kp5c2FaiM60D30rPMcQ6fVkqFshrl0+lrS0eTcjynvH2 /Byg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=h6netybU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id r194-20020a632bcb000000b003fba9436128si30275423pgr.697.2022.06.08.05.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 05:33:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=h6netybU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E76BD10D5CB; Wed, 8 Jun 2022 05:07:16 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238611AbiFHMHF (ORCPT + 99 others); Wed, 8 Jun 2022 08:07:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230111AbiFHMHD (ORCPT ); Wed, 8 Jun 2022 08:07:03 -0400 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C797396BF; Wed, 8 Jun 2022 05:07:01 -0700 (PDT) Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 258BqYoq009177; Wed, 8 Jun 2022 12:07:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=cXixKaaJgDBnxATXfFN84OGHzoON5mCeI0Ro/+g//u4=; b=h6netybUnQruQ/QOgul3xwGiQ8i4bIcoNibqOOBSXUqMsS4sVjYlPt/EpIoxR9c9dOl6 8MllQkyjr1Xi7JAU/uasAWIokZ57bv9m20+t9DaPbkLxjVulCn+0HpCMQ2wbrK9M+kNu HAM2/u1vqANO5sddfq02ME8tMq9yf+HBsY5N7XVfP+FA1oDZjrQDbXuzO1kM6bqwRZd8 csXcWL5b/MCfLUHAOG2oJkgDqobiqvyuX6xnhv3U1Ceov4YxRSGYE5WLq9u2olKaQOBb AzYXvF0EefSh6iqOlDGzJfT0fIEkM0ksu4T/eOpY2Zrld9n9y+SDPQnMk9qTlHsgBBuy Ag== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gjsxxsyqe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jun 2022 12:07:01 +0000 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 258BqZcu009276; Wed, 8 Jun 2022 12:07:00 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gjsxxsynv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jun 2022 12:07:00 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 258C6GFe021013; Wed, 8 Jun 2022 12:06:58 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma06ams.nl.ibm.com with ESMTP id 3gfxnhw6my-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jun 2022 12:06:58 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 258C6t1c23920896 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 8 Jun 2022 12:06:55 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 86F184C040; Wed, 8 Jun 2022 12:06:55 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2E6434C04A; Wed, 8 Jun 2022 12:06:55 +0000 (GMT) Received: from li-ca45c2cc-336f-11b2-a85c-c6e71de567f1 (unknown [9.152.224.44]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 8 Jun 2022 12:06:55 +0000 (GMT) Date: Wed, 8 Jun 2022 14:06:53 +0200 From: Nico Boehr To: Claudio Imbrenda Cc: kvm@vger.kernel.org, borntraeger@de.ibm.com, frankja@linux.ibm.com, thuth@redhat.com, pasic@linux.ibm.com, david@redhat.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, scgl@linux.ibm.com, mimu@linux.ibm.com Subject: Re: [PATCH v11 13/19] KVM: s390: pv: destroy the configuration before its memory Message-ID: <20220608140653.0afd1e75@li-ca45c2cc-336f-11b2-a85c-c6e71de567f1> In-Reply-To: <20220603065645.10019-14-imbrenda@linux.ibm.com> References: <20220603065645.10019-1-imbrenda@linux.ibm.com> <20220603065645.10019-14-imbrenda@linux.ibm.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: MUia7LRik7XvRU1QOtlTJ40OnplvHaFt X-Proofpoint-ORIG-GUID: 8And7xx3QvkMCQ87-4Q_-wzYAjJrWrWg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-08_04,2022-06-07_02,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 malwarescore=0 adultscore=0 spamscore=0 suspectscore=0 bulkscore=0 clxscore=1015 mlxscore=0 priorityscore=1501 mlxlogscore=900 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206080049 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 3 Jun 2022 08:56:39 +0200 Claudio Imbrenda wrote: > Move the Destroy Secure Configuration UVC before the loop to destroy > the memory. If the protected VM has memory, it will be cleaned up and > made accessible by the Destroy Secure Configuraion UVC. The struct > page for the relevant pages will still have the protected bit set, so > the loop is still needed to clean that up. > > Switching the order of those two operations does not change the > outcome, but it is significantly faster. > > Signed-off-by: Claudio Imbrenda Reviewed-by: Nico Boehr