Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Yihao Han <hanyihao@vivo.com>
To:     Helge Deller <deller@gmx.de>, Yihao Han <hanyihao@vivo.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] video: fbdev: au1100fb: Check before some function not needed
Date:   Wed,  8 Jun 2022 04:43:25 -0700
Message-Id: <20220608114658.37105-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CXy1yzpqx3p+7bMI7giFataw65WvLWQCBRrkXb+Hbs6zbQiYV70RpOLbsaeP?=
 =?us-ascii?Q?UnWku0xPr17c7h0lEDBr4+ksUzTIeeimYJsjy5pXVKgCi5NyP5mmO5ybvJz8?=
 =?us-ascii?Q?mZQ1cJA1igeaiUGx5+xqMspLKiXyPCxzYhMhIzU87buz8UydgSotcqLl7QMx?=
 =?us-ascii?Q?dFbmfUswFnT6rTyL5z4mQxNcYWKXJTrb2DvubeZUzxic4bVpswk9XgAsoKtN?=
 =?us-ascii?Q?mFikEOYQ6JM4MylpFA254ByKSh8D51ianvv7CRx8/WgJpKDh3FPl7bh465Cv?=
 =?us-ascii?Q?cvOf1XB8uEAh7m5cFnlyARW2K7eJKVb1jdwUDsobvjxeharilUf9K64ZXSvV?=
 =?us-ascii?Q?4Y0OeQAYKhx6KaP1+//sedzi1pUSp8uWc6NllHTURg/pIRyB/NMQmUqxTIAg?=
 =?us-ascii?Q?s38MWLA/acMvUeOsaKAcnJ01HLUSbjinbD9d7C7atLfS9dOo4+WIJ+x46IRe?=
 =?us-ascii?Q?/zuLzKDrd9L5j1kXbndvCgy0+Z8KIo0T66OBj3oHJwZrD49OjIO2Vlrz0LzC?=
 =?us-ascii?Q?umJFVSypSCrZ+DipZBEZPK/JTy9FpzYYkeZ4qda91Yc99ZnX3bHJrCvYuapz?=
 =?us-ascii?Q?7cUXT8dCvSjEkCjvgowpRL8MiqN1AeNXp2kOTsV0nU3uMFjtBI1QsIdvigqE?=
 =?us-ascii?Q?ppe1C9nnuW7IqWPtI599lvcWLqZs6TX3uvLRV6uC7ZfOg1KBkitAKGQ/ZLv5?=
 =?us-ascii?Q?ojNawzl1ymkXdR5oyzPy33Q+6k11/8OjPYAkyrpO2PFUWEpdSy0l9FHhsyGZ?=
 =?us-ascii?Q?l2XJoa8Y6IaHT5Jimd0HwdYYgrTD0VSmKji3nJlxBsXESeyuHdJ6zkn7CAU5?=
 =?us-ascii?Q?VN55bjZDVrxeoJ9PRQpZIQ9FSf8ujreKSvE/ya0dHovTReFnaKsI7mMZzZF8?=
 =?us-ascii?Q?vzWk3b8+SrjYo5VtnjbGOMgRkIIl/P7cHbDFU1rMp+MZtiQOLSQX3RrTncAj?=
 =?us-ascii?Q?hRZlhHNPgBmeq9zPlUX/YxdDXKyeQRvV0Wh9J/c6OdzIPDi+AG7JdnNlBkwP?=
 =?us-ascii?Q?R4IQmnfPUIUuz7BAiaIMWz270in4E9Tm9CuTnu0xB8dL8iy4aH3nX/v38Vyn?=
 =?us-ascii?Q?Vw1PJ3gaT1EuiLPfkci4+YHUB/O3qRCvx4JVF/6EEeoxVvp4/Cmvvve/uEr2?=
 =?us-ascii?Q?MSxCB02OeXqfT/qw6geZ2hCliCmGK3q1Rk0ER8t/xDEKXKSJbiLb2XkjQaqY?=
 =?us-ascii?Q?16+VBHVk7jaK4Pfu6ydGBAso+ikmF1LMCHruWtQRXVrWNhqY1vkhzxv00pL3?=
 =?us-ascii?Q?jUfZSMF1G5o4ZPaBZvhcn5HShX7v79fAOsBLNLfBQWOxuQRYB3qSEuEgGnZb?=
 =?us-ascii?Q?Io1ra8gUDlfXHjhgzA/6TQ/efMDPf61dC435xEimr6vKbyESm35ZIRrcGe+d?=
 =?us-ascii?Q?uzOX1WH06wgS6Yt/MqQBjFvcKkn2rdj4DPyRqyz/McIccbTDCBrLgoJC2zvn?=
 =?us-ascii?Q?Uw3+AeZwXqwugqvi72Xof33xGtnDYfdkHbqR1TcmhSHj0Zzn8DJZJjPlaH6t?=
 =?us-ascii?Q?RN67CsTrFEeL3+Jv0Dmvo3jisO7hnheQurk50KvTSrVom90CBQrj9H+EdP5s?=
 =?us-ascii?Q?MdNS8APtdnhCHpZQKAYJNPynBjssARm32dArUuvbFsZBv9qUZ/jWuDcUCW2E?=
 =?us-ascii?Q?9O2g0ogDAX/GJgPKQaBYrHvbFZ9lQY8JI5GPUb50B5oIAc0URcfPq8RH9NTF?=
 =?us-ascii?Q?517wf2K3btTmpFea7ooYVRQAIGCHF7jTCTRmaCINd4vJHaQxQDgEDkP0hS22?=
 =?us-ascii?Q?zM17SLLq+w=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f4eb776-0837-4898-c77c-08da49497431
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2022 12:21:45.9080
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UdbQWFrY5uTKm7Rv7cMl4cRlFvvyP5R53w2xYLyxId123p8xnjzcEw2jqNkkkbnHMd32zopdfzsDK+UHbug11w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3808
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

clk_disable() already checks the clk ptr using IS_ERR_OR_NULL(clk)
and clk_enable() checks the clk ptr using !clk, so there is no
need to check clk ptr again before calling them.

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 drivers/video/fbdev/au1100fb.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c
index 52f731a61482..519313b8bb00 100644
--- a/drivers/video/fbdev/au1100fb.c
+++ b/drivers/video/fbdev/au1100fb.c
@@ -560,8 +560,7 @@ int au1100fb_drv_suspend(struct platform_device *dev, pm_message_t state)
 	/* Blank the LCD */
 	au1100fb_fb_blank(VESA_POWERDOWN, &fbdev->info);
 
-	if (fbdev->lcdclk)
-		clk_disable(fbdev->lcdclk);
+	clk_disable(fbdev->lcdclk);
 
 	memcpy(&fbregs, fbdev->regs, sizeof(struct au1100fb_regs));
 
@@ -577,8 +576,7 @@ int au1100fb_drv_resume(struct platform_device *dev)
 
 	memcpy(fbdev->regs, &fbregs, sizeof(struct au1100fb_regs));
 
-	if (fbdev->lcdclk)
-		clk_enable(fbdev->lcdclk);
+	clk_enable(fbdev->lcdclk);
 
 	/* Unblank the LCD */
 	au1100fb_fb_blank(VESA_NO_BLANKING, &fbdev->info);
-- 
2.17.1