Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 8 Jun 2022 14:49:07 +0200
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
To:     viro@zeniv.linux.org.uk
Cc:     linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] splice: allow direct splicing with chardevs
Message-ID: <YqCaw3zychulNAp1@zx2c4.com>
References: <20220520095747.123748-1-Jason@zx2c4.com>
 <938111ca-d3c7-9888-24f8-0017a989002b@kernel.dk>
 <CAHmME9pSZYZSz3YLRK7onO0E6zq9_B1GNwoTOkEQy_kws200Fw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAHmME9pSZYZSz3YLRK7onO0E6zq9_B1GNwoTOkEQy_kws200Fw@mail.gmail.com>
Precedence: bulk

Hey again,

On Thu, May 26, 2022 at 11:19:46PM +0200, Jason A. Donenfeld wrote:
> Hey Al,
> 
> On 5/20/22, Jens Axboe <axboe@kernel.dk> wrote:
> > On 5/20/22 3:57 AM, Jason A. Donenfeld wrote:
> >> The original direct splicing mechanism from Jens required the input to
> >> be a regular file because it was avoiding the special socket case. It
> >> also recognized blkdevs as being close enough to a regular file. But it
> >> forgot about chardevs, which behave the same way and work fine here.
> >>
> >> This commit adds the missing S_ISCHR condition so that chardevs such as
> >> /dev/urandom can be directly spliced without strangely returning
> >> -EINVAL.
> >
> > Should be fine to turn this on for char devices:
> >
> > Reviewed-by: Jens Axboe <axboe@kernel.dk>
> >
> 
> Was wondering if this would make 5.19. That'd be nice, as it's the
> release in which we switch to read_iter().

Just thought I should ping once more on this. Should probably be queued
up somewhat soon for 5.19 if it's to make 5.19, which I would really
appreciate.

Jason