Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <59b85c65-198c-5147-bbc6-818ce2234b6c@linux.intel.com>
Date:   Wed, 8 Jun 2022 08:49:45 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH 2/2] perf vendor events intel: Update event list for
 Snowridgex
Content-Language: en-US
To:     zhengjun.xing@linux.intel.com, acme@kernel.org,
        peterz@infradead.org, mingo@redhat.com,
        alexander.shishkin@intel.com, jolsa@redhat.com
Cc:     linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        irogers@google.com, adrian.hunter@intel.com, ak@linux.intel.com
References: <20220608063439.1997394-1-zhengjun.xing@linux.intel.com>
 <20220608063439.1997394-2-zhengjun.xing@linux.intel.com>
From:   "Liang, Kan" <kan.liang@linux.intel.com>
In-Reply-To: <20220608063439.1997394-2-zhengjun.xing@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/8/2022 2:34 AM, zhengjun.xing@linux.intel.com wrote:
>       {
> -        "BriefDescription": "write requests to memory controller. Derived from unc_m_cas_count.wr",
> +        "BriefDescription": "All DRAM write CAS commands issued",
>           "Counter": "0,1,2,3",
>           "CounterType": "PGMABLE",
>           "EventCode": "0x04",
> -        "EventName": "LLC_MISSES.MEM_WRITE",

The old convertor tool creates many alias to replace the event in the 
event list. The LLC_MISSES.MEM_WRITE event is one of them.
There is no problem to add the original event name. But I think we 
should keep both alias and the original name, in case someone already 
used the alias in their script.


> +        "EventName": "UNC_M_CAS_COUNT.WR",
>           "PerPkg": "1",
> -        "ScaleUnit": "64Bytes",
>           "UMask": "0x30",
>           "Unit": "iMC"
>       },

Thanks,
Kan