Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <5c847f66-9caf-b303-2c25-b22e67a83c79@quicinc.com>
Date:   Wed, 8 Jun 2022 20:00:30 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v2 2/3] usb: phy: Add devm_of_usb_get_phy_by_phandle
Content-Language: en-US
To:     Sergey Shtylyov <s.shtylyov@omp.ru>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Felipe Balbi <balbi@kernel.org>,
        "Bjorn Andersson" <bjorn.andersson@linaro.org>
CC:     <linux-usb@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <quic_pkondeti@quicinc.com>,
        <quic_ppratap@quicinc.com>, <quic_jackp@quicinc.com>,
        <ahalaney@redhat.com>
References: <1654276362-28930-1-git-send-email-quic_harshq@quicinc.com>
 <1654276362-28930-3-git-send-email-quic_harshq@quicinc.com>
 <c52d93db-e89a-24ba-725c-420641bd43af@omp.ru>
From:   Harsh Agarwal <quic_harshq@quicinc.com>
In-Reply-To: <c52d93db-e89a-24ba-725c-420641bd43af@omp.ru>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/6/2022 4:30 PM, Sergey Shtylyov wrote:
> Hello!
>
> On 6/3/22 8:12 PM, Harsh Agarwal wrote:
>
>> Adding support for devm_of_usb_get_phy_by_phandle which allows
>> us to get PHY phandles of a device declared inside lookup_node.
>>
>> Signed-off-by: Harsh Agarwal <quic_harshq@quicinc.com>
> [...]
>> diff --git a/include/linux/usb/phy.h b/include/linux/usb/phy.h
>> index e4de6bc..2581c72 100644
>> --- a/include/linux/usb/phy.h
>> +++ b/include/linux/usb/phy.h
> [...]
>> @@ -249,6 +251,12 @@ static inline struct usb_phy *devm_usb_get_phy_by_phandle(struct device *dev,
>>   	return ERR_PTR(-ENXIO);
>>   }
>>   
>> +extern inline struct usb_phy *devm_of_usb_get_phy_by_phandle(struct device *dev,
>     *extern inline*? :-O
>     Shouldn't it be *static*?
This was a typo. Will change it. Thanks
>   
>> +	const char *phandle, u8 index, struct device_node *lookup_node)
>> +{
>> +	return ERR_PTR(-ENXIO);
>> +}
>> +
>>   static inline struct usb_phy *devm_usb_get_phy_by_node(struct device *dev,
>>   	struct device_node *node, struct notifier_block *nb)
>>   {
> MBR, Sergey