Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 8 Jun 2022 08:00:39 -0700
From:   Josh Poimboeuf <jpoimboe@kernel.org>
To:     Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc:     Joe Damato <jdamato@fastly.com>, "x86@kernel.org" <x86@kernel.org>,
        "jpoimboe@redhat.com" <jpoimboe@redhat.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jiangshanlai@gmail.com" <jiangshanlai@gmail.com>,
        "bp@suse.de" <bp@suse.de>, "brgerst@gmail.com" <brgerst@gmail.com>
Subject: Re: 5.19-rc1 x86 build failure
Message-ID: <20220608150039.uunijnzx6t4irfrm@treble>
References: <CALALjgwSm07Cnbm6WaK74ZSs4wJ7hs4B3wLOe7h4Y-7sJ5cUWg@mail.gmail.com>
 <74fdda90-f015-5cb9-a2d2-137baf090c59@citrix.com>
 <20220608005956.hzvx3fapdmp25oun@treble>
 <b5e11680-9101-24ec-0977-c5d0ff8c98c2@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <b5e11680-9101-24ec-0977-c5d0ff8c98c2@citrix.com>
Precedence: bulk

On Wed, Jun 08, 2022 at 09:24:25AM +0000, Andrew Cooper wrote:
> On 08/06/2022 01:59, Josh Poimboeuf wrote:
> > @@ -133,12 +125,16 @@ asmlinkage void __init x86_64_start_reservations(char *real_mode_data);
> >  
> >  #endif /* __i386__ */
> >  #endif /* _SETUP */
> > -#else
> > -#define RESERVE_BRK(name,sz)				\
> > -	.pushsection .brk_reservation,"aw",@nobits;	\
> > -.brk.name:						\
> > -1:	.skip sz;					\
> > -	.size .brk.name,.-1b;				\
> > +
> > +#else  /* __ASSEMBLY */
> > +
> > +#define RESERVE_BRK(name, size)				\
> > +	.pushsection .brk_reservation, "aw";		\
> > +__brk_##name:						\
> > +1:	.skip size;					\
> > +	.size __brk_##name, . - 1b;			\
> >  	.popsection
> 
> While I think about it before you write the patch properly, you ought to
> have a .type in here too, seeing as the C side now gets one.

Good point, I'll just use the SYM_DATA_{START,END} macros.

-- 
Josh