Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2625857iof; Wed, 8 Jun 2022 08:44:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycr77z0EGfgbKxo69pnT9ht056fxfzPE4see0UCFgQYEUKWW6/VlAQZJEvHJw5gzo8XoFp X-Received: by 2002:a17:902:e552:b0:163:6a5e:4e08 with SMTP id n18-20020a170902e55200b001636a5e4e08mr34341559plf.130.1654703069768; Wed, 08 Jun 2022 08:44:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654703069; cv=none; d=google.com; s=arc-20160816; b=uT58DF6Hq3JH93OhsXuK/j+jqc+UmwfSuSM/nK3aBMH25O8VobfiX/+lgKiG5cn9NO JEwHBBPlm7/neaOXtaLSt/GJ7WUpM3K6LTEvBHFbg/+5ROhHRQiIfCyzpsFRLp/dStxY /hlfFq3SyofFoc7ZMAtfODhkKfr4i7FCwI+YFVoqrM5xFTVvV9A/3VUqcb0wyxOnNQ4l 1ZEMiMjXpC1w01Aa+Ngmoq/0OgI2LXt+ulcgLHmslttOov3ixl4HFfw2Nc/7cmtlNwm5 UignCsMFDXCQi+EH/TTTcHhb7j2DboUergKYQatJ+ovi9Uw3MS4Zi2MIH5r/LfErYXQf t8Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=jR5ucCRD1ctjVwCehTL8/SWrd6GdcH9zFkM7ubCwloY=; b=eP5G3M4BA/mE9eBuhHumxs0vwL/lgUlUfHd3el3Al5JQ8xJe7NntHOzM3KtxHosH/f zLSFr+IOsapxTY6srKz/d+2dbC2IiPfEWhAIEaJWPUVqj94yqBEnfoAZv2ipx2bDsvW2 tiiIplgHpjcxtj/ddCnRSiOcodeugXXdJAZvPljfO4xXwWQ/DEzYfQQIMUPQod92nVft BjyweyFK4tPmlhouFXgrY9sfDTqTWhzfRcmgbsSS+sYkeNTSaDxqa1DVprMXfWhulNvH Gwyq5Dh5EmhmdhUQkj/egecShdhtZLcFt3Vkp6coJ1aC0+9piUd4hWUT/FtyRbbQy3fC 5FAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=r9pPqM8x; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id r23-20020a63ec57000000b003fc52ba77desi24654764pgj.408.2022.06.08.08.44.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 08:44:29 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=r9pPqM8x; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A8D3DE2064; Wed, 8 Jun 2022 08:15:47 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243237AbiFHPPA (ORCPT + 99 others); Wed, 8 Jun 2022 11:15:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244341AbiFHPOa (ORCPT ); Wed, 8 Jun 2022 11:14:30 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6492612F36B for ; Wed, 8 Jun 2022 08:07:10 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id h5so28815601wrb.0 for ; Wed, 08 Jun 2022 08:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jR5ucCRD1ctjVwCehTL8/SWrd6GdcH9zFkM7ubCwloY=; b=r9pPqM8xpt4wuylBRff/ucXvli/IL8AT6e5ujPXj7W0sxQShSi4vSzFvBPtleE/arT 52P2pGJSMAtvjESFWTEk4YQzjof7UsrgznsJZmD5q8OvLGZHMpf/dv84svtTinZcmLIF eU86GhRZ/CuwERlgwHQiEV/5jtye/wcpYdF9kLH0JLg2mflhmrwEaj86qxueENn3Ae2Z uuQR+j8GxrWQnEjTiho8wBGVU6DVTd4aiRfKTM6mBh3/ZZXM2fs6faBcw0he9XDEQZkz LbmO6pqkZk5PwmTJX2ANZesI6XiSbfuLnrNu3klX79FWXV2/Mhx5V3LvMC65yrAux3Xk Wjpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jR5ucCRD1ctjVwCehTL8/SWrd6GdcH9zFkM7ubCwloY=; b=WPu9InFeTIjdBiLheZGGyBza96YXUSIaet1KiPJ+HErWdtSjY8KUWv6IsXj+oVy7ba te9DNkz26yMN/6O4BqNiB84AvJc4/GyRC52pTw1HYpeZaIWjTI8ismXh0Y34OYqCX5mk cpMkgdfszm8rn2GU4//gJmB3yKqjXUicL8x5l5RKod1MEP3vJ+Ov5qL9a3YdSsyGrcDC B/RvwQXBqovkOpLocYMBYJyJXc3Y5VZSEaiBbXCKdm9Te8TeRiidhT9fTAzVSTZoFg2t uR57Rg5vMVs61A9bCBz/dGeDpzvYqhBizCU5+gq26+6jnPnxer1l+Cdk7YttOgwz+xye HqYA== X-Gm-Message-State: AOAM533IwOh063fQjt0KCh2McI9daGR+VpEQm6QTjIuSXYT/BmbMKrUf alAC7qQCBt+sj8AsYUqRZ8qlUg== X-Received: by 2002:a5d:624e:0:b0:210:a42:f29d with SMTP id m14-20020a5d624e000000b002100a42f29dmr33145631wrv.615.1654700828851; Wed, 08 Jun 2022 08:07:08 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id x4-20020adfffc4000000b0021018642ff8sm21453128wrs.76.2022.06.08.08.07.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 08:07:08 -0700 (PDT) Date: Wed, 8 Jun 2022 16:07:06 +0100 From: Daniel Thompson To: Stephen Kitt Cc: "Lee, Chun-Yi" , Hans de Goede , Mark Gross , Cezary Jackiewicz , Henrique de Moraes Holschuh , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net Subject: Re: [PATCH 4/4] platform/x86: thinkpad_acpi: Use backlight helper Message-ID: <20220608150706.fjuaalab5kzapc47@maple.lan> References: <20220607184635.1127913-1-steve@sk2.org> <20220607184635.1127913-5-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220607184635.1127913-5-steve@sk2.org> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 07, 2022 at 08:46:35PM +0200, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt > Cc: Henrique de Moraes Holschuh > Cc: Hans de Goede > Cc: Mark Gross > Cc: ibm-acpi-devel@lists.sourceforge.net > Cc: platform-driver-x86@vger.kernel.org Reviewed-by: Daniel Thompson Daniel.