Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2627058iof; Wed, 8 Jun 2022 08:45:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwElIDcJ6Qz8D6vcSd44rRFqrjV2rZjOBzbic5h0aVPY8YZrnMjOxtVUyi6TNrmOUzyS6li X-Received: by 2002:a17:90b:1d83:b0:1e2:f63e:bc37 with SMTP id pf3-20020a17090b1d8300b001e2f63ebc37mr56455579pjb.119.1654703146035; Wed, 08 Jun 2022 08:45:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654703146; cv=none; d=google.com; s=arc-20160816; b=ElX1+vIc0jzpAkqP8Rp39p53LD/L92ubFeEP5S7r+yq9KW1igbPUOYpco7PLKl9aSO B3JMCrImhc4yDk7ZZ14qhqfmGiKqSIRKeQfNhJuJyBFr6WUExM09MY7Jxk9DX5Q7TI6m l4vuZpVQe8hQd4fl/1C9wuq2gemFowygt0nRyI0X0M0vgT5xvzniConzi6uIsi2yPnc+ +frlIjtxXwfyDlsNgHaYUd7mV0le1C/UdrX0lQAzs55cWE1fv4qnKrgwph/ovmackjir 7i55CCVzTlJ4LitPv0XgjZzVOaeaYgwkGAPRCwZt+lqLdYAR7Ru6wm6jJTnDp6Nmf0lX R8yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=PhrsnkQYF8hJROFLG3oTpTLzsaUl8ukSdrO+5KpRu9o=; b=tlbw9xI3UBZMMxNttcXQp+NfQUxdk8g1KnaTRbIS49SVMW9qwgAUTEGWguO618MxX1 zWkt1qCQ/qtIChZRTTXGtxti0p3coSiIWMnORsTZ0GqR2A2p7wPv09oP3xuqKkqcURtm 5359uej6vWyDoHx1pGVETu6EguHIlquPHugVkXwb7/OWhGt+8zlCbHcKHZoxsBSJCNJ5 KRU3n43CUeZDSTCrxzEZD5Y8yc9fSsWzwzcz4CT9Su5iiIAWWTZf6ypQoHcsIxj2dFvj BagQ3TCQTjeL9Nh9TCvf9Cn7px5VWm71Zj0b2vnrXzzxi+UJtio7cOstyfbDbNcDUHlU GLhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="oNno/0Hb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id 9-20020a630009000000b003fccc4a7452si27986816pga.132.2022.06.08.08.45.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 08:45:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="oNno/0Hb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B4F32100B13; Wed, 8 Jun 2022 08:16:58 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244031AbiFHPP3 (ORCPT + 99 others); Wed, 8 Jun 2022 11:15:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243212AbiFHPOL (ORCPT ); Wed, 8 Jun 2022 11:14:11 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CD7020C243 for ; Wed, 8 Jun 2022 08:06:36 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id d14so19763396wra.10 for ; Wed, 08 Jun 2022 08:06:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PhrsnkQYF8hJROFLG3oTpTLzsaUl8ukSdrO+5KpRu9o=; b=oNno/0HbthPALtO1PqKOPIaz5DBcFf9pQWt8bZu0u8lxyCMFRn99MmD/7nQpyKYBjW 9z4NkSnmwkbSBCcrMc9tNIZFPojEWX1fUE2Z4l26/61CQ/QJ3t3Dfy8iRwncY8JsrDvW WcGPn0EIk7FDariBsKjKiV8kWPlyVeGGAPvLRVxpqCqCZAfEAEbrUpX0WPh+qa6+hyfS VRibz/A2tn66MQ7M04t1ysEoJCULNws+NqbRP06JhkMEpTtjNSKaaFU7RBBx0X/X+nLR /RQRKZpwczAm6BSqgWxWzNEQwGM3y8g022JdnuH/9iS6cWuNwhlPUqduiSU7NQSa3nvY aT/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PhrsnkQYF8hJROFLG3oTpTLzsaUl8ukSdrO+5KpRu9o=; b=WPBq73CSFxYZs7WaSRqTaMuEuDqL/ZcQzAOT8zbM4XOYJ3L8TRtNGsQCsRN/hxyjyo NLSZhuUIpZ9A1wnklwcZn/BZJZgsOur7bBMyxjGskifRYDcXb21qym0iG34dobNj1hK3 Rx3hGw4c9GKeyEIWa5orK/NPQrfEi/3VJoRAzJVejOpTicCN+/9ne6pLnOIjJhHh9SqM ZZnJFGBhsHP7A989adh8LH1MtJjeqSmK5ve5r1EM30L52vg/9SkjbSJOt/VLpdZkcg8j 8d5ekCzJBmLdWAcdVgE55eozwaex0aW1anZfsURRpFYyfvCeAXvXWSSJzrj+XQXbP7iR GQWQ== X-Gm-Message-State: AOAM532ULn8yYIVOprddOJ2UUuM/Wgu3NIWwb+54YJrVRpPha2eLZYmc MHiBEYyYF18qgovSuiwW/Giz9A== X-Received: by 2002:a5d:6f1c:0:b0:213:d715:d09f with SMTP id ay28-20020a5d6f1c000000b00213d715d09fmr28589518wrb.275.1654700794698; Wed, 08 Jun 2022 08:06:34 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id t22-20020a05600c41d600b00397550b387bsm28672852wmh.23.2022.06.08.08.06.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 08:06:34 -0700 (PDT) Date: Wed, 8 Jun 2022 16:06:32 +0100 From: Daniel Thompson To: Stephen Kitt Cc: "Lee, Chun-Yi" , Hans de Goede , Mark Gross , Cezary Jackiewicz , Henrique de Moraes Holschuh , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] platform/x86: apple-gmux: Use backlight helper Message-ID: <20220608150632.mnebepml2cply4px@maple.lan> References: <20220607184635.1127913-1-steve@sk2.org> <20220607184635.1127913-3-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220607184635.1127913-3-steve@sk2.org> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 07, 2022 at 08:46:33PM +0200, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt > Cc: Hans de Goede > Cc: Mark Gross > Cc: platform-driver-x86@vger.kernel.org Reviewed-by: Daniel Thompson Daniel.