Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2637559iof; Wed, 8 Jun 2022 08:59:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzfeIEZzfk8HY4WVRevI9TO6mShbNC9hr9KSlOecmGjP3Z65p5DAQfnK9t8XGy/hk6qQ6Sj X-Received: by 2002:a17:90b:4a42:b0:1e3:331e:d3ec with SMTP id lb2-20020a17090b4a4200b001e3331ed3ecmr38022788pjb.147.1654703985456; Wed, 08 Jun 2022 08:59:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654703985; cv=none; d=google.com; s=arc-20160816; b=0lU//soNl1WQM0bFwGd+hO1Ewz9Zcr7tDjIag/akYeq5pvH/cKtMuTnh5U4OjwG1DF eQ6FdNbH/eDI+NnOYGTG6X983IDr3/59iX5ncSidpLh9M9BtDsGec4vcnBoXQndiDVG4 eQIc/51mPJ2QP9hqm4rDFNv6+m1JsAa/iOvWiV0fChj4lvfVqFjhZc4S85esrUMEbge+ IQSxzBQsuqrLrL52qOkC8TFBiqVBD5/DW7dl6d2mBpsDzvFDcpkDiPawfMwMWIyRQcW7 XIKl9ObvkRjyXSkoNyQcuT/4H0yPr0Q6mZvnPaKdKv/Zk2tcMxgXtf0aj+3Kw+EM4xFf WMXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=jATA95LsnhYFzxsaTpEfiLLPxPwn/THDoyk5wt0l0nI=; b=FU8gy9K+mpwSl8Bg0doFJFB+KRZLf5CID1MoMd8alGRKMhvCd6zYPJMjg1vPqiGBDJ mrMkWZRgOydnoZA8/RNe62/MWJQPATFmroubHsVMEsMk/51xS8+Z7EhnNSlehmDdCGmC ISDKEw5ta/679ZMDMK+UZ9IDBWon6/bhOILVxEVgoR0nb6nt7qPdYbhRRzo91VKiYwf1 h446/wHCOMboVAVrQ6B/0gmTO+ExfcvDxEDRMAqYfUAGc0hXBuBhqge/Ag4vvBSQnvlg LIHRD0iwHSmO4LXtYdpQN1/7Yigq8Rz+3lekMEhT4JkRQN0MGa5kOB0z2dho69XIO0Cy Qmuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hbOY8G1c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id m9-20020a056a00080900b0050e07e66d5asi1289258pfk.19.2022.06.08.08.59.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 08:59:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hbOY8G1c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D42583CA75; Wed, 8 Jun 2022 08:31:24 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244222AbiFHPPg (ORCPT + 99 others); Wed, 8 Jun 2022 11:15:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244295AbiFHPOX (ORCPT ); Wed, 8 Jun 2022 11:14:23 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF54C12C94C for ; Wed, 8 Jun 2022 08:06:53 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id h62-20020a1c2141000000b0039aa4d054e2so13544076wmh.1 for ; Wed, 08 Jun 2022 08:06:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jATA95LsnhYFzxsaTpEfiLLPxPwn/THDoyk5wt0l0nI=; b=hbOY8G1cNdcNSM2rz9aqfN80nHdpQjF3stZaJaXKZ1lZ6OvH8TqhGf/WurVi4UR7My VVtmf2kO7y8EDorkGEycNEFb/gxL5p1HxdqniF/SCzMt3gGSzLbua7akAAkgGYPjo6RS Cp6Z4xJZMXZnN5UtvWBrqFrUqbgoCdjM6B3rhuQsRqbiQnP1UON3jfG+y54PDv3d/inF oJC+66zFO6/KhCZzWqtSm5CwwdguT2X2//ldNrfFB8QF9odQhhDBFMfjfo5tUqlJI4/4 LrfM4vISzALHDnOqMxB1dLF4Iepfdrfzo4oT/FY0dRbeq2/JWHKoGWWS2CdUYldd7qdn ge1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jATA95LsnhYFzxsaTpEfiLLPxPwn/THDoyk5wt0l0nI=; b=Oc3r8Zo31WKszlZyge63ByWH/6bVYsp3cTEnCJB6WmCgu2K8b/eps3gEHuz6tv97v8 z0vMlq8MLiO74rz1nz7JIdCTRL5HnnpWAoowL0P9HDooi7s3YHVAL3S1nmdzkZNlCydU Qoprkou6M3C2gnCZRZmqFnC4jScMeBlM207C/f28B/ilHqmWMu2KDw2n4ugup8MQLWZu GZUTt1JyaRIA5A9dxJmPiIJVC1raJs7cw7wjqXeH0nLQNQXwVBZxNy+md0H/uEP0mn+z P2mJ5EdHuY1JLDlVF9l3CNCPgTZkL6h+hLGVXD9hkIoKoPfUPRQAl7QBaC24l3Jlp0BT dADQ== X-Gm-Message-State: AOAM531PnBh35DyNKb/FSzvHPX2RHRqDndIbic+HNhO/rfUDJresJgLQ u17lwX5/FUL7AUTPR5C51xSStEH9YKdmHjou X-Received: by 2002:a05:600c:1f05:b0:39c:51c6:7c85 with SMTP id bd5-20020a05600c1f0500b0039c51c67c85mr16583501wmb.33.1654700812170; Wed, 08 Jun 2022 08:06:52 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id f7-20020a1c3807000000b0039c5b9e9142sm5076671wma.17.2022.06.08.08.06.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 08:06:51 -0700 (PDT) Date: Wed, 8 Jun 2022 16:06:50 +0100 From: Daniel Thompson To: Stephen Kitt Cc: "Lee, Chun-Yi" , Hans de Goede , Mark Gross , Cezary Jackiewicz , Henrique de Moraes Holschuh , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] platform/x86: compal-laptop: Use backlight helper Message-ID: <20220608150650.azsobwjurgf34jbm@maple.lan> References: <20220607184635.1127913-1-steve@sk2.org> <20220607184635.1127913-4-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220607184635.1127913-4-steve@sk2.org> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 07, 2022 at 08:46:34PM +0200, Stephen Kitt wrote: > Instead of manually checking the power state in struct > backlight_properties, use backlight_is_blank(). > > Signed-off-by: Stephen Kitt > Cc: Cezary Jackiewicz > Cc: Hans de Goede > Cc: Mark Gross > Cc: platform-driver-x86@vger.kernel.org Reviewed-by: Daniel Thompson Daniel.