Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2680828iof; Wed, 8 Jun 2022 09:47:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxrn2pqjDkO8OWhDrwKknFe5DagDF7O+n77LYFV3SQs8GCfuKVXjDvLi8IOEVXchTNGt//h X-Received: by 2002:a17:902:7085:b0:168:97dc:ddde with SMTP id z5-20020a170902708500b0016897dcdddemr3497064plk.25.1654706842553; Wed, 08 Jun 2022 09:47:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654706842; cv=none; d=google.com; s=arc-20160816; b=A8rUb6TNApEXUD3xPwzDxjsVP9MRIsX7WiBV65qb6p0XaxIjw0SL41fEJmXjccGKHB 1W9vWkPd3FP1Yfu1WBhQ1xNBOxpCXxXDpHYpzsHrK/Ca2dF/P4RLsPxtqIYRS3Kd38u6 mRrUxD6lIUtPXgTVbEQ6pqEObzn2pgxbuNLc+i0B+68kT+eIIs6++hqxdGUL1JJvrbOV IMAHTQTYyWuZtDm2W0HSOwDGpeOS3ONMUeb+j2OaaQu9rAJRyLYMdQEWesGIX+m1+qUf dZtdye8biGLx+4V3Auu5TfZnb4F7bNOmURXqKWkTVyAV1nY17nQvxqFNj5QqNXFA5Nk9 RurQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+yNCEI1M50WCFwTtBdpIGCBslfrVDPiRRt09PxL34Ks=; b=019ggF16ufJjCWSD2Gx9deSbmQ+FUD5p+zgrInvDzKStKUm7jFnQCbLGXxjmbAxr4/ Wd6pwS0m1kIeUNQuyDyMI+PPV+cMzeFjTi0j1MDxHDD6O4+MpbDOKnqCneUOILnDHhE7 oNdeIrLVRT1N3rZIs6B5jgCDG48bWlrPNbBCjBPWIKAWF1xN3Bkg390kMFUz9g/wXahe SmPRZyw71YmNHi3LH8rFbU0pjb8tIH26ZdNEnx+PXl6GytS16rKNFlsctmL3VU3lIYqL A0nhshUiwyhrAFButuObReWPlHdkX+HmIPFX7k48OoolJmlsmC5R4NQtgQEoe6amoh/V NbEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mailerdienst.de header.s=20200217 header.b=MGlNPMSr; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id p9-20020a63f449000000b003fbb0cb276fsi28940654pgk.369.2022.06.08.09.47.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 09:47:22 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@mailerdienst.de header.s=20200217 header.b=MGlNPMSr; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5112D2A24F; Wed, 8 Jun 2022 09:20:51 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245457AbiFHQUe (ORCPT + 99 others); Wed, 8 Jun 2022 12:20:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245359AbiFHQU3 (ORCPT ); Wed, 8 Jun 2022 12:20:29 -0400 Received: from mxout1.routing.net (mxout1.routing.net [IPv6:2a03:2900:1:a::a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF45D40902; Wed, 8 Jun 2022 09:20:26 -0700 (PDT) Received: from mxbox2.masterlogin.de (unknown [192.168.10.89]) by mxout1.routing.net (Postfix) with ESMTP id 0D9A540723; Wed, 8 Jun 2022 16:12:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailerdienst.de; s=20200217; t=1654704731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+yNCEI1M50WCFwTtBdpIGCBslfrVDPiRRt09PxL34Ks=; b=MGlNPMSr/ikza8N8iG35Niw1MJ4Zhxd419d8LEqdGJ1FuFgjrBL+iXSYqk76JJPhxqc5kT +MTeqLq5/JNSywC/QWrixzy7jyL1FnIF09NoHI4jiVUL+JQ94NnPJOC+Jm5kvfxksbPKgC OLJQM1ggc7G9rXwDyNdgxnt6qXKEV+U= Received: from frank-G5.. (fttx-pool-80.245.76.43.bambit.de [80.245.76.43]) by mxbox2.masterlogin.de (Postfix) with ESMTPSA id 333C8100CFB; Wed, 8 Jun 2022 16:12:10 +0000 (UTC) From: Frank Wunderlich To: linux-rockchip@lists.infradead.org Cc: Frank Wunderlich , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Alessandro Zummo , Alexandre Belloni , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, Peter Geis Subject: [PATCH 1/2] rtc: hym8563: try multiple times to init device Date: Wed, 8 Jun 2022 18:11:48 +0200 Message-Id: <20220608161150.58919-2-linux@fw-web.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220608161150.58919-1-linux@fw-web.de> References: <20220608161150.58919-1-linux@fw-web.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mail-ID: 86d1654e-4123-44a3-899d-68cca389b7da X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Geis RTC sometimes does not respond the first time in init. Try multiple times to get a response. Signed-off-by: Peter Geis Signed-off-by: Frank Wunderlich --- drivers/rtc/rtc-hym8563.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c index 90e602e99d03..9adcedaa4613 100644 --- a/drivers/rtc/rtc-hym8563.c +++ b/drivers/rtc/rtc-hym8563.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #define HYM8563_CTL1 0x00 @@ -438,10 +439,16 @@ static irqreturn_t hym8563_irq(int irq, void *dev_id) static int hym8563_init_device(struct i2c_client *client) { - int ret; + int ret, i; /* Clear stop flag if present */ - ret = i2c_smbus_write_byte_data(client, HYM8563_CTL1, 0); + for (i = 0; i < 3; i++) { + ret = i2c_smbus_write_byte_data(client, HYM8563_CTL1, 0); + if (ret == 0) + break; + msleep(20); + } + if (ret < 0) return ret; -- 2.34.1