Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761994AbXEUMrq (ORCPT ); Mon, 21 May 2007 08:47:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758716AbXEUMrg (ORCPT ); Mon, 21 May 2007 08:47:36 -0400 Received: from keetweej.vanheusden.com ([213.84.46.114]:35938 "EHLO keetweej.vanheusden.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755740AbXEUMrf (ORCPT ); Mon, 21 May 2007 08:47:35 -0400 Date: Mon, 21 May 2007 14:47:34 +0200 From: Folkert van Heusden To: Jan Engelhardt Cc: Andrea Righi , Andi Kleen , Stephen Hemminger , Eric Dumazet , Rik van Riel , LKML , linux-mm@kvack.org Subject: Re: signals logged / [RFC] log out-of-virtual-memory events Message-ID: <20070521124734.GB14802@vanheusden.com> References: <464C9D82.60105@redhat.com> <20070520205500.GJ22452@vanheusden.com> <200705202314.57758.ak@suse.de> <46517817.1080208@users.sourceforge.net> <20070521110406.GA14802@vanheusden.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: www.unixexpert.nl X-Chameleon-Return-To: folkert@vanheusden.com X-Xfmail-Return-To: folkert@vanheusden.com X-Phonenumber: +31-6-41278122 X-URL: http://www.vanheusden.com/ X-PGP-KeyID: 1F28D8AE X-GPG-fingerprint: AC89 09CE 41F2 00B4 FCF2 B174 3019 0E8C 1F28 D8AE X-Key: http://pgp.surfnet.nl:11371/pks/lookup?op=get&search=0x1F28D8AE Read-Receipt-To: Reply-By: Tue May 22 12:32:47 CEST 2007 X-Message-Flag: www.unixexpert.nl User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1972 Lines: 57 > >What about the following enhancement: I check with sig_fatal if it would > >kill the process and only then emit a message. So when an application > >takes care itself of handling it nothing is printed. > >+ /* emit some logging for unhandled signals > >+ */ > >+ if (sig_fatal(t, sig)) > Not unhandled_signal()? Can we already use that one in send_signal? As the signal needs to be send first I think before we know if it was handled or not? sig_fatal checks if the handler is set to default - which is it is not taken care of. > >+ { > if (sig_fatal(t, sig)) { > >+ printk(KERN_WARNING "Sig %d send to %d owned by %d.%d (%s)\n", > s/send/sent/; > >+ sig, t -> pid, t -> uid, t -> gid, t -> comm); > t->pid, t->uid, t->gid, t->comm); Description: This patch adds code to the signal-sender making it log a message when an unhandled fatal signal will be delivered. Signed-off by: Folkert van Heusden --- kernel/signal.c.org 2007-05-20 22:47:13.000000000 +0200 +++ kernel/signal.c 2007-05-21 14:46:05.000000000 +0200 @@ -739,6 +739,12 @@ struct sigqueue * q = NULL; int ret = 0; + /* unhandled fatal signals are logged */ + if (sig_fatal(t, sig)) { + printk(KERN_WARNING "Sig %d sent to %d owned by %d.%d (%s)\n", + sig, t->pid, t->uid, t->gid, t->comm); + } + /* * fast-pathed signals for kernel-internal things like SIGSTOP * or SIGKILL. Folkert van Heusden -- MultiTail ? uno flexible tool per seguire di logfiles e effettuazione di commissioni. Feltrare, provedere da colore, merge, 'diff-view', etc. http://www.vanheusden.com/multitail/ ---------------------------------------------------------------------- Phone: +31-6-41278122, PGP-key: 1F28D8AE, www.vanheusden.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/