Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 08 Jun 2022 16:53:49 +0000
To:     Dylan Van Assche <me@dylanvanassche.be>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
From:   Caleb Connolly <caleb@connolly.tech>
Cc:     ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org
Reply-To: Caleb Connolly <caleb@connolly.tech>
Subject: Re: [PATCH] arm64: dts: qcom/sdm845-shift-axolotl: Enable pmi9889 LPG LED
Message-ID: <19c35ce5-d98c-b5b2-893b-d89425693add@connolly.tech>
In-Reply-To: <20220512054439.13971-1-me@dylanvanassche.be>
References: <20220512054439.13971-1-me@dylanvanassche.be>
Feedback-ID: 10753939:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 12/05/2022 06:44, Dylan Van Assche wrote:
> Enables the RGB notification LED on the SHIFT 6mq (sdm845-shift-axolotl)
> with the Qualcomm Light Pulse Generator bindings by Bjorn Andersson [1].
> Patches are merged in for-next branch of linux-leds.
> Tested these changes on the SHIFT 6mq.
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/=
commit/?h=3Dfor-next&id=3Da8e53db46f19f67be6a26488aafb7d10c78e33bd
>
> Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
Tested-by: Caleb Connolly <caleb@connolly.tech>
Reviewed-by: Caleb Connolly <caleb@connolly.tech>
> ---
>   .../boot/dts/qcom/sdm845-shift-axolotl.dts    | 29 +++++++++++++++++++
>   1 file changed, 29 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm=
64/boot/dts/qcom/sdm845-shift-axolotl.dts
> index 847f6217a77b..af412ac2c9d0 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> @@ -2,11 +2,13 @@
>   /*
>    * Copyright (c) 2022, Alexander Martinz <amartinz@shiftphones.com>
>    * Copyright (c) 2022, Caleb Connolly <caleb@connolly.tech>
> + * Copyright (c) 2022, Dylan Van Assche <me@dylanvanassche.be>
>    */
>
>   /dts-v1/;
>
>   #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>   #include "sdm845.dtsi"
>   #include "pm8998.dtsi"
> @@ -554,6 +556,33 @@ &pmi8998_smb2 {
>   =09monitored-battery =3D <&battery>;
>   };
>
> +&pmi8998_lpg {
> +=09status =3D "okay";
> +
> +=09multi-led {
> +=09=09color =3D <LED_COLOR_ID_RGB>;
> +=09=09function =3D LED_FUNCTION_STATUS;
> +
> +=09=09#address-cells =3D <1>;
> +=09=09#size-cells =3D <0>;
> +
> +=09=09led@3 {
> +=09=09=09reg =3D <3>;
> +=09=09=09color =3D <LED_COLOR_ID_BLUE>;
> +=09=09};
> +
> +=09=09led@4 {
> +=09=09=09reg =3D <4>;
> +=09=09=09color =3D <LED_COLOR_ID_GREEN>;
> +=09=09};
> +
> +=09=09led@5 {
> +=09=09=09reg =3D <5>;
> +=09=09=09color =3D <LED_COLOR_ID_RED>;
> +=09=09};
> +=09};
> +};
> +
>   &qup_uart9_default {
>   =09pinconf-rx {
>   =09=09pins =3D "gpio5";
> --
> 2.36.1
>

--
Kind Regards,
Caleb