Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To:     Javier Martinez Canillas <javierm@redhat.com>
Cc:     linux-kernel@vger.kernel.org,
        Lennart Poettering <lennart@poettering.net>,
        Colin Walters <walters@verbum.org>,
        Peter Jones <pjones@redhat.com>,
        Alberto Ruiz <aruiz@redhat.com>,
        Christian Kellner <ckellner@redhat.com>,
        Chung-Chiang Cheng <cccheng@synology.com>,
        Muhammad Usama Anjum <usama.anjum@collabora.com>,
        Alexander Larsson <alexl@redhat.com>
Subject: Re: [PATCH v4 3/4] fat: add renameat2 RENAME_EXCHANGE flag support
References: <20220601173204.1372569-1-javierm@redhat.com>
        <20220601173204.1372569-4-javierm@redhat.com>
        <87h74vteb1.fsf@mail.parknet.co.jp>
        <ddd3eb76-5595-4946-95c2-067d5fbaae99@redhat.com>
Date:   Thu, 09 Jun 2022 02:10:25 +0900
In-Reply-To: <ddd3eb76-5595-4946-95c2-067d5fbaae99@redhat.com> (Javier
        Martinez Canillas's message of "Wed, 8 Jun 2022 18:55:46 +0200")
Message-ID: <87czfjt726.fsf@mail.parknet.co.jp>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Javier Martinez Canillas <javierm@redhat.com> writes:

> On 6/8/22 16:33, OGAWA Hirofumi wrote:
>> Javier Martinez Canillas <javierm@redhat.com> writes:
>> 
>>> +	/* update ".." directory entry info */
>>> +	if (old_dotdot_de) {
>>> +		err = vfat_update_dotdot_de(new_dir, old_inode, old_dotdot_bh,
>>> +					    old_dotdot_de);
>>> +		if (err)
>>> +			goto error_old_dotdot;
>>> +		drop_nlink(old_dir);
>>> +		inc_nlink(new_dir);
>>> +	}
>>> +
>>> +	if (new_dotdot_de) {
>>> +		err = vfat_update_dotdot_de(old_dir, new_inode, new_dotdot_bh,
>>> +					    new_dotdot_de);
>>> +		if (err)
>>> +			goto error_new_dotdot;
>>> +		drop_nlink(new_dir);
>>> +		inc_nlink(old_dir);
>>> +	}
>> 
>> Probably, we should change the nlink only if both of dotdot update are
>> succeed and different file type. Otherwise, we would have to revert the
>> nlink change on error path (and can remove unnecessary update as bonus).
>> 
>
> Agreed. I'll wait a few days before posting v5 in case you have more
> comments on the other patches.

Ok. I have no comment other than this at least for now (reviewed all
patches). If I found more on re-review I will send email.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>