Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <18d9e587-b4f7-6ee7-185a-af0e667e0ec5@redhat.com>
Date:   Wed, 8 Jun 2022 20:21:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v4 3/4] fat: add renameat2 RENAME_EXCHANGE flag support
Content-Language: en-US
To:     OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc:     linux-kernel@vger.kernel.org,
        Lennart Poettering <lennart@poettering.net>,
        Colin Walters <walters@verbum.org>,
        Peter Jones <pjones@redhat.com>,
        Alberto Ruiz <aruiz@redhat.com>,
        Christian Kellner <ckellner@redhat.com>,
        Chung-Chiang Cheng <cccheng@synology.com>,
        Muhammad Usama Anjum <usama.anjum@collabora.com>,
        Alexander Larsson <alexl@redhat.com>
References: <20220601173204.1372569-1-javierm@redhat.com>
 <20220601173204.1372569-4-javierm@redhat.com>
 <87h74vteb1.fsf@mail.parknet.co.jp>
 <ddd3eb76-5595-4946-95c2-067d5fbaae99@redhat.com>
 <87czfjt726.fsf@mail.parknet.co.jp>
From:   Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <87czfjt726.fsf@mail.parknet.co.jp>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/8/22 19:10, OGAWA Hirofumi wrote:
> Javier Martinez Canillas <javierm@redhat.com> writes:
> 

[snip]

>>> Probably, we should change the nlink only if both of dotdot update are
>>> succeed and different file type. Otherwise, we would have to revert the
>>> nlink change on error path (and can remove unnecessary update as bonus).
>>>
>>
>> Agreed. I'll wait a few days before posting v5 in case you have more
>> comments on the other patches.
> 
> Ok. I have no comment other than this at least for now (reviewed all
> patches). If I found more on re-review I will send email.
>

Perfect, thanks! If you reviewed all the patches already then I'll send
the v6 tomorrow.

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat