Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2788538iof;
        Wed, 8 Jun 2022 12:03:20 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJynarLM9F0rSbnttUR8mgamMys29Wn9NeEwKmD0lRlSE2nF5pTTdWD/oK6h24NIZRWoDYY6
X-Received: by 2002:a05:6402:35ce:b0:430:cbae:d8d with SMTP id z14-20020a05640235ce00b00430cbae0d8dmr27480509edc.369.1654715000415;
        Wed, 08 Jun 2022 12:03:20 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1654715000; cv=none;
        d=google.com; s=arc-20160816;
        b=c7b5LVzmZm3Eolm1t+NYrxubXl+EVlqFhs3DojMVtQ+0SB2X8s0m53R/zR3GJ7skab
         uIFruB6JSzhgS2u7l+EbJb51r78xH9jRqkmBitf5zOhN68jkOlljVeZjxo3sHVX8Bww6
         OqQwW/GtFIUGGXvJ9afWv9iM0vYYT2uvMJbg2ZwpDgmXnHKH4LpoMWySfhgVGXGu47pP
         /RhIpS7qlvXw6qHHNMI28b0tBRpCFqj/tGA45gkoj3ahG7QlJ0/5nRSxe9ZB2BLCf/Mw
         sRUw7wmIf79MpfGEdM79sN223CQ/4dT92NQoXO2tRRX4ZDKdgtTymsb6Gh6xUww8c8eS
         ZoOw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :message-id:subject:cc:to:from:date:dkim-signature;
        bh=SwPSLDvIpaBFTC42BN5FHKoOY7nC8eOAKohqfaSmTA8=;
        b=CSTPEgTe2zFzOfm8NamT1ZL8UxoZTVI9jdkVrqidV0womB5CP9UZKnhkHIOEBNeEnl
         NNG/lQX54SEGjVZYFCWb1eiihRs8cEmKloH4gdOLl7IgByHR6llpCEcGtJNJRGn7DOzK
         M3k7dp41ZDTzrZoOmVD8EcGpjsAGjIZaOTFxjMKg9UCfce7EjACJZqHxzqqvHzou8UJt
         BZ5AlVwKNYsCTfAiA2VctsiP3+UZMLRXJrpRox1vZhgIwYinGz0RRgHLS/sTqpBns4o9
         sMTwZOeYIeozQ+76jC6UEb8d2kjT94Bq+oWagDAxZj82YuxR5+v16LQbyuSAoHNi0up2
         iO4g==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nk2FUfxE;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id q25-20020a50c359000000b0042dd1a265easi1819361edb.362.2022.06.08.12.02.52;
        Wed, 08 Jun 2022 12:03:20 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nk2FUfxE;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232753AbiFHSy7 (ORCPT <rfc822;acleo0523@gmail.com> + 99 others);
        Wed, 8 Jun 2022 14:54:59 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49816 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229752AbiFHSy5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 8 Jun 2022 14:54:57 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BDAC1216E2;
        Wed,  8 Jun 2022 11:54:57 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id DBE4261BFD;
        Wed,  8 Jun 2022 18:54:56 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCE74C34116;
        Wed,  8 Jun 2022 18:54:55 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1654714496;
        bh=4DkBSx4PBlnqbuIvbhb4BY8MQw6NCv8/SsM4J3UI200=;
        h=Date:From:To:Cc:Subject:In-Reply-To:From;
        b=nk2FUfxEP+uq3OPC6Dt0OjmJBwVFkRhSYXWUqZCTKRS1QEn7Oj6wz15yH1dfa+Um8
         /QxZ8R3hevC4EyX8LfK/sKFeav+F0Efn0n551rE6G+cqrq1Q4wPtS58Ih15LTaRy89
         FNxo3h2Nby46ARYYtazJVL+UIiR9LprPxwmS7SzyIFwhG9L07Z515sqVoaALr9pc/W
         CGGFIou/eiDJgdZcIvisYj8xTAXySksWdIckimvcK2obq1i6xDi+SqkXnafvtdCmzm
         GfQ2WsLCjxdImBQV4T6cqOXqdvkrXPnQwt6XbUDJXlrYqOX/bLEDfTdlxwWlYxMs3e
         dWBrpCBCWH0PQ==
Date:   Wed, 8 Jun 2022 13:54:53 -0500
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Richard Zhu <hongxing.zhu@nxp.com>
Cc:     l.stach@pengutronix.de, bhelgaas@google.com, robh+dt@kernel.org,
        broonie@kernel.org, lorenzo.pieralisi@arm.com,
        jingoohan1@gmail.com, festevam@gmail.com,
        francesco.dolcini@toradex.com, linux-pci@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de, linux-imx@nxp.com
Subject: Re: [PATCH v9 5/8] PCI: imx6: Refine the regulator usage
Message-ID: <20220608185453.GA410841@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1651801629-30223-6-git-send-email-hongxing.zhu@nxp.com>
X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 06, 2022 at 09:47:06AM +0800, Richard Zhu wrote:
> The driver should undo any enables it did itself. The regulator disable
> shouldn't be basing decisions on regulator_is_enabled().
> 
> To keep the balance of the regulator usage counter, disable the regulator
> just behind of imx6_pcie_assert_core_reset() in resume and shutdown.

In subject, "Refine" doesn't tell me anything about what's happening
here.