Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 8 Jun 2022 13:57:54 -0500
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Richard Zhu <hongxing.zhu@nxp.com>
Cc:     l.stach@pengutronix.de, bhelgaas@google.com, robh+dt@kernel.org,
        broonie@kernel.org, lorenzo.pieralisi@arm.com,
        jingoohan1@gmail.com, festevam@gmail.com,
        francesco.dolcini@toradex.com, linux-pci@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de, linux-imx@nxp.com
Subject: Re: [PATCH v9 7/8] PCI: imx6: Move the phy driver callbacks to the
 proper places
Message-ID: <20220608185754.GA411026@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1651801629-30223-8-git-send-email-hongxing.zhu@nxp.com>
Precedence: bulk

On Fri, May 06, 2022 at 09:47:08AM +0800, Richard Zhu wrote:
> To make it more reasonable, move the phy_power_on/phy_init callbacks to
> the proper places.
> - move the phy_power_on() out of imx6_pcie_clk_enable().
> - move the phy_init() out of imx6_pcie_deassert_core_reset().

I'm not sure what "make it more reasonable" is telling me.  In subject
line and commit log, please say something more specific than "the
proper places."  

It's probably more important to say where they are moving *to* than
where they're moving *out of*.

> In order to save power consumption, turn off the clocks and regulators when
> the imx6_pcie_host_init() return error.

Is the power savings the *reason* for this change?  I can't tell from
the commit log.