Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20220606202109.1306034-1-ankur.a.arora@oracle.com>
 <CAHk-=wh89D_69JZtB0MNKbrTM4dPJisK6E0yFKH-hA++F13mzw@mail.gmail.com>
 <87k09s1pgo.fsf@oracle.com>
 <CAHk-=wj9En-BC4t7J9xFZOws5ShwaR9yor7FxHZr8CTVyEP_+Q@mail.gmail.com>
 <877d5rt0uz.fsf@oracle.com>
 <CAHk-=wgGjmCwyrs4Druy26rUddoWj29PjAKRZD=q0pzfVNioDg@mail.gmail.com>
User-agent: mu4e 1.4.10; emacs 27.2
From:   Ankur Arora <ankur.a.arora@oracle.com>
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Ankur Arora <ankur.a.arora@oracle.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux-MM <linux-mm@kvack.org>,
        the arch/x86 maintainers <x86@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Ingo Molnar <mingo@kernel.org>,
        Andrew Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Borislav Petkov <bp@alien8.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Andi Kleen <ak@linux.intel.com>, Arnd Bergmann <arnd@arndb.de>,
        Jason Gunthorpe <jgg@nvidia.com>, jon.grimm@amd.com,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Joao Martins <joao.m.martins@oracle.com>
Subject: Re: [PATCH v3 00/21] huge page clearing optimizations
In-reply-to: <CAHk-=wgGjmCwyrs4Druy26rUddoWj29PjAKRZD=q0pzfVNioDg@mail.gmail.com>
Date:   Thu, 09 Jun 2022 01:51:45 +0530
Message-ID: <87zgimsy7a.fsf@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ONm/J1cLfgACQBaK/oVvFKPoZI30CJ8tdhVqZL7349xmFtmCZJbY/yQ5Q7ih?=
 =?us-ascii?Q?sPfQzaULn0htWBptb79Wri3FKa1r77XV7JL5fy8Xg+moxbI7GcVC+1bCs59S?=
 =?us-ascii?Q?8B35J89Etb4xiu+d46H0pTkxHuqCX8CoJK0bhV41dUXAEpbAZELLn9tbNAQv?=
 =?us-ascii?Q?lzTpyxRpGbNSgKtAptElH9fE8Pt2X4MXO9crbGAndSzF1T9QPxDWs6ymXSRf?=
 =?us-ascii?Q?JXJA8Nn/ntOXEUgJ+4zLB6FwRPshxd6yAH6YMbE7wWjpLW+i8sfgnhP2QNJo?=
 =?us-ascii?Q?H58vhF7CuVJcPJbxZlTdM8Sg5N4c8gKFZz3Hj9qKLylvbq2zkTWdZxrksW7T?=
 =?us-ascii?Q?UEh0rHQEx/H5DwzFKiPOIfZThMe/GZdD28/rr0OiSEIlneoi3PQWEnVG/de/?=
 =?us-ascii?Q?7UOds0MLOx6CCkaRgf72W/m8kvQepoyg5yes9o3e7MN1kJZ7Dt/xKengEuTj?=
 =?us-ascii?Q?n5pYSIQa5773dgJkFgV3UuepjNaOogFYtOiG9vuu/G46ZyfZAc/q36Ita5kP?=
 =?us-ascii?Q?lRSvp0dJa7UXiRx1WMb9hClbL7dd5O4HOVmM4ttQSizXg2QXrWvJ7/PyiPVe?=
 =?us-ascii?Q?jSn9n0bUf0dov1uo7GH2Y3sSKH28LDkoOlAljcPMHandEUitnN+wZcvbFIib?=
 =?us-ascii?Q?JabJuGozCcujtQvDSeIDbICf6W0fnUH+Oa1Lc7PjrvW/kpAwBIq5WBoAvNmO?=
 =?us-ascii?Q?972makcSOkDZVbSMpOVKiI4XS7TKM8YPT4UEPJ1rJ7TdqoT4hloKwBU/z0/H?=
 =?us-ascii?Q?YJpNPd+vxUyCzlUH/DgzII8K62iw6P5xzKWTZX4jhbsL2CnKyrq+IoF32Byo?=
 =?us-ascii?Q?7gj/j9PuV+o0K18aO9stEeZXmWsU6Uf41Y33XGOIEx5Os05sFKywwoqQ/CvK?=
 =?us-ascii?Q?jF8IyM3fqsAwhLgKdQWxSXeK8PquCzmz4wvSG4ChiDXPIaZaC0gy6xvB5nD9?=
 =?us-ascii?Q?hM97zaw7nnPK4BRiLZj9aB6IH3rRpONqdGCkwe5Cqt7aXR6ekk32WlSyc3xA?=
 =?us-ascii?Q?mwQYULhpJnEqcrDO9mwu+2SrPS1m0cVFy0LsDZ1OCtxkUSyqMcdly1QtfL/a?=
 =?us-ascii?Q?l9IOJe43tmE6temTLrdKxRZbTAW1uLiR4VInRj72vYH0J7DYoGZaGpqWi1hN?=
 =?us-ascii?Q?URsl81C81am/+Tx+5N9QIm9iAiqI2kB2PHAmWE272Rwtg0441Gd8z3D4UThE?=
 =?us-ascii?Q?R+h9PBqYdjLFgICoEeykU+rT1z0NHMFyj8iX1LCgEDhLgK7qcZgNBwGVGp8R?=
 =?us-ascii?Q?Vvd0pvfbTH/0xShXMfemGNBcsxOIDO6pP/qtXoINO/JVGi2hcT0a55y6AgDU?=
 =?us-ascii?Q?X7mpJcwO1U+vv4T+RAqPlkg06fqySdMnF732Z2mJJjoEZ6No6QqB5GZ/a0Jn?=
 =?us-ascii?Q?XJL8S0y/o7mDYwOnNHgtm8sC+P796CoIm2M4429qAxuB+DsuTjy6CKyxSgHJ?=
 =?us-ascii?Q?jt1mb+9ixs5TaEkGcCi2Fo/W4J5xGkdYr4YIBrWtSUt4PZme1UilptnxYb8K?=
 =?us-ascii?Q?gszcFurrs5oq6vgxv2m2MBqCH34LqPeGbJH1EakHrO/xvc5UUDCk6NM9WCMx?=
 =?us-ascii?Q?/0D0g96+dBuhknW0POjH6E8t77JSwftO8YGbjKtjouknT6Dpuorg1xbqJprO?=
 =?us-ascii?Q?iTCtaZFmqHUzrYgyYNFkdhrRE7vQLPyqWae6VuxFtJlW+DBzWDa5z/HgPjso?=
 =?us-ascii?Q?Q6b9FjV+lHEuoaFO3RHiKU3xMa38LUPxDDEaMDiko7F4CkzUi2P5aVP3/iwH?=
 =?us-ascii?Q?QG+iFwww/19uGeXbJL9BWnM9GOg0BkQArhYFFq0ikS2PqGxY/AYkKs5tj12a?=
X-MS-Exchange-AntiSpam-MessageData-1: o84m+SCofkA2XMlDQPyWoSoohgDRnHjB9+4=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d337f4ab-384e-40e1-0e5d-08da498c8696
X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5409.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2022 20:21:53.2325
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MuwCFkOUHVu0FsDW494KgeyvwfDmP7lhXQZXT4LVCu3a/bb6neB7eTiKTfr1XgYwhBYZ1B7GjEUorkB1kE7EFKRlcTI8B2qJD3vQw7384d8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB2980
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-08_04:2022-06-07,2022-06-08 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 adultscore=0 bulkscore=0 mlxscore=0 suspectscore=0 malwarescore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206080077
X-Proofpoint-GUID: aBGo82EPoGJj4RfGJ4IXJtqirOjAUdjq
X-Proofpoint-ORIG-GUID: aBGo82EPoGJj4RfGJ4IXJtqirOjAUdjq
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Linus Torvalds <torvalds@linux-foundation.org> writes:

> On Wed, Jun 8, 2022 at 12:25 PM Ankur Arora <ankur.a.arora@oracle.com> wrote:
>>
>> But, even on x86, AFAICT gigantic pages could straddle MAX_SECTION_BITS?
>> An arch specific clear_huge_page() code could, however handle 1GB pages
>> via some kind of static loop around (30 - MAX_SECTION_BITS).
>
> Even if gigantic pages straddle that area, it simply shouldn't matter.
>
> The only reason that MAX_SECTION_BITS matters is for the 'struct page *' lookup.
>
> And the only reason for *that* is because of HIGHMEM.
>
> So it's all entirely silly and pointless on any sane architecture, I think.
>
>> We'll need a preemption point there for CONFIG_PREEMPT_VOLUNTARY
>> as well, right?
>
> Ahh, yes.  I should have looked at the code, and not just gone by my
> "PREEMPT_NONE vs PREEMPT" thing that entirely forgot about how we
> split that up.
>
>> Just one minor point -- seems to me that the choice of nontemporal or
>> temporal might have to be based on a hint to clear_huge_page().
>
> Quite possibly. But I'd prefer that  as a separate "look, this
> improves numbers by X%" thing from the whole "let's make the
> clear_huge_page() interface at least sane".

Makes sense to me.

--
ankur