Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5504ae89-befc-9db0-0cc5-6f425d5414be@novek.ru>
Date:   Wed, 8 Jun 2022 22:37:54 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH net-next v1 1/5] ptp_ocp: use dev_err_probe()
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Jonathan Lemon <jonathan.lemon@gmail.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Richard Cochran <richardcochran@gmail.com>
References: <20220608120358.81147-1-andriy.shevchenko@linux.intel.com>
 <20220608120358.81147-2-andriy.shevchenko@linux.intel.com>
From:   Vadim Fedorenko <vfedorenko@novek.ru>
In-Reply-To: <20220608120358.81147-2-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08.06.2022 13:03, Andy Shevchenko wrote:
> Simplify the error path in ->probe() and unify message format a bit
> by using dev_err_probe().
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

LGTM

Acked-by: Vadim Fedorenko <vfedorenko@novek.ru>
> ---
>   drivers/ptp/ptp_ocp.c | 13 +++++--------
>   1 file changed, 5 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index 4519ef42b458..17930762fde9 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -3722,14 +3722,12 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>   	int err;
>   
>   	devlink = devlink_alloc(&ptp_ocp_devlink_ops, sizeof(*bp), &pdev->dev);
> -	if (!devlink) {
> -		dev_err(&pdev->dev, "devlink_alloc failed\n");
> -		return -ENOMEM;
> -	}
> +	if (!devlink)
> +		return dev_err_probe(&pdev->dev, -ENOMEM, "devlink_alloc failed\n");
>   
>   	err = pci_enable_device(pdev);
>   	if (err) {
> -		dev_err(&pdev->dev, "pci_enable_device\n");
> +		dev_err_probe(&pdev->dev, err, "pci_enable_device\n");
>   		goto out_free;
>   	}
>   
> @@ -3745,7 +3743,7 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>   	 */
>   	err = pci_alloc_irq_vectors(pdev, 1, 17, PCI_IRQ_MSI | PCI_IRQ_MSIX);
>   	if (err < 0) {
> -		dev_err(&pdev->dev, "alloc_irq_vectors err: %d\n", err);
> +		dev_err_probe(&pdev->dev, err, "alloc_irq_vectors\n");
>   		goto out;
>   	}
>   	bp->n_irqs = err;
> @@ -3757,8 +3755,7 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>   
>   	bp->ptp = ptp_clock_register(&bp->ptp_info, &pdev->dev);
>   	if (IS_ERR(bp->ptp)) {
> -		err = PTR_ERR(bp->ptp);
> -		dev_err(&pdev->dev, "ptp_clock_register: %d\n", err);
> +		err = dev_err_probe(&pdev->dev, PTR_ERR(bp->ptp), "ptp_clock_register\n");
>   		bp->ptp = NULL;
>   		goto out;
>   	}