Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp79174iof; Wed, 8 Jun 2022 15:45:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXzweEr6rgEm+bXxx0kfv+sjQD30ImHYwwyM2oCfL6bXl1TUa1ksXUcC7dw8+mPdiiDnaY X-Received: by 2002:a17:906:1dcf:b0:711:f0df:b903 with SMTP id v15-20020a1709061dcf00b00711f0dfb903mr6390092ejh.267.1654728325384; Wed, 08 Jun 2022 15:45:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654728325; cv=none; d=google.com; s=arc-20160816; b=K9kVQ3lHzgAkng0H/Cc3CkNSaGtxXj5Qq4YsbFyVXKnH9bcpib3rOosL8InXY96DyV CYIr3VbeSt/Ohxoe0Ngde/EkdszJEpKaIT7mLItG/pm5wEt1l1bonZRj4clC4jxqTElW A3RPXfe2893GjhctDZXIFXBSCioe6okj3QzmwOImP4iL8YCgpZGPgnbZmXWQrP/0poWh NkKXmacE2f/R0yLmO5ksaobziqIGTOrn7qr7oT30fwZm0wciwSVpWBakKrKMkp74SafF OOMCE2bGefljT+IW52bPuqoR7PEfclAKZVig+HqmscL0c8BhF+asUmOtb/rspR4ThMl1 Q1fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=+L8UJ7sASMKpB38Mnn3kWcn/itZQSXejvt9krjCGrMU=; b=VyHeDkdDhEsjdeKk5Sveo+ZqTlRBsUxomfpP2qr26Cfwdq6LPYt2+SatpId0KFb2Lx QO/RgcrAENQ4ioxNoQYF3EGJgRwzxQhPH1jP2ek0ImfktaEpkSZB5KM8qOG8nnTFiQkh k+3/sSlXNEzBad/qvz6l8eo9tbJXq7Baj9NtZsn4U5/XopPnXCMb8HNO57K6+l+xy/gf lKP8/q4kE6w8TPYlCvJnyePrUC3Ium3KiH3my7W5vxMW+ZrfQ7pOrMJWNMSq6gUTTjw4 zYOvokesiXNtqW/JtbQ0bQXWwRDYutLm6fI9Fb8Pr7UwqIboZl27Odcvq4CGq06N9//3 mbKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dt16-20020a170907729000b0070b645c8cedsi1860273ejc.580.2022.06.08.15.45.00; Wed, 08 Jun 2022 15:45:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232753AbiFHW1c (ORCPT + 99 others); Wed, 8 Jun 2022 18:27:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231161AbiFHW11 (ORCPT ); Wed, 8 Jun 2022 18:27:27 -0400 X-Greylist: delayed 399 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 08 Jun 2022 15:27:26 PDT Received: from smtp7.emailarray.com (smtp7.emailarray.com [65.39.216.66]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1746044754 for ; Wed, 8 Jun 2022 15:27:25 -0700 (PDT) Received: (qmail 87584 invoked by uid 89); 8 Jun 2022 22:20:43 -0000 Received: from unknown (HELO localhost) (amxlbW9uQGZsdWdzdmFtcC5jb21AMTYzLjExNC4xMzIuNw==) (POLARISLOCAL) by smtp7.emailarray.com with SMTP; 8 Jun 2022 22:20:43 -0000 Date: Wed, 8 Jun 2022 15:20:41 -0700 From: Jonathan Lemon To: Andy Shevchenko Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Cochran Subject: Re: [PATCH net-next v1 1/5] ptp_ocp: use dev_err_probe() Message-ID: <20220608222041.a63mn2g4m4l572nq@bsd-mbp.dhcp.thefacebook.com> References: <20220608120358.81147-1-andriy.shevchenko@linux.intel.com> <20220608120358.81147-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220608120358.81147-2-andriy.shevchenko@linux.intel.com> X-Spam-Status: No, score=0.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FORGED_GMAIL_RCVD,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED,SPF_HELO_NONE, SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 08, 2022 at 03:03:54PM +0300, Andy Shevchenko wrote: > Simplify the error path in ->probe() and unify message format a bit > by using dev_err_probe(). Line length. -- Jonathan