Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp80999iof; Wed, 8 Jun 2022 15:48:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyvKU2u02VE3L9oZNAl0hqlIUsmbpd48wtY2P9F0PgnZff3IjKGXvzf3u5q41vPyuHTbVoi X-Received: by 2002:a17:907:90c8:b0:711:c8e1:7109 with SMTP id gk8-20020a17090790c800b00711c8e17109mr18466021ejb.492.1654728515837; Wed, 08 Jun 2022 15:48:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654728515; cv=none; d=google.com; s=arc-20160816; b=T8OXgfqytwsEQWcFqxkHBk4RnTyDdrn8i566+BUSYsn7GgR/uCRLVWZe3+kxY1lj/w gX5hzKH0gU7gBI2Sukd12Q+63eiOt5tIvoGPiZxMOcBjtQg8E+KprYha+9PQOfDaQOqO WxKeF7HwgwlVNBkA23gX7KvRfEoGuITvVvluHVVNEsXDjQe3pwWFWWkdHvyd9M4DNtu+ NfKV0hyYRV888qmrHrRuDqi9PUsxwPws5C56L1oVcgH1opqsQKgupWd1oSYVBgtxY/fL 5GoVwQERMtvQU00xK2IM0Ro0QwefDICEaKmPVG0Ln44fDsd5pM0+fPHN8hNGeOMo5RHZ CSKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:subject:message-id:date:user-agent:from :references:in-reply-to:mime-version:dkim-signature; bh=4+3RQXUOPtCpLvkD/U0erPbjIdgGtkmXEv+DgUOZHBk=; b=MsskaKbcxiMTTKSQHZjvDHK4lX88LC1B9MmXVXqM09H3Gxb1u/fzSz09gjZfPUvAQc 4jP6RMDTyOihegz51+awDRtS4Ybf9KYFk4HtS4p+wj/o/wfrES+4BBQ3cjPELdGXY3hE cJVna+Z13M+k5Pm8eH87kEKFZl4J6px2+OVulCmIn0r9yODc40sS4HmL83dYMF+HLXGC +PuoSVYbDFRiZl0t3G/DxWenDZSXBrt654pqUAXKpVaRqa3pfocNHKWIIyjn0mYxTEA/ dF00uPw2MLSq4slWiV7p9L2sXoRoYJgqUlTpFp31IC8T/NvDCgIIsvmzQWlnpFegGLfR aldg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=kD5nxNFk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id du18-20020a17090772d200b006f379d6f423si4912248ejc.582.2022.06.08.15.48.08; Wed, 08 Jun 2022 15:48:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=kD5nxNFk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235386AbiFHWPA (ORCPT + 99 others); Wed, 8 Jun 2022 18:15:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236508AbiFHWO5 (ORCPT ); Wed, 8 Jun 2022 18:14:57 -0400 Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A39E313B1 for ; Wed, 8 Jun 2022 15:14:55 -0700 (PDT) Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-fe15832ce5so3286804fac.8 for ; Wed, 08 Jun 2022 15:14:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to; bh=4+3RQXUOPtCpLvkD/U0erPbjIdgGtkmXEv+DgUOZHBk=; b=kD5nxNFk80W+73EVv5maekxoUggnhB7L4tjOpUL4RRMV5c6rh/qT1Rt1SrPD6LfQi+ Spbena1c1XCLUDtW8Sh5BOJhqkJRyiGnBFMLU3M2EgtcdLie4f4a7td17XlNsz7/RUnl PfqlebSOrrHdXbIIVyL4gF+Qo070/pnIZmwd4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to; bh=4+3RQXUOPtCpLvkD/U0erPbjIdgGtkmXEv+DgUOZHBk=; b=ZuKL8iZH874XB/9T7Xzj/DoNSrzaKFScx+4r6B5AnC3ws8mLqbz5qZiwxUvUzd7MNK BrAuw1S+c4B3jObYl4iwknYc7bV+qvPKzABxJmwX5UPYiCOH9Zp7DPHXuWvCftHJKLGe woaYnV07/jPbmOGAb+y63PB0g3oaXV4eiWvO1dwZdYgGAYrwbaHILncXOWG9+Rm43jdt mKd52UBa5EX3fl2BVz4cVS/RC2/kdzQlCNfcovoVzKb2dJ7Uoh0PqspZJHtsGptYr0fP 8G5ma4r7h+2Ku0Bx4Y7LtPupagxu88pKGQv1hUZTSLT2wzgfHMfI7lPvh43gCwFGx5kp +cxA== X-Gm-Message-State: AOAM530yYI/+2qjsJWC5X79p3SSRsYDhTp6+peD/AvHnSL8BFL528VaA LKUKimAFJv5d+r15lycse6pMDU0BcjmeDEEx2k5Kog== X-Received: by 2002:a05:6870:b381:b0:fe:2004:b3b5 with SMTP id w1-20020a056870b38100b000fe2004b3b5mr85785oap.63.1654726494871; Wed, 08 Jun 2022 15:14:54 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 8 Jun 2022 15:14:54 -0700 MIME-Version: 1.0 In-Reply-To: <20220607110841.53889-1-linmq006@gmail.com> References: <20220607110841.53889-1-linmq006@gmail.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Wed, 8 Jun 2022 15:14:54 -0700 Message-ID: Subject: Re: [PATCH] drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf To: Abhinav Kumar , Daniel Vetter , David Airlie , David Heidelberg , Dmitry Baryshkov , Guo Zhengkui , Miaoqian Lin , Neil Armstrong , Rob Clark , Rob Herring , Sean Paul , Xu Wang , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Miaoqian Lin (2022-06-07 04:08:38) > of_graph_get_remote_node() returns remote device node pointer with > refcount incremented, we should use of_node_put() on it > when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: 86418f90a4c1 ("drm: convert drivers to use of_graph_get_remote_node") > Signed-off-by: Miaoqian Lin > --- Reviewed-by: Stephen Boyd