Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 8 Jun 2022 16:07:12 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Ben Widawsky <bwidawsk@kernel.org>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        <linux-pci@vger.kernel.org>
Subject: Re: [PATCH V10 8/9] cxl/port: Retry reading CDAT on failure
Message-ID: <YqEroOuHpEa2GkHA@iweiny-desk3>
References: <20220605005049.2155874-1-ira.weiny@intel.com>
 <20220605005049.2155874-9-ira.weiny@intel.com>
 <20220606185203.ntm3yf73kf4u2o7a@bwidawsk-mobl5>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220606185203.ntm3yf73kf4u2o7a@bwidawsk-mobl5>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GDyQRXmiDcQESxJP76QEpfH8BoB+qLwSOf7Qi3uE2g4p1f33dV/EMQcT+RcG?=
 =?us-ascii?Q?xrZ3lyLQn6QnQPEV+0UZa+Hv1Qu756bJ4NCu3X7LdJq9FSfK7s6l6lL1S7Nf?=
 =?us-ascii?Q?me0NixtrBVOWUk6RF8IUnjp2EHVXHwk879vAs4tBT08FA10FBTVl4LjA0Kyo?=
 =?us-ascii?Q?pj6XUkCIAf82gFgVbo9lFJ49u7P+Hbl86pCuylO+hmsh259NEs2csitn4oj9?=
 =?us-ascii?Q?KuP49MtVufMUvm7YMgl7rOzBGFUQxV/ClFiyfj8SO8AkkfP5FOYiwix0g/X5?=
 =?us-ascii?Q?Jy75V4lEWL3MyGuJIOcvSpMS2TZXGcYwDxcOgoAPB82WsBSVUfa8KCMNkC/R?=
 =?us-ascii?Q?ZZUEhEHT8z1nceo2u82KkAuoaK2kPNIXBQvdAENMdLwMBVwkbxH1lbwCei0n?=
 =?us-ascii?Q?GUl6T2QEAJi+FWVJPuloobR5sh4r6FGmbHGvh4zwo9tmg/a7Zmh7wqLjoRjz?=
 =?us-ascii?Q?jH+8JnPZalVzPA/QxuM5uFHKRXt70rrREdCcjbd60rJyg3sv+zwafOvczc4i?=
 =?us-ascii?Q?P2XXbbsYZRBeUe4Sg16FFacsUdwGiwzC5PcOkjKWaWU+EoKjIKleaAOybuJx?=
 =?us-ascii?Q?WzHMu2BTz66EdHTCm4EbtysmH1q8UqQUbvLRKPsTKbp9QtGjPgNelMq/5m1Y?=
 =?us-ascii?Q?h+ByewOiLmaU8k/AZJOtKtaaU2OVnmoM3FXOYMeelVBqQmX6d8W8Ez3k56qT?=
 =?us-ascii?Q?V7q86Np6hRH7tFC6RCz354q4orNH1b0qpfPKRyZ9dkNBq38gYu57m5Gx1TNl?=
 =?us-ascii?Q?G3c7NPYvc92IcDLNPt6kaR/G2tkUbnqEfxxrFgukt4DEKtxLGLy84UxhDEsq?=
 =?us-ascii?Q?UvbZkwYRfkimCE3mJF7NZdocfZepOQ6mpchvCLBY6KGHRClH3E704R4N1DZv?=
 =?us-ascii?Q?HF45UBtYTxv1tqSUfyY0cRoAWhuGM9AAnYvQEZbgdiKM7tnc0YbtKZy7BAYl?=
 =?us-ascii?Q?mR0aqRjYEUEjHxAao/nFqrFI9vblDlezvXRuSGjunN7+m6xekhysNHPAP3Hi?=
 =?us-ascii?Q?+hFYB6Gguoo1lBexuEB27Hrkirc0OA2OhgixNYK9cNq4+IwkpKxSRl4GHbS1?=
 =?us-ascii?Q?bz4GoG1L78ku8UUIOJw6SPxheYvy1g8bmd48AXsD0m0Cw8MyDKPJ7CX9cB6u?=
 =?us-ascii?Q?K0r5UtFvq8q7UsruACY/Xb48lNdkuUL8XUkLVeQz5metX57/nqn4kc+bYPXd?=
 =?us-ascii?Q?tDF/KJ6979sFf9D4CCiQF0eFqdW9fVgtjXd+9bHY/fxVViua+26zVpcZbu1+?=
 =?us-ascii?Q?TGA6jmr9YpZKQAiRmBN7s+e4d78vBNTQchbDuz5EwzdhchJLfEoX5EC3gYiO?=
 =?us-ascii?Q?tf4nryXOxMCsWas/849PUBhQ22nfsbAnXpXENM4wV8O4FJjGihM7/T6g0ii0?=
 =?us-ascii?Q?92Wo65X476H9rlHs7rNDrZkS4elb+Ot4IPR+9/v3JjWu4caVIuzTJhCYybJj?=
 =?us-ascii?Q?EjGTY9wF6qfb6/W3cx2mWa67Yg/IZE00xGgtRFC3m6hjCC8CG2sAoePCTPiC?=
 =?us-ascii?Q?zmLmSmFPAdI5aV/7XpfNTVlIDwmGZHmSw0aLNAQUDgJsqtjJxUTUm5bO0TvB?=
 =?us-ascii?Q?MrZVsh1Nb/XW6Z+iktj4f1KurYN/FxuZpMAZ3ftETAfbIkuiVcTy7Fsy5H8D?=
 =?us-ascii?Q?XRhxgshI7dht6fMTJHGgOfoVzOpaTpCWEsGmDyvEj21d4zGOw2RwLQHqylEx?=
 =?us-ascii?Q?0cutt3LHakx8acUbJplgrXka3OXltXrUmE555Bl2lfxgubIMSr4EpwgpLLbn?=
 =?us-ascii?Q?fRpQfo2zzw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b0801aee-295e-41c8-7e5a-08da49a3a200
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2022 23:07:17.3869
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /d51n9S8f8WE3GhuuuWeCzxmz2AGaFPkgEwkk5ackcfbcdkSuAdoAXdWnAAVfrsTAdEAw7PDE3Q7vyQC4wjTFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6493
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 06, 2022 at 11:52:03AM -0700, Ben Widawsky wrote:
> On 22-06-04 17:50:48, ira.weiny@intel.com wrote:
> > From: Ira Weiny <ira.weiny@intel.com>
> > 
> > The CDAT read may fail for a number of reasons but mainly it is possible
> > to get different parts of a valid state.  The checksum in the CDAT table
> > protects against this.
> > 
> > Now that the cdat data is validated issue a retries if the CDAT read
> s/validated issue a retries/validated, issue a retry/

Thanks!

> > fails.  For now 5 retries are implemented.
> > 
> > Cc: Alison Schofield <alison.schofield@intel.com>
> > Cc: Davidlohr Bueso <dave@stgolabs.net>
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> > 
> > ---
> > Changes from V9
> > 	Alison Schofield/Davidlohr Bueso
> > 		Print debug on each iteration and error only after failure
> > 
> > Changes from V8
> > 	Move code to cxl/core/pci.c
> > 
> > Changes from V6
> > 	Move to pci.c
> > 	Fix retries count
> > 	Change to 5 retries
> > 
> > Changes from V5:
> > 	New patch -- easy to push off or drop.
> > ---
> >  drivers/cxl/core/pci.c | 34 +++++++++++++++++++++++-----------
> >  1 file changed, 23 insertions(+), 11 deletions(-)
> > 
> > diff --git a/drivers/cxl/core/pci.c b/drivers/cxl/core/pci.c
> > index 73e28b82ffcf..e68f13e66fcf 100644
> > --- a/drivers/cxl/core/pci.c
> > +++ b/drivers/cxl/core/pci.c
> > @@ -631,20 +631,18 @@ static int cxl_cdat_read_table(struct cxl_port *port,
> >  	return rc;
> >  }
> >  
> > -void read_cdat_data(struct cxl_port *port)
> > +static int __read_cdat_data(struct cxl_port *port)
> >  {
> >  	struct device *dev = &port->dev;
> >  	size_t cdat_length;
> >  	int ret;
> >  
> >  	if (cxl_cdat_get_length(port, &cdat_length))
> > -		return;
> > +		return 0;
> >  
> >  	port->cdat.table = devm_kzalloc(dev, cdat_length, GFP_KERNEL);
> > -	if (!port->cdat.table) {
> > -		ret = -ENOMEM;
> > -		goto error;
> > -	}
> > +	if (!port->cdat.table)
> > +		return -ENOMEM;
> >  
> >  	port->cdat.length = cdat_length;
> >  	ret = cxl_cdat_read_table(port, &port->cdat);
> > @@ -652,12 +650,26 @@ void read_cdat_data(struct cxl_port *port)
> >  		devm_kfree(dev, port->cdat.table);
> >  		port->cdat.table = NULL;
> >  		port->cdat.length = 0;
> > -		ret = -EIO;
> > -		goto error;
> > +		return -EIO;
> >  	}
> >  
> > -	return;
> > -error:
> > -	dev_err(dev, "CDAT data read error (%d)\n", ret);
> > +	return 0;
> > +}
> > +
> > +void read_cdat_data(struct cxl_port *port)
> > +{
> > +	int retries = 5;
> > +	int rc;
> > +
> > +	while (retries--) {
> > +		rc = __read_cdat_data(port);
> > +		if (!rc)
> > +			return;
> > +		dev_dbg(&port->dev,
> > +			"CDAT data read error rc=%d (retries %d)\n",
> > +			rc, retries);
> 
> Out of curiousity, what is the purpose of the dev_dbg? To diagnose delays or
> something?

Yes

> 
> > +	}
> > +	dev_err(&port->dev, "CDAT data read failed after %d retries\n",
> > +		retries);
> 
> 
> Reviewed-by: Ben Widawsky <bwidawsk@kernel.org>

Thanks!
Ira

> 
> >  }
> >  EXPORT_SYMBOL_NS_GPL(read_cdat_data, CXL);
> > -- 
> > 2.35.1
> >