Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp158043iof; Wed, 8 Jun 2022 18:03:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzP0dK8RXzBVFQS017BX/Uoe6GUmU+GsdVfOD7/azQWA1h6Fe/5NOlSTyYB8V7wv/QZEGt0 X-Received: by 2002:aa7:d303:0:b0:42d:d192:4c41 with SMTP id p3-20020aa7d303000000b0042dd1924c41mr42818107edq.178.1654736630532; Wed, 08 Jun 2022 18:03:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654736630; cv=none; d=google.com; s=arc-20160816; b=tnO97fnqZyRRlGyruxCzaDD0ijuIEroioI7SGV39mPW3PTttWKi8Ov4udp+Sf9ZhSg beX4AY5KaLkKXa/2q5vvKADSYj0ViaqYCxhg57xS8DDThG9wTteY3bW0fmsAlgUy1bKT NI4P9Jjvub+AS27fxA1OAooITJN4EO/5WjDvkeJaZQglchfUJS7xJWugF0xhfBP4aBol Ndt6oPt+dN3Td4dSvO8p1YzvjiuaZ5aX8zRoQ2Gulax7kTJ38BDZCwoI1uzApUV799Yt Euhtxmf9i3cBdCa3Ykka2scIXiUeRITqHYIxTxpelMFI7ukp0Nk4fdKLom3IzCAJW2ZZ 0LuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:references:cc:to:from :subject; bh=ebqkdhG/1sFhmDFm6NCL4tvRAPA1qiOdDjk4DEYaH6M=; b=IT10VBQRegVAqul82GhQoV+OrAfrBwK8yADLtRNWZ36QffLGFLoyPLdWC38MHSbabk iiWD44wzFiBkBdaAmNu/OsMMRJ6+OkG1+iv/xIEBz7Re9UGqD/qJjaaDkpWtnjTw2l5V AiLqQa2ZAv8eJ3VmzLrJU2JYg0mSSc3+tfc94s68PRTxADFHpDSZeKYj3O4oTWiRYkyH 6g9vrU6VG73r6DfPrQ4crZQM8AXo//oF5WTcOADGEdbjMcYlcMuD5zgLDSd0y8KcDTxv Y10JbKtP6K7UDZcD8T1Hcvh7SqYGTZNL14jf1P0jDhkvJRW+b9mmDkjbJ+gXEaY4MRTH ftTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hw9-20020a170907a0c900b0070fac9eaf73si4189538ejc.64.2022.06.08.18.03.24; Wed, 08 Jun 2022 18:03:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231362AbiFIA7W (ORCPT + 99 others); Wed, 8 Jun 2022 20:59:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230003AbiFIA7V (ORCPT ); Wed, 8 Jun 2022 20:59:21 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E910271E; Wed, 8 Jun 2022 17:59:18 -0700 (PDT) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LJQgs19lfzjXH7; Thu, 9 Jun 2022 08:58:17 +0800 (CST) Received: from kwepemm600009.china.huawei.com (7.193.23.164) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 9 Jun 2022 08:59:15 +0800 Received: from [10.174.176.73] (10.174.176.73) by kwepemm600009.china.huawei.com (7.193.23.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 9 Jun 2022 08:59:14 +0800 Subject: Re: [PATCH -next v5 0/8] bugfix and cleanup for blk-throttle From: Yu Kuai To: , , , CC: , , , References: <20220528064330.3471000-1-yukuai3@huawei.com> <244865d4-e7e7-432f-8e9c-248ab900d283@huawei.com> Message-ID: <66910926-39e8-85df-bd13-2ca6b2b03cac@huawei.com> Date: Thu, 9 Jun 2022 08:59:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <244865d4-e7e7-432f-8e9c-248ab900d283@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.176.73] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600009.china.huawei.com (7.193.23.164) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/06/02 19:14, Yu Kuai 写道: > 在 2022/05/28 14:43, Yu Kuai 写道: >> Changes in v5: >>   - add comments in patch 4 >>   - clear bytes/io_skipped in throtl_start_new_slice_with_credit() in >>   patch 4 >>   - and cleanup patches 5-8 >> Changes in v4: >>   - add reviewed-by tag for patch 1 >>   - add patch 2,3 >>   - use a different way to fix io hung in patch 4 >> Changes in v3: >>   - fix a check in patch 1 >>   - fix link err in patch 2 on 32-bit platform >>   - handle overflow in patch 2 >> Changes in v2: >>   - use a new solution suggested by Ming >>   - change the title of patch 1 >>   - add patch 2 >> >> Patch 1 fix that blk-throttle can't work if multiple bios are throttle, >> Patch 2 fix overflow while calculating wait time >> Patch 3,4 fix io hung due to configuration updates. >> Patch 5-8 are cleanup patches, there are no functional changes, just >> some places that I think can be optimized during code review. > > friendly ping ... friendly ping ... I'll resend this patchset soon if there are still no response. Thanks, Kuai >> >> Previous version: >> v1: >> https://lore.kernel.org/all/20220517134909.2910251-1-yukuai3@huawei.com/ >> v2: >> https://lore.kernel.org/all/20220518072751.1188163-1-yukuai3@huawei.com/ >> v3: >> https://lore.kernel.org/all/20220519085811.879097-1-yukuai3@huawei.com/ >> v4: >> https://lore.kernel.org/all/20220523082633.2324980-1-yukuai3@huawei.com/ >> >> Yu Kuai (8): >>    blk-throttle: fix that io throttle can only work for single bio >>    blk-throttle: prevent overflow while calculating wait time >>    blk-throttle: factor out code to calculate ios/bytes_allowed >>    blk-throttle: fix io hung due to config updates >>    blk-throttle: use 'READ/WRITE' instead of '0/1' >>    blk-throttle: calling throtl_dequeue/enqueue_tg in pairs >>    blk-throttle: cleanup tg_update_disptime() >>    blk-throttle: clean up flag 'THROTL_TG_PENDING' >> >>   block/blk-throttle.c | 158 +++++++++++++++++++++++++++++-------------- >>   block/blk-throttle.h |  16 +++-- >>   2 files changed, 120 insertions(+), 54 deletions(-) >>