Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759156AbXEUPK2 (ORCPT ); Mon, 21 May 2007 11:10:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763687AbXEUPKG (ORCPT ); Mon, 21 May 2007 11:10:06 -0400 Received: from nn7.de ([85.214.94.156]:44126 "EHLO nn7.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763667AbXEUPKE (ORCPT ); Mon, 21 May 2007 11:10:04 -0400 Subject: Re: [Bug 8498], [Bug 8510], and Re: Can't s2ram 22-rc2 From: Soeren Sonnenburg To: Alan Stern Cc: Andrey Borzenkov , Avuton Olrich , Greg KH , "Rafael J\. Wysocki" , Jiri Slaby , Andrew Morton , USB development list , Linux-pm mailing list , Kernel development list In-Reply-To: References: Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Mon, 21 May 2007 17:10:00 +0200 Message-Id: <1179760200.4082.1.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1620 Lines: 49 On Mon, 2007-05-21 at 10:51 -0400, Alan Stern wrote: > On Sat, 19 May 2007, Greg KH wrote: > It turns out that the patch I originally wrote to fix this is in > conflict with one of Raphael's patches (make freezeable workqueues > singlethread) already added to 2.6.22-rc2. So here's an updated > version for that kernel. > > Andrey, Soeren, and Avuton: Please try this patch with 2.6.22-rc2 or > later and see if it fixes your problems. > > Greg, if this works then I'll send it in the proper form for a patch, > and you can use it to replace > > usb-make-the-autosuspend-workqueue-thread-freezable.patch works perfect, i.e. the machine survived 3 s2ram cycles and rebooted cleanly :-)) apply! apply! Soeren > Alan Stern > > > Index: 2.6.22-rc2/drivers/usb/core/usb.c > =================================================================== > --- 2.6.22-rc2.orig/drivers/usb/core/usb.c > +++ 2.6.22-rc2/drivers/usb/core/usb.c > @@ -205,7 +205,7 @@ struct device_type usb_device_type = { > > static int ksuspend_usb_init(void) > { > - ksuspend_usb_wq = create_singlethread_workqueue("ksuspend_usbd"); > + ksuspend_usb_wq = create_freezeable_workqueue("ksuspend_usbd"); > if (!ksuspend_usb_wq) > return -ENOMEM; > return 0; > -- Sometimes, there's a moment as you're waking, when you become aware of the real world around you, but you're still dreaming. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/