Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 8 Jun 2022 20:38:42 -0500
From:   Jeff LaBundy <jeff@labundy.com>
To:     Rob Herring <robh@kernel.org>
Cc:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Heinrich Schuchardt <xypron.glpk@gmx.de>,
        Hans de Goede <hdegoede@redhat.com>,
        Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Artur Rojek <contact@artur-rojek.eu>,
        Maxime Ripard <mripard@kernel.org>,
        linux-input@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] dt-bindings: input: Centralize 'linux,input-type'
 definition
Message-ID: <20220609013842.GD191119@nixie71>
References: <20220608211207.2058487-1-robh@kernel.org>
 <20220608211207.2058487-5-robh@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220608211207.2058487-5-robh@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BfGss2xg2w3Aa2m9muuI215IRNKoJqu4enVswepCxWA59QFFcuXJFOZ1/MRw?=
 =?us-ascii?Q?bwjzHp25Et42jTC9RXNYCztFmkxi+gjQfWFDihz/10bbZz22ByQKd4AlK8lE?=
 =?us-ascii?Q?TfFLPdnGK0NV5BKmEq8akDI29L2XOFrZ+To1ra3xFpgcDo9py4Ifs3cQ5Avi?=
 =?us-ascii?Q?2y+skQdao2oNa4blUBvAGfgtnYqx6dRyroeyLMZoHuiloGrRMg0FljNBGEod?=
 =?us-ascii?Q?U95NdcW1ansOXeJ4pagxb5cDA6jJMSNct4GaeY5M0/ZD6qMr2zVC+x3xukWr?=
 =?us-ascii?Q?4FUcHJYp1IaKSUOUVPgkiSP9fy5ue/w4alWk8Ar2ZctPuC5xDT2Hk7BV2xQI?=
 =?us-ascii?Q?Dvi0NlAzip6Ry2E6JiSbTcYf1UPfyj2+Riu8VYKg6nCZtS0IwVZAm12MYsqP?=
 =?us-ascii?Q?qBDjv9waIr+CSaJhpP9gaVmHvSZe02jSOuC3LU6vWW7cep8S8dO5NMGotW75?=
 =?us-ascii?Q?Tnu8LfQQIeiv0+Lwqnh9E0nw+KCXj4gld3RbbQluq31qqFUl5+vdYcEkIr/7?=
 =?us-ascii?Q?TfXHhRfYp3VOqLNz2zbzKhayP/d6cRXNkHTGs6MGtCo98oTD6lmog3T4+t2q?=
 =?us-ascii?Q?1ZUj46H55uFYWHyuaNWbroXglDMDfmXFxPAf6IA4icJioNlCags/sq580+k4?=
 =?us-ascii?Q?45PeYnGvXALLGiT+RqB9wpt/jsqFBMgJzAFO9sjbty7V0ElhKqp5m3aPE/LY?=
 =?us-ascii?Q?xXL36c6vaVCd7ylG0smKWyVw51538Aw5MexnV/u3h3g1XQkio7qLn7eg1AmZ?=
 =?us-ascii?Q?PC5wueMK3+tYFJJ+hyQLVZ5jI+qYFOj5UuCBXfvs+aSo1MD/WMcOMp4eynma?=
 =?us-ascii?Q?b7Y159ACU9eIhBefp0wc0tBywF0vwb/apvK5jkft8E/0Nh+SbC9UX5hhs/M3?=
 =?us-ascii?Q?XIkjEsB4KIpahL3rCKrmF/TgGoBuisn+rIFTOfADu6jkNrjjfrzOnGm3P7h9?=
 =?us-ascii?Q?WN+oarDf43Boa8F3pmFN4iHP8ZEnWAWQ92q+jS22qz/CjwXOjci4rH09+2O9?=
 =?us-ascii?Q?rlTbkl5wKTfJJ9thdLJSAT1gpaV5mVhjxRdvaC0ebxeNxvwEGeYcKrDwlA9l?=
 =?us-ascii?Q?4Pt6SYlPAM/41aU+hM4eqj/N4tblZnBKphjN05NOnIbf34N4RlpN1V1sPIGX?=
 =?us-ascii?Q?ACm3OT5dVvVz4e//NsuROBpbl4C4l9rAgNKnQXj/J6kJR7f6vmczDD0lNSpr?=
 =?us-ascii?Q?nn9JpLgHW+Sk4o+kKWQyP8BRSLaY4mdrHQ8CTHVjLSi2kEFhlpgoK0rgXYym?=
 =?us-ascii?Q?ua9jEKgm8UPG07IgQATLzP5lODpQ0h41w69NI4vwBncJ7sieVGF7m9fmp/iM?=
 =?us-ascii?Q?U2SPEN9KatAmVY3ETgXyH4XjMsYShAQI0tnxVOpUYtrI7YJ556XhPt24nLfr?=
 =?us-ascii?Q?UJ5K0ILGihyv05sCjw17E7ldpfy7R/v56aezlbQLYLDs+kr68sFmeBr1eVYI?=
 =?us-ascii?Q?SIOGVhCpPsI7cdvY3dViEAmL3cSVhbXA8cC+pT7amvGybjJt8l/Odoi9415q?=
 =?us-ascii?Q?hA9XlZZ7be/smh6yIBBStQUBrtWipiGo1M1dvi6aLYOTyck0AwGhIk2nfEG6?=
 =?us-ascii?Q?ZXSzi3WG6HWHKROjoSuwU3JJKgE8/fZ2TV2maBMIaxj+RCaQ5Vs8nhIvcd8e?=
 =?us-ascii?Q?Rg3M6l/RbAqKOI+CBKBefxDNvgv8QOMpFmD4mEiZQP1V443JPdJLrFxLRdK0?=
 =?us-ascii?Q?+kwGD1256JRLDv3aHAYengZiOOnzT5HbgB9asbJJ44EYXxHtmESCb5vacIqy?=
 =?us-ascii?Q?3Qysymp8Hg=3D=3D?=
X-OriginatorOrg: labundy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ca6c28a9-7d03-40f3-008e-08da49b8ca77
X-MS-Exchange-CrossTenant-AuthSource: SN4PR0801MB3774.namprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2022 01:38:44.7359
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 00b69d09-acab-4585-aca7-8fb7c6323e6f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KpwexYFicQjHZvCmtCFJ38SoBtBypEzOVJ7ftP1T8TAkMBtzEeBNMFhZ7+8n5DMb3omuQ6MLBc6DcmTl4Z8OPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR08MB6873
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rob,

On Wed, Jun 08, 2022 at 03:12:06PM -0600, Rob Herring wrote:
> Multiple bindings use 'linux,input-type', but there is not a central
> definition and type. Add 'linux,input-type' to input.yaml and update all
> the users to use it.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

For *iqs*.yaml:

Acked-by: Jeff LaBundy <jeff@labundy.com>

> ---
>  .../devicetree/bindings/input/azoteq,iqs7222.yaml  |  1 -
>  .../devicetree/bindings/input/gpio-keys.yaml       |  7 +------
>  Documentation/devicetree/bindings/input/input.yaml | 14 ++++++++++++++
>  .../devicetree/bindings/input/iqs626a.yaml         |  4 ----
>  4 files changed, 15 insertions(+), 11 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/azoteq,iqs7222.yaml b/Documentation/devicetree/bindings/input/azoteq,iqs7222.yaml
> index 5ea10fe7ffe9..a13bd3e41dd3 100644
> --- a/Documentation/devicetree/bindings/input/azoteq,iqs7222.yaml
> +++ b/Documentation/devicetree/bindings/input/azoteq,iqs7222.yaml
> @@ -471,7 +471,6 @@ patternProperties:
>            linux,code: true
>  
>            linux,input-type:
> -            $ref: /schemas/types.yaml#/definitions/uint32
>              enum: [1, 5]
>              default: 1
>              description:
> diff --git a/Documentation/devicetree/bindings/input/gpio-keys.yaml b/Documentation/devicetree/bindings/input/gpio-keys.yaml
> index cd07107fd5ed..6b49b1afdd95 100644
> --- a/Documentation/devicetree/bindings/input/gpio-keys.yaml
> +++ b/Documentation/devicetree/bindings/input/gpio-keys.yaml
> @@ -36,12 +36,7 @@ patternProperties:
>            description: Key / Axis code to emit.
>  
>          linux,input-type:
> -          description:
> -            Specify event type this button/key generates. If not specified defaults to
> -            <1> == EV_KEY.
> -          $ref: /schemas/types.yaml#/definitions/uint32
> -
> -          default: 1
> +          default: 1  # EV_KEY
>  
>          linux,input-value:
>            description: |
> diff --git a/Documentation/devicetree/bindings/input/input.yaml b/Documentation/devicetree/bindings/input/input.yaml
> index e3701a0bc500..17512f4347fd 100644
> --- a/Documentation/devicetree/bindings/input/input.yaml
> +++ b/Documentation/devicetree/bindings/input/input.yaml
> @@ -31,6 +31,17 @@ properties:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      maximum: 0x2ff
>  
> +  linux,input-type:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum:
> +      - 1   # EV_KEY
> +      - 2   # EV_REL
> +      - 3   # EV_ABS
> +      - 5   # EV_SW
> +    description:
> +      Specifies whether the event is to be interpreted as a key, relative,
> +      absolute, or switch.
> +
>    poll-interval:
>      description: Poll interval time in milliseconds.
>      $ref: /schemas/types.yaml#/definitions/uint32
> @@ -47,4 +58,7 @@ properties:
>        reset automatically. Device with key pressed reset feature can specify
>        this property.
>  
> +dependencies:
> +  linux,input-type: [ "linux,code" ]
> +
>  additionalProperties: true
> diff --git a/Documentation/devicetree/bindings/input/iqs626a.yaml b/Documentation/devicetree/bindings/input/iqs626a.yaml
> index 008959f2d425..4df27646c980 100644
> --- a/Documentation/devicetree/bindings/input/iqs626a.yaml
> +++ b/Documentation/devicetree/bindings/input/iqs626a.yaml
> @@ -491,16 +491,12 @@ patternProperties:
>            linux,code: true
>  
>            linux,input-type:
> -            $ref: /schemas/types.yaml#/definitions/uint32
>              enum: [1, 5]
>              description:
>                Specifies whether the event is to be interpreted as a key (1) or
>                a switch (5). By default, Hall-channel events are interpreted as
>                switches and all others are interpreted as keys.
>  
> -        dependencies:
> -          linux,input-type: ["linux,code"]
> -
>          additionalProperties: false
>  
>      dependencies:
> -- 
> 2.34.1
> 

Kind regards,
Jeff LaBundy