Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <22584780-a2eb-0a83-daaa-f259aa2adc42@wanadoo.fr>
Date:   Thu, 9 Jun 2022 06:59:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] virtio: Directly use ida_alloc_range()/ida_free()
Content-Language: en-US
To:     =?UTF-8?B?dG9tb3Jyb3cgV2FuZyAo546L5b635piOKQ==?= 
        <wangdeming@inspur.com>, "mst@redhat.com" <mst@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>
Cc:     "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <aff7bba2680b49fab6a14694e33fd41d@inspur.com>
From:   Christophe JAILLET <christophe.jaillet@wanadoo.fr>
In-Reply-To: <aff7bba2680b49fab6a14694e33fd41d@inspur.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 09/06/2022 à 02:42, tomorrow Wang (王德明) a écrit :
>>
>> An explanation in the commit log of why the -1 is needed would also help
>> reviewer/maintainer, IMHO.
>>
>> It IS correct, but it is not that obvious without looking at
>> ida_simple_get() and ida_alloc_range().
>>
> 
> can I mention one patch about repair ida_free  for this.
> 
> 

If you manage to find another patch and provide a lore.kernel.org link 
to it, I think it should be okay.

However, after a *quick* look in some mailing list, I've not found yet a 
description for that.

CJ