Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp76978iol; Wed, 8 Jun 2022 22:27:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySU8k6StL42otJvDGy7g8nGF/ji4uD3g6lo/8RO/NVUo2M9bmVNHZSPXG8mlM7CoFSXjpP X-Received: by 2002:a05:6402:528f:b0:42a:c778:469e with SMTP id en15-20020a056402528f00b0042ac778469emr42448626edb.404.1654752458490; Wed, 08 Jun 2022 22:27:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654752458; cv=none; d=google.com; s=arc-20160816; b=Z2EKAV4h1uOBIB4n+6/Fx5LecMtLqyHpK8Y83DYh6BmWg2z2eDzkxwYhmCXp4wmhcE xQ9yu6OC5IjxEoHhtYfYTvFuDGBefgG4RstpMc2YPWYjRF5Z0JikYh+b30xeWWrtzTIG IOAu03xxKgtQ4biLmzwsrCQRe4y9owv35GGzHpQ+cltnY029cXiwupUC5Y2YYIdecDff AG65ljPSpBvdiOMbjoiWp+FJMGUAsxnLHbW/fQyXvIB3XvoNo/okirRgkzqDtc5FaPnY IeuhaXm9TfhWqfaigbb47iSKTxcBqRp6nS9l7eQAPvpxnhhOk8ciP8TIKurNsu6O11x7 qE5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:mime-version:message-id:date :dkim-signature; bh=7XF9Ovw3kggDsMB//JiO35wPNulyyyK2DnQRx8sKbCw=; b=L6t3y/CjCW765ApGrAYEMPCKl+lxpm5cN9uQC/ByaDFhSa297ztVSjbNqsnqr++cxJ im/QTNuiAE0OOWlcykyDj1IpKrbJLYAXB2BI5DHPnIL8gp6TNKpKOIHpMktM62wzBeB/ oVLyT9HDmx4IXiEpRp1J7x7A7CrigT+ZW1U3vgDIN6m8ydMaLgEqe2NMBlK2gXNv734J mt1MTFVOP5d6jXvn0CHddwBp7YwoUNoIEOyofhy5YHruydT7bjHxyylqh9W+mS7Ji7Dg 44pIeCudPm2FHjnq0KRBlE8heMPetdbx9ZTX8lUnP0Fc40bGwxKcyqQIG5huWEh5Bnkt phZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=Qxt+qHfY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r4-20020a056402034400b0042b633ca6besi2950374edw.551.2022.06.08.22.27.13; Wed, 08 Jun 2022 22:27:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=Qxt+qHfY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238289AbiFIFYH (ORCPT + 99 others); Thu, 9 Jun 2022 01:24:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230391AbiFIFYF (ORCPT ); Thu, 9 Jun 2022 01:24:05 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 128F62BDC for ; Wed, 8 Jun 2022 22:24:02 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id b6-20020a252e46000000b0065d5168f3f0so19279443ybn.21 for ; Wed, 08 Jun 2022 22:24:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=7XF9Ovw3kggDsMB//JiO35wPNulyyyK2DnQRx8sKbCw=; b=Qxt+qHfYhDcOmc8hJ0bwanQhLdkNTTw/fTHYnVI3n9lc9yKskzsAgPUblvzaiKqzki f4R+lZJq29nNw2NS9A2gMI8kKaT12s3IhM+pX4QiU0AQrQ0qe/G4kYYOKL4Oz+KPv82X 7lDgoVC5Fl/2mmrBnJzIwfT/hm0Hp/dNnPONk4i7CseHykg9pWWgTQuRqjzOnWZLYoe9 kPG0qrkCgz/oKwWwvd0zLDJGFiYnrGgZTbqMxeE3QmbZPzlNqwlr2qca2eSgyrf2s/ej 5BDSK7xwy0GfLGHT32urHkpiQqk95ILmj57wVUSRiEvC+FoQ38ZkFZH9Rl0lU3I99xqa pH/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=7XF9Ovw3kggDsMB//JiO35wPNulyyyK2DnQRx8sKbCw=; b=ygUwdzflJUhO/JP22izNUgX3nFi1yUieK+PNPWclR2uMrsujtL/saK0ZehNb4sHj4H sxTtm/S22LFUrUn3uNnT5pmuS2WxcPCCPXAfs/lCgN2LrQnZrENQPyGwZO7pBsUNtN2Q NZvZmMGBTeG2J0PHtHMqxNdT3ru33iEbKrAFPtXf5RD5TurcDibqgBrb236t9m+CHnNo HShtdoXtlZPCMtU3x28jOz6rbsirNdxVPl7pvVlmXRc4/7nMnYEONyyFlZZAGzD8GP+J JKaprkvox3kjxdL4Siu3h0KA5mW7YsjoJJOGm7VUEi4qs3B3gBNkifoPSASjWBT6crJz PXxQ== X-Gm-Message-State: AOAM5331g09Ku7UlAd7UrfVE1yo1I/iX/o5efUfVIO20LtXIOJSK+Bu5 kxcS9xsm949kFelLDj1QxSE4+9t4stFD X-Received: from irogers.svl.corp.google.com ([2620:15c:2cd:202:ae20:7578:fb21:976b]) (user=irogers job=sendgmr) by 2002:a25:2385:0:b0:664:381c:7c98 with SMTP id j127-20020a252385000000b00664381c7c98mr1028385ybj.7.1654752241781; Wed, 08 Jun 2022 22:24:01 -0700 (PDT) Date: Wed, 8 Jun 2022 22:23:51 -0700 Message-Id: <20220609052355.1300162-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.36.1.255.ge46751e96f-goog Subject: [PATCH v2 0/4] Tidy user rdpmc documentation and testing From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Kajol Jain , Andi Kleen , Adrian Hunter , Anshuman Khandual , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Rob Herring Cc: Stephane Eranian , Ian Rogers Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org libperf's perf_mmap__read_self and the addition of arm64 support mean that the perf_event.h and the rdpmc perf test have become stale. Refresh the documentation in perf_event.h, remove the x86 rdpmc test and port the libperf test as a non-architecture specific test. Address sanitizer testing showed libperf leaking fds when the perf_event_open failed, add error paths to handle this. A comment is added to perf_event.h to avoid a divide by zero when scaling counts if the running time is 0. This was previously discussed in this thread: https://lore.kernel.org/lkml/CAP-5=fVRdqvswtyQMg5cB+ntTGda+SAYskjTQednEH-AeZo13g@mail.gmail.com/ v2. Alters the skip in test_stat_user_read for open to always be a skip as perf_event_open may fail with EACCES (permissions), ENOSYS (not supported) and ENOENT (hypervisor). Adds Rob Herring's acked-by on patch 3. Ian Rogers (4): libperf evsel: Open shouldn't leak fd on failure perf: Align user space counter reading with code perf test: Remove x86 rdpmc test perf test: Add user space counter reading tests include/uapi/linux/perf_event.h | 32 +++-- tools/include/uapi/linux/perf_event.h | 32 +++-- tools/lib/perf/evsel.c | 17 ++- tools/perf/arch/x86/tests/Build | 1 - tools/perf/arch/x86/tests/arch-tests.c | 2 - tools/perf/arch/x86/tests/rdpmc.c | 182 ------------------------- tools/perf/tests/mmap-basic.c | 127 ++++++++++++++++- 7 files changed, 176 insertions(+), 217 deletions(-) delete mode 100644 tools/perf/arch/x86/tests/rdpmc.c -- 2.36.1.255.ge46751e96f-goog