Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <915be92d-302a-9149-a525-a375146a3fd9@quicinc.com>
Date:   Thu, 9 Jun 2022 10:54:52 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH V14 8/9] arm64: dts: qcom: pm8008: Add base dts file
Content-Language: en-US
To:     Luca Weiss <luca.weiss@fairphone.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>
CC:     Lee Jones <lee.jones@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <swboyd@chromium.org>,
        <quic_collinsd@quicinc.com>, <quic_subbaram@quicinc.com>,
        <quic_jprakash@quicinc.com>
References: <1654602615-28849-1-git-send-email-quic_c_skakit@quicinc.com>
 <1654602615-28849-9-git-send-email-quic_c_skakit@quicinc.com>
 <CKJXIE08RHD0.31NM2AKTA8B9V@otso>
From:   "Satya Priya Kakitapalli (Temp)" <quic_c_skakit@quicinc.com>
In-Reply-To: <CKJXIE08RHD0.31NM2AKTA8B9V@otso>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Luca,


On 6/7/2022 6:46 PM, Luca Weiss wrote:
> Hi Satya,
>
> On Tue Jun 7, 2022 at 1:50 PM CEST, Satya Priya wrote:
>> Add base DTS file for pm8008.
>>
>> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
>> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>> ---
>> Changes in V14:
>>   - None.
>>
>> Changes in V13:
>>   - None.
>>
>> Changes in V12:
>>   - None.
>>
>> Changes in V11:
>>   - Remove intermediate regulators node and add the ldos under
>>     pm8008@8 node.
>>   - change the address cells as 2 for pm8008 parent mfd node.
>>   - add compatible to register the ldos.
>>   - add reg with i2c client offset and address.
>>
>>   arc
>>   arch/arm64/boot/dts/qcom/pm8008.dtsi | 54 ++++++++++++++++++++++++++++++++++++
>>   1 file changed, 54 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/qcom/pm8008.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pm8008.dtsi b/arch/arm64/boot/dts/qcom/pm8008.dtsi
>> new file mode 100644
>> index 0000000..6f37e4d
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/pm8008.dtsi
>> @@ -0,0 +1,54 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +// Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
> I noticed this file was licensed as BSD-3-Clause in V13 and
> this change was not mentioned in the "Changes" part.
> Any specific reason? Especially newer dts files should be BSD-licensed,
> and having this GPL dtsi included in otherwise BSD dts files is not
> good.


I changed it as per the suggestions of Qualcomm internal review team but 
i see that many of the drivers use BSD license, will change this back to 
BSD-3-Clause.


> Regards
> Luca