Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp144738iol; Thu, 9 Jun 2022 00:22:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzM7dp9s6kK8Jqfqg5ib6LzMkqDB5yyODDklIHh5xpbknY3rR6d9REJt+kD9xtNDHm0xgCv X-Received: by 2002:a05:6a00:2311:b0:4e1:52bf:e466 with SMTP id h17-20020a056a00231100b004e152bfe466mr48461383pfh.77.1654759331200; Thu, 09 Jun 2022 00:22:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654759331; cv=none; d=google.com; s=arc-20160816; b=D8xHneJMsslaQ56m4YJN0qhoF6lfrMavHtkOpORHHXCljf0v9paxi2Hd3Ak0R6V/jx O3+9k3visKcSQZaWNvabjh6Bg71LhphIgf16nd1uiSzS0A800dkFenBRDOeoW4KPMu8v fkhcDk4PVgcpDnKu4+LjkELQqHpsx9KyJPN9IvXF21/in/wuTV4tq3VsptmEStmlgorU DJg1ttp3q7MMc2vRGBeanqgKHDI8pbnSspANKlLtIh9M6P/utQOBlGCveErnGFm/tzV6 XJbhw/muZmovN+KJIdvX1KhNRs61fPtRwndyHw8xpHLY/kthQMbT1zYB1vq+6NjWZiHM JtMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=prVnTO+TF5DFNwmSlDjB74OQ16I62n/OVZbVGLBKmOo=; b=GaXZ1ogvv89YAAhhQtXnyLGaEvOYMoj7XTj0sGzCsqRx4hAikh3zhqhbJtdheVEb/8 zuNLyF4GhC8+0XT1LYcQvkH3EvMPUS0gxlL8NPll5Ylq2Wz5ILIR4WvBJYq6qfJj2xqC ZKuDEUBf8VESTJw07QeTtQicpOoh8p/ORCEDB0D3S3l/EHB6FJ1k9TM7b9vejaFsVIIz YW1aogjzGqQbpdEURJwEYJyK1U9hkLD6GPpRzWcHeUO9f798e7nFqflNqyHzqs7sCjGt 2psTfCLboLZmifBYXfkigzLYF6KU/9lourvRJ1X61FuaG5QjiMyKKgc1yTyYG4fNn/B4 eUig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l127-20020a633e85000000b003fc756ebac3si35279794pga.407.2022.06.09.00.21.59; Thu, 09 Jun 2022 00:22:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239268AbiFIHI0 (ORCPT + 99 others); Thu, 9 Jun 2022 03:08:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239635AbiFIHIU (ORCPT ); Thu, 9 Jun 2022 03:08:20 -0400 Received: from hust.edu.cn (mail.hust.edu.cn [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 793C3211AA0; Thu, 9 Jun 2022 00:08:17 -0700 (PDT) Received: from localhost.localdomain ([172.16.0.254]) (user=dzm91@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 25976wDx024268-25976wE2024268 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 9 Jun 2022 15:07:05 +0800 From: Dongliang Mu To: Zhu Yanjun , Jason Gunthorpe , Leon Romanovsky Cc: Dongliang Mu , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] rxe: fix xa_alloc_cycle() error return value check again Date: Thu, 9 Jun 2022 15:06:56 +0800 Message-Id: <20220609070656.1446121-1-dzm91@hust.edu.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-FEAS-AUTH-USER: dzm91@hust.edu.cn X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dongliang Mu Currently rxe_alloc checks ret to indicate error, but 1 is also a valid return and just indicates that the allocation succeeded with a wrap. Fix this by modifying the check to be < 0. Signed-off-by: Dongliang Mu --- drivers/infiniband/sw/rxe/rxe_pool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/sw/rxe/rxe_pool.c b/drivers/infiniband/sw/rxe/rxe_pool.c index 1cc8e847ccff..e9f3bbd8d605 100644 --- a/drivers/infiniband/sw/rxe/rxe_pool.c +++ b/drivers/infiniband/sw/rxe/rxe_pool.c @@ -167,7 +167,7 @@ int __rxe_add_to_pool(struct rxe_pool *pool, struct rxe_pool_elem *elem) err = xa_alloc_cyclic(&pool->xa, &elem->index, elem, pool->limit, &pool->next, GFP_KERNEL); - if (err) + if (err < 0) goto err_cnt; return 0; -- 2.25.1