Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 9 Jun 2022 09:16:36 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc:     linux-kernel@vger.kernel.org,
        Amarula patchwork <linux-amarula@amarulasolutions.com>,
        michael@amarulasolutions.com,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC PATCH 06/13] can: slcan: allow to send commands to the
 adapter
Message-ID: <20220609071636.6tbspftu3yclip55@pengutronix.de>
References: <20220607094752.1029295-1-dario.binacchi@amarulasolutions.com>
 <20220607094752.1029295-7-dario.binacchi@amarulasolutions.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="7stl6ydzt5xshu4k"
Content-Disposition: inline
In-Reply-To: <20220607094752.1029295-7-dario.binacchi@amarulasolutions.com>
Precedence: bulk


--7stl6ydzt5xshu4k
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 07.06.2022 11:47:45, Dario Binacchi wrote:
> This is a preparation patch for the upcoming support to change the
> bitrate via ip tool, reset the adapter error states via the ethtool API
> and, more generally, send commands to the adapter.
>=20
> Since some commands (e. g. setting the bitrate) will be sent before
> calling the open_candev(), the netif_running() will return false and so
> a new flag bit (i. e. SLF_XCMD) for serial transmission has to be added.
>=20
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

I think this patch can be dropped, let me explain:

You don't have to implement the do_set_bittiming callback. It's
perfectly OK to set the bitrate during the ndo_open callback after
open_candev().

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--7stl6ydzt5xshu4k
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmKhnlEACgkQrX5LkNig
011KPAf+MP0nAePFTpQQJOwpxv468csZ37atHCgPNOWmGIw4u0n3zvQnLJzPOzY3
G5hckJvFCJblep4Dxm3k2XU0zYo8cK/nQ5lLJ1jYQ1rh1RZzlET/7bV2nu/yCFzm
aiRzEksO6SZMDLCy6BwMB6lwXEtMYdwpDrS2fOcn5Rcv17NJez2bJH5C3kIa5Wrp
XPzVcgUYeD8Z+ARdkOsUvbwWnl1bHmGZaLrZWWtEbmqQ5w/Kq0z4zwvwUKo14mNx
4d3KUwFcbJMtuwpz65qc5De9YjESWawuCqJfLw19InkhJElsxNQAUuWIEt+SE8jR
UZJRpgRPRue7e1aXyRiGPwmuGwTgEQ==
=jCQx
-----END PGP SIGNATURE-----

--7stl6ydzt5xshu4k--