Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp180059iol; Thu, 9 Jun 2022 01:21:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKs4GnckkLImNAOjiZ/AOCMvCMCOu64UlgWxTvh3LeDbZT6LaKG6M7GCpIHTc6O1CuuNZx X-Received: by 2002:a17:902:ed82:b0:158:fef8:b501 with SMTP id e2-20020a170902ed8200b00158fef8b501mr37391157plj.47.1654762876606; Thu, 09 Jun 2022 01:21:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654762876; cv=none; d=google.com; s=arc-20160816; b=z2yRMzcVWR64ObA1eonJnbysyTxnXCAXfkzfSY9nZY4XPDigzK1ZM3+YLDd9zkdVn8 JhRNuzG7w4RYvG/znDo6lXWnGyfv65K2b8OZSJqHb+xBMHgvNMV7JBwiCb+IzWMdptvO oJIVW8eUeFHWRPM3qTOQoHb0jyL8pkHi2gNFCFoBPWj7OWdXHDXzJY3BVgYtSUNFvedd N7SmUU/KA3tBen9Np8gbH7CrYq7FswV/6CjwOg/P63SEQRJNXXKtWUX9m1Yu6B8M0vwD W69nJh2pQunkFHeaz+cdt+riujQuZ7091g9nvd78r+9jb72yjLAo5EpKww31B6u3OLRH 0i5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=NezJ4yFt2mWvmg7UHtzPvc/2b6zpouxKxGCCueZBOvc=; b=Ehf4cHogn62hmodXVB1jfgwOacFe9mW4kUI67txIvtZj6CSLQ63Cib7WWQDNnRbczP PxVe12uYmVNscGNpydAFBzS3kSghHY6HfTlHryOl8gLafP+DU4TzkXnU729P+IWPj/4K z6ZhCcLBFaIr3lQaS46xYKLjsPMKHghYfIFZ0tAD6U5kl/hHx9F7RtMJZ9IdAbc41F67 34HQWP0bXIRjTPsN7kfoQQUgDmwjT0pio8qYd0c/XekG+EaZ/TcjhuKW0svjqUkUjKVe FIuh3OgislSwSvEAesxj6raYyX0KemcLWw0EVFSBk9gQnibxJDglDa3ZDHIdo1+WLhbe f65g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c12-20020a655a8c000000b003f8a46f99dcsi30978450pgt.499.2022.06.09.01.21.02; Thu, 09 Jun 2022 01:21:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239219AbiFIHjb (ORCPT + 99 others); Thu, 9 Jun 2022 03:39:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237153AbiFIHj0 (ORCPT ); Thu, 9 Jun 2022 03:39:26 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 361E11AF1F; Thu, 9 Jun 2022 00:39:25 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 88FEF80F1; Thu, 9 Jun 2022 07:34:50 +0000 (UTC) Date: Thu, 9 Jun 2022 10:39:22 +0300 From: Tony Lindgren To: Arnd Bergmann Cc: Peter Zijlstra , Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King - ARM Linux , Hans Ulli Kroll , Linus Walleij , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , NXP Linux Team , Kevin Hilman , Catalin Marinas , Will Deacon , Guo Ren , bcain@quicinc.com, Huacai Chen , Xuerui Wang , Geert Uytterhoeven , Sam Creasey , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , Stefan Kristiansson , Stafford Horne , James Bottomley , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , David Miller , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , the arch/x86 maintainers , "H. Peter Anvin" , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Juergen Gross , srivatsa@csail.mit.edu, amakhalov@vmware.com, Pv-drivers , Boris Ostrovsky , Chris Zankel , Max Filippov , Rafael Wysocki , Len Brown , Pavel Machek , gregkh , Michael Turquette , Stephen Boyd , Daniel Lezcano , lpieralisi@kernel.org, Sudeep Holla , Andy Gross , Bjorn Andersson , Anup Patel , Thierry Reding , Jonathan Hunter , jacob.jun.pan@linux.intel.com, Yury Norov , Andy Shevchenko , Rasmus Villemoes , Steven Rostedt , Petr Mladek , Sergey Senozhatsky , John Ogness , "Paul E. McKenney" , Frederic Weisbecker , quic_neeraju@quicinc.com, Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , vschneid@redhat.com, jpoimboe@kernel.org, alpha , Linux Kernel Mailing List , "open list:SYNOPSYS ARC ARCHITECTURE" , Linux ARM , linux-omap , linux-csky@vger.kernel.org, "open list:QUALCOMM HEXAGON..." , "open list:IA64 (Itanium) PLATFORM" , linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Openrisc , Parisc List , linuxppc-dev , linux-riscv , linux-s390 , Linux-sh list , sparclinux , linux-um , linux-perf-users@vger.kernel.org, "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , xen-devel , "open list:TENSILICA XTENSA PORT (xtensa)" , ACPI Devel Maling List , Linux PM list , linux-clk , linux-arm-msm , "open list:TEGRA ARCHITECTURE SUPPORT" , linux-arch , rcu@vger.kernel.org Subject: Re: [PATCH 33/36] cpuidle,omap3: Use WFI for omap3_pm_idle() Message-ID: References: <20220608142723.103523089@infradead.org> <20220608144518.010587032@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Arnd Bergmann [220608 18:18]: > On Wed, Jun 8, 2022 at 4:27 PM Peter Zijlstra wrote: > > > > arch_cpu_idle() is a very simple idle interface and exposes only a > > single idle state and is expected to not require RCU and not do any > > tracing/instrumentation. > > > > As such, omap_sram_idle() is not a valid implementation. Replace it > > with the simple (shallow) omap3_do_wfi() call. Leaving the more > > complicated idle states for the cpuidle driver. Agreed it makes sense to limit deeper idle states to cpuidle. Hopefully there is some informative splat for attempting to use arch_cpu_ide() for deeper idle states :) > I see similar code in omap2: > > omap2_pm_idle() > -> omap2_enter_full_retention() > -> omap2_sram_suspend() > > Is that code path safe to use without RCU or does it need a similar change? Seems like a similar change should be done for omap2. Then anybody who cares to implement a minimal cpuidle support can do so. Regards, Tony